This is the start of the stable review cycle for the 4.19.321 release. There are 98 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Tue, 03 Sep 2024 16:07:34 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.321-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
------------- Pseudo-Shortlog of commits:
Greg Kroah-Hartman gregkh@linuxfoundation.org Linux 4.19.321-rc1
Daniel Vetter daniel.vetter@ffwll.ch drm/fb-helper: set x/yres_virtual in drm_fb_helper_check_var
Vasily Averin vvs@virtuozzo.com ipc: remove memcg accounting for sops objects in do_semtimedop()
Ben Hutchings benh@debian.org scsi: aacraid: Fix double-free on probe failure
Zijun Hu quic_zijuhu@quicinc.com usb: core: sysfs: Unmerge @usb3_hardware_lpm_attr_group in remove_power_attributes()
Krzysztof Kozlowski krzysztof.kozlowski@linaro.org usb: dwc3: st: fix probed platform device ref count on probe error path
Selvarasu Ganesan selvarasu.g@samsung.com usb: dwc3: core: Prevent USB core invalid event buffer address access
Krzysztof Kozlowski krzysztof.kozlowski@linaro.org usb: dwc3: omap: add missing depopulate in probe error path
ZHANG Yuntian yt@radxa.com USB: serial: option: add MeiG Smart SRM825L
Ian Ray ian.ray@gehealthcare.com cdc-acm: Add DISABLE_ECHO quirk for GE HealthCare UI Controller
Eric Dumazet edumazet@google.com net: busy-poll: use ktime_get_ns() instead of local_clock()
Cong Wang cong.wang@bytedance.com gtp: fix a potential NULL pointer dereference
Krzysztof Kozlowski krzysztof.kozlowski@linaro.org soundwire: stream: fix programming slave ports for non-continous port maps
Eric Dumazet edumazet@google.com net: prevent mss overflow in skb_segment()
Matthew Wilcox (Oracle) willy@infradead.org ida: Fix crash in ida_free when the bitmap is empty
Allison Henderson allison.henderson@oracle.com net:rds: Fix possible deadlock in rds_message_put
Helge Deller deller@gmx.de fbmem: Check virtual screen sizes in fb_set_var()
Helge Deller deller@gmx.de fbcon: Prevent that screen size is smaller than font size
Vasily Averin vvs@virtuozzo.com memcg: enable accounting of ipc resources
Chen Ridong chenridong@huawei.com cgroup/cpuset: Prevent UAF in proc_cpuset_show()
Niklas Cassel cassel@kernel.org ata: libata-core: Fix null pointer dereference on error
Ricardo Ribalda ribalda@chromium.org media: uvcvideo: Fix integer overflow calculating timestamp
Long Li leo.lilong@huawei.com filelock: Correct the filelock owner in fcntl_setlk/fcntl_setlk64
Damien Le Moal dlemoal@kernel.org scsi: mpt3sas: Avoid IOMMU page faults on REPORT ZONES
Mikulas Patocka mpatocka@redhat.com dm suspend: return -ERESTARTSYS instead of -EINTR
Sascha Hauer s.hauer@pengutronix.de wifi: mwifiex: duplicate static structs used in driver instances
Ma Ke make24@iscas.ac.cn pinctrl: single: fix potential NULL dereference in pcs_get_function()
Jesse Zhang jesse.zhang@amd.com drm/amdgpu: Using uninitialized value *size when calling amdgpu_vce_cs_reloc
Alexander Lobakin aleksander.lobakin@intel.com tools: move alignment-related macros to new <linux/align.h>
Tetsuo Handa penguin-kernel@I-love.SAKURA.ne.jp Input: MT - limit max slots
Lee, Chun-Yi joeyli.kernel@gmail.com Bluetooth: hci_ldisc: check HCI_UART_PROTO_READY flag in HCIUARTGETPROTO
Takashi Iwai tiwai@suse.de ALSA: timer: Relax start tick time check for slave timer elements
Ben Whitten ben.whitten@gmail.com mmc: dw_mmc: allow biu and ciu clocks to defer
Nikolay Kuratov kniv@yandex-team.ru cxgb4: add forgotten u64 ivlan cast before shift
Jason Gerecke jason.gerecke@wacom.com HID: wacom: Defer calculation of resolution until resolution_code is known
Griffin Kroah-Hartman griffin@kroah.com Bluetooth: MGMT: Add error handling to pair_device()
Dan Carpenter dan.carpenter@linaro.org mmc: mmc_test: Fix NULL dereference on allocation failure
Dmitry Baryshkov dmitry.baryshkov@linaro.org drm/msm/dpu: don't play tricks with debug macros
Jani Nikula jani.nikula@intel.com drm/msm: use drm_debug_enabled() to check for debug categories
Sean Anderson sean.anderson@linux.dev net: xilinx: axienet: Always disable promiscuous mode
Eric Dumazet edumazet@google.com ipv6: prevent UAF in ip6_send_skb()
Sebastian Andrzej Siewior bigeasy@linutronix.de netfilter: nft_counter: Synchronize nft_counter_reset() against reader.
Kuniyuki Iwashima kuniyu@amazon.com kcm: Serialise kcm_sendmsg() for the same socket.
Luiz Augusto von Dentz luiz.von.dentz@intel.com Bluetooth: hci_core: Fix LE quote calculation
Luiz Augusto von Dentz luiz.von.dentz@intel.com Bluetooth: hci_core: Fix not handling link timeouts propertly
Luiz Augusto von Dentz luiz.von.dentz@intel.com Bluetooth: Make use of __check_timeout on hci_sched_le
Tetsuo Handa penguin-kernel@i-love.sakura.ne.jp block: use "unsigned long" for blk_validate_block_size().
Eric Dumazet edumazet@google.com gtp: pull network headers in gtp_dev_xmit()
Phil Chang phil.chang@mediatek.com hrtimer: Prevent queuing of hrtimer without a function callback
Sagi Grimberg sagi@grimberg.me nvmet-rdma: fix possible bad dereference when freeing rsps
Baokun Li libaokun1@huawei.com ext4: set the type of max_zeroout to unsigned int to avoid overflow
Guanrui Huang guanrui.huang@linux.alibaba.com irqchip/gic-v3-its: Remove BUG_ON in its_vpe_irq_domain_alloc
Abdulrasaq Lawani abdulrasaqolawani@gmail.com fbdev: offb: replace of_node_put with __free(device_node)
Krishna Kurapati quic_kriskura@quicinc.com usb: dwc3: core: Skip setting event buffers for host only controllers
Alexander Gordeev agordeev@linux.ibm.com s390/iucv: fix receive buffer virtual vs physical address confusion
Oreoluwa Babatunde quic_obabatun@quicinc.com openrisc: Call setup_memory() earlier in the init sequence
NeilBrown neilb@suse.de NFS: avoid infinite loop in pnfs_update_layout.
Luiz Augusto von Dentz luiz.von.dentz@intel.com Bluetooth: bnep: Fix out-of-bound access
Uwe Kleine-König u.kleine-koenig@pengutronix.de usb: gadget: fsl: Increase size of name buffer for endpoints
Zhiguo Niu zhiguo.niu@unisoc.com f2fs: fix to do sanity check in update_sit_entry
David Sterba dsterba@suse.com btrfs: delete pointless BUG_ON check on quota root in btrfs_qgroup_account_extent()
David Sterba dsterba@suse.com btrfs: send: handle unexpected data in header buffer in begin_cmd()
David Sterba dsterba@suse.com btrfs: handle invalid root reference found in may_destroy_subvol()
David Sterba dsterba@suse.com btrfs: change BUG_ON to assertion when checking for delayed_node root
Michael Ellerman mpe@ellerman.id.au powerpc/boot: Only free if realloc() succeeds
Li zeming zeming@nfschina.com powerpc/boot: Handle allocation failure in simple_realloc()
Helge Deller deller@gmx.de parisc: Use irq_enter_rcu() to fix warning at kernel/context_tracking.c:367
Li Nan linan122@huawei.com md: clean up invalid BUG_ON in md_ioctl
Kees Cook keescook@chromium.org net/sun3_82586: Avoid reading past buffer in debug output
Justin Tee justin.tee@broadcom.com scsi: lpfc: Initialize status local variable in lpfc_sli4_repost_sgl_list()
Max Filippov jcmvbkbc@gmail.com fs: binfmt_elf_efpic: don't use missing interpreter's properties
Hans Verkuil hverkuil-cisco@xs4all.nl media: pci: cx23885: check cx23885_vdev_init() return
Jan Kara jack@suse.cz quota: Remove BUG_ON from dqget()
Baokun Li libaokun1@huawei.com ext4: do not trim the group with corrupted block bitmap
Kunwu Chan chentao@kylinos.cn powerpc/xics: Check return value of kasprintf in icp_native_map_one_cpu
Miri Korenblit miriam.rachel.korenblit@intel.com wifi: iwlwifi: abort scan when rfkill on but device enabled
Andreas Gruenbacher agruenba@redhat.com gfs2: setattr_chown: Add missing initialization
Mike Christie michael.christie@oracle.com scsi: spi: Fix sshdr use
Christian Brauner christian.brauner@ubuntu.com binfmt_misc: cleanup on filesystem umount
Chengfeng Ye dg573847474@gmail.com staging: ks7010: disable bh on tx_dev_lock
Wolfram Sang wsa+renesas@sang-engineering.com i2c: riic: avoid potential division by zero
Jeff Johnson quic_jjohnson@quicinc.com wifi: cw1200: Avoid processing an invalid TIM IE
Rand Deeb rand.sec96@gmail.com ssb: Fix division by zero issue in ssb_calc_clock_rate
Pawel Dembicki paweldembicki@gmail.com net: dsa: vsc73xx: pass value in phy_write operation
Dan Carpenter dan.carpenter@linaro.org atm: idt77252: prevent use after free in dequeue_rx()
Cosmin Ratiu cratiu@nvidia.com net/mlx5e: Correctly report errors for ethtool rx flows
Alexander Lobakin aleksander.lobakin@intel.com btrfs: rename bitmap_set_bits() -> btrfs_bitmap_set_bits()
Alexander Lobakin aleksander.lobakin@intel.com s390/cio: rename bitmap_size() -> idset_bitmap_size()
Al Viro viro@zeniv.linux.org.uk memcg_write_event_control(): fix a user-triggerable oops
Bas Nieuwenhuizen bas@basnieuwenhuizen.nl drm/amdgpu: Actually check flags for all context ops.
Zhen Lei thunder.leizhen@huawei.com selinux: fix potential counting error in avc_add_xperms_decision()
Al Viro viro@zeniv.linux.org.uk fix bitmap corruption on close_range() with CLOSE_RANGE_UNSHARE
Alexander Lobakin aleksander.lobakin@intel.com bitmap: introduce generic optimized bitmap_size()
Mikulas Patocka mpatocka@redhat.com dm persistent data: fix memory allocation failure
Khazhismel Kumykov khazhy@google.com dm resume: don't return EINVAL when signalled
Haibo Xu haibo1.xu@intel.com arm64: ACPI: NUMA: initialize all values of acpi_early_node_map to NUMA_NO_NODE
Mathias Nyman mathias.nyman@linux.intel.com xhci: Fix Panther point NULL pointer deref at full-speed re-enumeration
Juan José Arboleda soyjuanarbol@gmail.com ALSA: usb-audio: Support Yamaha P-125 quirk entry
Jann Horn jannh@google.com fuse: Initialize beyond-EOF page contents before setting uptodate
-------------
Diffstat:
Makefile | 4 +- arch/arm64/kernel/acpi_numa.c | 2 +- arch/openrisc/kernel/setup.c | 6 +- arch/parisc/kernel/irq.c | 4 +- arch/powerpc/boot/simple_alloc.c | 7 +- arch/powerpc/sysdev/xics/icp-native.c | 2 + drivers/ata/libata-core.c | 3 + drivers/atm/idt77252.c | 9 +- drivers/bluetooth/hci_ldisc.c | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 8 + drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 3 +- drivers/gpu/drm/drm_fb_helper.c | 3 + drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 14 +- drivers/hid/wacom_wac.c | 4 +- drivers/i2c/busses/i2c-riic.c | 2 +- drivers/input/input-mt.c | 3 + drivers/irqchip/irq-gic-v3-its.c | 2 - drivers/md/dm-ioctl.c | 22 ++- drivers/md/dm.c | 2 +- drivers/md/md.c | 5 - drivers/md/persistent-data/dm-space-map-metadata.c | 4 +- drivers/media/pci/cx23885/cx23885-video.c | 8 + drivers/media/usb/uvc/uvc_video.c | 10 +- drivers/mmc/core/mmc_test.c | 9 +- drivers/mmc/host/dw_mmc.c | 8 + drivers/net/dsa/vitesse-vsc73xx.c | 2 +- drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 3 +- drivers/net/ethernet/i825xx/sun3_82586.c | 2 +- .../ethernet/mellanox/mlx5/core/en_fs_ethtool.c | 2 +- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 4 + drivers/net/gtp.c | 5 +- drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 2 +- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 32 ++- drivers/net/wireless/st/cw1200/txrx.c | 2 +- drivers/nvme/target/rdma.c | 16 +- drivers/pinctrl/pinctrl-single.c | 2 + drivers/s390/cio/idset.c | 12 +- drivers/scsi/aacraid/comminit.c | 2 + drivers/scsi/lpfc/lpfc_sli.c | 2 +- drivers/scsi/mpt3sas/mpt3sas_base.c | 20 +- drivers/scsi/scsi_transport_spi.c | 4 +- drivers/soundwire/stream.c | 8 +- drivers/ssb/main.c | 2 +- drivers/staging/ks7010/ks7010_sdio.c | 4 +- drivers/usb/class/cdc-acm.c | 3 + drivers/usb/core/sysfs.c | 1 + drivers/usb/dwc3/core.c | 21 ++ drivers/usb/dwc3/dwc3-omap.c | 4 +- drivers/usb/dwc3/dwc3-st.c | 11 +- drivers/usb/gadget/udc/fsl_udc_core.c | 2 +- drivers/usb/host/xhci.c | 8 +- drivers/usb/serial/option.c | 5 + drivers/video/fbdev/core/fbcon.c | 28 +++ drivers/video/fbdev/core/fbmem.c | 20 +- drivers/video/fbdev/offb.c | 3 +- fs/binfmt_elf_fdpic.c | 2 +- fs/binfmt_misc.c | 216 ++++++++++++++++----- fs/btrfs/delayed-inode.c | 2 +- fs/btrfs/free-space-cache.c | 8 +- fs/btrfs/inode.c | 9 +- fs/btrfs/qgroup.c | 2 - fs/btrfs/send.c | 7 +- fs/ext4/extents.c | 3 +- fs/ext4/mballoc.c | 3 + fs/f2fs/segment.c | 5 +- fs/file.c | 28 ++- fs/fuse/dev.c | 6 +- fs/gfs2/inode.c | 2 +- fs/locks.c | 4 +- fs/nfs/pnfs.c | 8 + fs/quota/dquot.c | 5 +- include/linux/bitmap.h | 20 +- include/linux/blkdev.h | 2 +- include/linux/cpumask.h | 2 +- include/linux/fbcon.h | 4 + include/net/busy_poll.h | 2 +- include/net/kcm.h | 1 + ipc/msg.c | 2 +- ipc/sem.c | 7 +- ipc/shm.c | 2 +- kernel/cgroup/cpuset.c | 13 +- kernel/time/hrtimer.c | 2 + lib/idr.c | 2 +- lib/test_ida.c | 40 ++++ mm/memcontrol.c | 7 +- net/bluetooth/bnep/core.c | 3 +- net/bluetooth/hci_core.c | 58 +++--- net/bluetooth/mgmt.c | 4 + net/core/skbuff.c | 3 +- net/ipv6/ip6_output.c | 2 + net/iucv/iucv.c | 3 +- net/kcm/kcmsock.c | 4 + net/netfilter/nft_counter.c | 5 + net/rds/recv.c | 13 +- security/selinux/avc.c | 2 +- sound/core/timer.c | 2 +- sound/usb/quirks-table.h | 1 + tools/include/linux/align.h | 12 ++ tools/include/linux/bitmap.h | 8 +- 99 files changed, 662 insertions(+), 253 deletions(-)
Hi!
This is the start of the stable review cycle for the 4.19.321 release. There are 98 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
CIP testing did not find any problems here:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4...
Tested-by: Pavel Machek (CIP) pavel@denx.de
Best regards, Pavel
On Sun, 1 Sept 2024 at 21:50, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.321 release. There are 98 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Tue, 03 Sep 2024 16:07:34 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.321-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
The Powerpc defconfig builds failed on Linux stable-rc due to following build warnings / errors with clang-18 and gcc-12.
This is a same problem on current stable-rc review on - 4.19.321-rc1 review - 5.4.283-rc1 review - 5.10.225-rc1 review - 5.15.166-rc1 review
In the case of stable-rc linux-4.19.y
Reported-by: Linux Kernel Functional Testing lkft@linaro.org
Anders bisected this to first bad commit id as, fbdev: offb: replace of_node_put with __free(device_node) [ Upstream commit ce4a7ae84a58b9f33aae8d6c769b3c94f3d5ce76 ]
build log: -------- kernel/profile.c: In function 'profile_dead_cpu': kernel/profile.c:346:27: warning: the comparison will always evaluate as 'true' for the address of 'prof_cpu_mask' will never be NULL [-Waddress] 346 | if (prof_cpu_mask != NULL) | ^~ kernel/profile.c:49:22: note: 'prof_cpu_mask' declared here 49 | static cpumask_var_t prof_cpu_mask; | ^~~~~~~~~~~~~ kernel/profile.c: In function 'profile_online_cpu': kernel/profile.c:383:27: warning: the comparison will always evaluate as 'true' for the address of 'prof_cpu_mask' will never be NULL [-Waddress] 383 | if (prof_cpu_mask != NULL) | ^~ kernel/profile.c:49:22: note: 'prof_cpu_mask' declared here 49 | static cpumask_var_t prof_cpu_mask; | ^~~~~~~~~~~~~ kernel/profile.c: In function 'profile_tick': kernel/profile.c:413:47: warning: the comparison will always evaluate as 'true' for the address of 'prof_cpu_mask' will never be NULL [-Waddress] 413 | if (!user_mode(regs) && prof_cpu_mask != NULL && | ^~ kernel/profile.c:49:22: note: 'prof_cpu_mask' declared here 49 | static cpumask_var_t prof_cpu_mask; | ^~~~~~~~~~~~~ fs/xfs/libxfs/xfs_inode_fork.c: In function 'xfs_ifork_verify_attr': fs/xfs/libxfs/xfs_inode_fork.c:731:13: warning: the comparison will always evaluate as 'true' for the address of 'i_df' will never be NULL [-Waddress] 731 | if (!XFS_IFORK_PTR(ip, XFS_ATTR_FORK)) | ^ In file included from fs/xfs/libxfs/xfs_inode_fork.c:14: fs/xfs/xfs_inode.h:38:33: note: 'i_df' declared here 38 | struct xfs_ifork i_df; /* data fork */ | ^~~~ drivers/video/fbdev/offb.c: In function 'offb_init_palette_hacks': drivers/video/fbdev/offb.c:355:47: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__free' 355 | struct device_node *pciparent __free(device_node) = of_get_parent(dp); | ^~~~~~ drivers/video/fbdev/offb.c:355:47: error: implicit declaration of function '__free'; did you mean 'kzfree'? [-Werror=implicit-function-declaration] 355 | struct device_node *pciparent __free(device_node) = of_get_parent(dp); | ^~~~~~ | kzfree drivers/video/fbdev/offb.c:355:54: error: 'device_node' undeclared (first use in this function) 355 | struct device_node *pciparent __free(device_node) = of_get_parent(dp); | ^~~~~~~~~~~ drivers/video/fbdev/offb.c:355:54: note: each undeclared identifier is reported only once for each function it appears in drivers/video/fbdev/offb.c:356:17: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 356 | const u32 *vid, *did; | ^~~~~ drivers/video/fbdev/offb.c:357:39: error: 'pciparent' undeclared (first use in this function); did you mean 'pci_alert'? 357 | vid = of_get_property(pciparent, "vendor-id", NULL); | ^~~~~~~~~ | pci_alert cc1: some warnings being treated as errors
Build Log links, -------- - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-4.19.y/build/v4.19....
-- Linaro LKFT https://lkft.linaro.org
On Mon, Sep 02, 2024 at 02:16:48PM +0530, Naresh Kamboju wrote:
On Sun, 1 Sept 2024 at 21:50, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.321 release. There are 98 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Tue, 03 Sep 2024 16:07:34 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.321-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
The Powerpc defconfig builds failed on Linux stable-rc due to following build warnings / errors with clang-18 and gcc-12.
This is a same problem on current stable-rc review on
- 4.19.321-rc1 review
- 5.4.283-rc1 review
- 5.10.225-rc1 review
- 5.15.166-rc1 review
In the case of stable-rc linux-4.19.y
Reported-by: Linux Kernel Functional Testing lkft@linaro.org
Anders bisected this to first bad commit id as, fbdev: offb: replace of_node_put with __free(device_node) [ Upstream commit ce4a7ae84a58b9f33aae8d6c769b3c94f3d5ce76 ]
Now dropped, thanks.
greg k-h
On Sun, 1 Sept 2024 at 21:50, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.321 release. There are 98 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Tue, 03 Sep 2024 16:07:34 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.321-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Apart from Powerpc build regressions we have noticed s390 build regression. The S390 defconfig builds failed on Linux stable-rc 4.19.321-rc1 due to following build warnings / errors with clang-18 and gcc-12.
This is a same problem on current stable-rc review on - 4.19.321-rc1 review
In the case of stable-rc linux-4.19.y
Reported-by: Linux Kernel Functional Testing lkft@linaro.org
Following two commits have been added on 4.19.321-rc1. ------- s390/cio: rename bitmap_size() -> idset_bitmap_size() commit c1023f5634b9bfcbfff0dc200245309e3cde9b54 upstream.
bitmap: introduce generic optimized bitmap_size() commit a37fbe666c016fd89e4460d0ebfcea05baba46dc upstream.
build log: -------- drivers/s390/cio/idset.c: In function 'idset_bitmap_size': drivers/s390/cio/idset.c:21:28: error: implicit declaration of function 'size_mul' [-Werror=implicit-function-declaration] 21 | return bitmap_size(size_mul(num_ssid, num_id)); | ^~~~~~~~ include/uapi/linux/const.h:32:44: note: in definition of macro '__ALIGN_KERNEL_MASK' 32 | #define __ALIGN_KERNEL_MASK(x, mask) (((x) + (mask)) & ~(mask)) | ^ include/linux/kernel.h:58:33: note: in expansion of macro '__ALIGN_KERNEL' 58 | #define ALIGN(x, a) __ALIGN_KERNEL((x), (a)) | ^~~~~~~~~~~~~~ include/linux/bitmap.h:215:34: note: in expansion of macro 'ALIGN' 215 | #define bitmap_size(nbits) (ALIGN(nbits, BITS_PER_LONG) / BITS_PER_BYTE) | ^~~~~ drivers/s390/cio/idset.c:21:16: note: in expansion of macro 'bitmap_size' 21 | return bitmap_size(size_mul(num_ssid, num_id)); | ^~~~~~~~~~~ cc1: some warnings being treated as errors
Build Log links, -------- - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-4.19.y/build/v4.19....
metadata: ---- git describe: v4.19.320-99-g0cc44dd838a6 git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git git sha: 0cc44dd838a6e3fee60d7af3ca412c4d1b824562 kernel config: https://storage.tuxsuite.com/public/linaro/lkft/builds/2lTf8qakoJKDjTgS3TvH3... build url: https://storage.tuxsuite.com/public/linaro/lkft/builds/2lTf8qakoJKDjTgS3TvH3... toolchain: clang-18 and gcc-12 config: defconfig arch: S390
Steps to reproduce: --------- - tuxmake --runtime podman --target-arch s390 --toolchain gcc-12 --kconfig defconfig
-- Linaro LKFT https://lkft.linaro.org
On Mon, Sep 02, 2024 at 02:30:57PM +0530, Naresh Kamboju wrote:
On Sun, 1 Sept 2024 at 21:50, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.321 release. There are 98 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Tue, 03 Sep 2024 16:07:34 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.321-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Apart from Powerpc build regressions we have noticed s390 build regression. The S390 defconfig builds failed on Linux stable-rc 4.19.321-rc1 due to following build warnings / errors with clang-18 and gcc-12.
This is a same problem on current stable-rc review on
- 4.19.321-rc1 review
In the case of stable-rc linux-4.19.y
Reported-by: Linux Kernel Functional Testing lkft@linaro.org
Following two commits have been added on 4.19.321-rc1.
s390/cio: rename bitmap_size() -> idset_bitmap_size() commit c1023f5634b9bfcbfff0dc200245309e3cde9b54 upstream.
bitmap: introduce generic optimized bitmap_size() commit a37fbe666c016fd89e4460d0ebfcea05baba46dc upstream.
Odd, this should have also shown up in your 5.4.y builds too.
I'll go drop this from both trees now, thanks.
greg k-h
On Wed, Sep 04, 2024 at 11:38:05AM +0200, Greg Kroah-Hartman wrote:
On Mon, Sep 02, 2024 at 02:30:57PM +0530, Naresh Kamboju wrote:
On Sun, 1 Sept 2024 at 21:50, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
This is the start of the stable review cycle for the 4.19.321 release. There are 98 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Tue, 03 Sep 2024 16:07:34 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.321-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
Apart from Powerpc build regressions we have noticed s390 build regression. The S390 defconfig builds failed on Linux stable-rc 4.19.321-rc1 due to following build warnings / errors with clang-18 and gcc-12.
This is a same problem on current stable-rc review on
- 4.19.321-rc1 review
In the case of stable-rc linux-4.19.y
Reported-by: Linux Kernel Functional Testing lkft@linaro.org
Following two commits have been added on 4.19.321-rc1.
s390/cio: rename bitmap_size() -> idset_bitmap_size() commit c1023f5634b9bfcbfff0dc200245309e3cde9b54 upstream.
bitmap: introduce generic optimized bitmap_size() commit a37fbe666c016fd89e4460d0ebfcea05baba46dc upstream.
Odd, this should have also shown up in your 5.4.y builds too.
I'll go drop this from both trees now, thanks.
Nope, I need it there, I'll go add some helper functions to make this work, thanks.
greg k-h
Hi Greg,
On 01/09/24 21:45, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.19.321 release. There are 98 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Tue, 03 Sep 2024 16:07:34 +0000. Anything received after that time might be too late.
Build fails on our infrastructure.
BUILDSTDERR: In file included from /builddir/build/BUILD/kernel-4.19.321/linux-4.19.321-master.20240901.el7.dev/tools/include/linux/bitmap.h:6, BUILDSTDERR: from /builddir/build/BUILD/kernel-4.19.321/linux-4.19.321-master.20240901.el7.dev/tools/perf/util/include/../../util/pmu.h:5, BUILDSTDERR: from arch/x86/util/pmu.c:9: BUILDSTDERR: /builddir/build/BUILD/kernel-4.19.321/linux-4.19.321-master.20240901.el7.dev/tools/include/linux/align.h:6:10: fatal error: uapi/linux/const.h: No such file or directory BUILDSTDERR: #include <uapi/linux/const.h> BUILDSTDERR: ^~~~~~~~~~~~~~~~~~~~ BUILDSTDERR: compilation terminated.
Looked at the commits:
This commit 993a20bf6225c: ("tools: move alignment-related macros to new <linux/align.h>") is causing that perf build to fail.
Solution is not to drop this patch as this is probably pulled in to support bitmap_size() macros in these commits(which are also part of this release):
6fbe5a3920f48 fix bitmap corruption on close_range() with CLOSE_RANGE_UNSHARE ef9ebc42c10f8 bitmap: introduce generic optimized bitmap_size()
Applying the below diff, helps the perf build to pass: I think we should fold this into: commit 993a20bf6225c: ("tools: move alignment-related macros to new <linux/align.h>")
diff --git a/tools/include/linux/align.h b/tools/include/linux/align.h index 14e34ace80dda..a27bc1edf6e5c 100644 --- a/tools/include/linux/align.h +++ b/tools/include/linux/align.h @@ -3,7 +3,7 @@ #ifndef _TOOLS_LINUX_ALIGN_H #define _TOOLS_LINUX_ALIGN_H
-#include <uapi/linux/const.h> +#include <linux/const.h>
#define ALIGN(x, a) __ALIGN_KERNEL((x), (a)) #define ALIGN_DOWN(x, a) __ALIGN_KERNEL((x) - ((a) - 1), (a))
!! But this breaks the build for arm here. !! Not sure what is the best way to solve this problem.
Thanks, Harshit
On Mon, Sep 02, 2024 at 02:44:44PM +0530, Harshit Mogalapalli wrote:
Hi Greg,
On 01/09/24 21:45, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.19.321 release. There are 98 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Tue, 03 Sep 2024 16:07:34 +0000. Anything received after that time might be too late.
Build fails on our infrastructure.
BUILDSTDERR: In file included from /builddir/build/BUILD/kernel-4.19.321/linux-4.19.321-master.20240901.el7.dev/tools/include/linux/bitmap.h:6, BUILDSTDERR: from /builddir/build/BUILD/kernel-4.19.321/linux-4.19.321-master.20240901.el7.dev/tools/perf/util/include/../../util/pmu.h:5, BUILDSTDERR: from arch/x86/util/pmu.c:9: BUILDSTDERR: /builddir/build/BUILD/kernel-4.19.321/linux-4.19.321-master.20240901.el7.dev/tools/include/linux/align.h:6:10: fatal error: uapi/linux/const.h: No such file or directory BUILDSTDERR: #include <uapi/linux/const.h> BUILDSTDERR: ^~~~~~~~~~~~~~~~~~~~ BUILDSTDERR: compilation terminated.
Looked at the commits:
This commit 993a20bf6225c: ("tools: move alignment-related macros to new <linux/align.h>") is causing that perf build to fail.
Solution is not to drop this patch as this is probably pulled in to support bitmap_size() macros in these commits(which are also part of this release):
6fbe5a3920f48 fix bitmap corruption on close_range() with CLOSE_RANGE_UNSHARE ef9ebc42c10f8 bitmap: introduce generic optimized bitmap_size()
Applying the below diff, helps the perf build to pass: I think we should fold this into: commit 993a20bf6225c: ("tools: move alignment-related macros to new <linux/align.h>")
diff --git a/tools/include/linux/align.h b/tools/include/linux/align.h index 14e34ace80dda..a27bc1edf6e5c 100644 --- a/tools/include/linux/align.h +++ b/tools/include/linux/align.h @@ -3,7 +3,7 @@ #ifndef _TOOLS_LINUX_ALIGN_H #define _TOOLS_LINUX_ALIGN_H
-#include <uapi/linux/const.h> +#include <linux/const.h>
#define ALIGN(x, a) __ALIGN_KERNEL((x), (a)) #define ALIGN_DOWN(x, a) __ALIGN_KERNEL((x) - ((a) - 1), (a))
Change now made, thanks.
!! But this breaks the build for arm here. !! Not sure what is the best way to solve this problem.
Are people building perf for arm on 4.19.y? If so, wow, this thing is about to go end-of-life any week now, and I would be amazed if it built at all anymore as I can't get perf to build on _ANY_ lts kernel these days.
Anyway, I'll make this change and if any arm build fixes want to show up, I'll be glad to take them.
thanks,
greg k-h
On Sun, 01 Sep 2024 18:15:30 +0200, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.19.321 release. There are 98 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Tue, 03 Sep 2024 16:07:34 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.321-rc... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y and the diffstat can be found below.
thanks,
greg k-h
All tests passing for Tegra ...
Test results for stable-v4.19: 10 builds: 10 pass, 0 fail 20 boots: 20 pass, 0 fail 37 tests: 37 pass, 0 fail
Linux version: 4.19.321-rc1-g0cc44dd838a6 Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000, tegra194-p2972-0000, tegra20-ventana, tegra210-p2371-2180, tegra30-cardhu-a04
Tested-by: Jon Hunter jonathanh@nvidia.com
Jon