This is the start of the stable review cycle for the 4.9.91 release. There are 67 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu Mar 29 16:27:08 UTC 2018. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.91-rc1.... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below.
thanks,
greg k-h
------------- Pseudo-Shortlog of commits:
Greg Kroah-Hartman gregkh@linuxfoundation.org Linux 4.9.91-rc1
Daniel Borkmann daniel@iogearbox.net bpf, x64: increase number of passes
Chenbo Feng fengc@google.com bpf: skip unnecessary capability check
Daniel Borkmann daniel@iogearbox.net kbuild: disable clang's default use of -fmerge-all-constants
Shuah Khan shuah@kernel.org selftests: x86: sysret_ss_attrs doesn't build on a PIE build
Dave Hansen dave.hansen@linux.intel.com x86/pkeys/selftests: Rename 'si_pkey' to 'siginfo_pkey'
Eric W. Biederman ebiederm@xmission.com signal/testing: Don't look for __SI_FAULT in userspace
Andy Lutomirski luto@kernel.org selftests/x86/protection_keys: Fix syscall NR redefinition warnings
Dave Hansen dave.hansen@linux.intel.com selftests, x86, protection_keys: fix wrong offset in siginfo
Nadav Amit namit@vmware.com staging: lustre: ptlrpc: kfree used instead of kvfree
Linus Walleij linus.walleij@linaro.org iio: ABI: Fix name of timestamp sysfs file
Kan Liang kan.liang@linux.intel.com perf/x86/intel/uncore: Fix multi-domain PCI CHA enumeration bug on Skylake servers
Dan Carpenter dan.carpenter@oracle.com perf/x86/intel: Don't accidentally clear high bits in bdw_limit_period()
Ilya Pronin ipronin@twitter.com perf stat: Fix CVS output format for non-supported counters
Kan Liang kan.liang@linux.intel.com perf/x86/intel/uncore: Fix Skylake UPI event format
Andy Lutomirski luto@kernel.org x86/entry/64: Don't use IST entry for #BP stack
H.J. Lu hjl.tools@gmail.com x86/boot/64: Verify alignment of the LOAD segment
H.J. Lu hjl.tools@gmail.com x86/build/64: Force the linker to use 2MB page size
Linus Torvalds torvalds@linux-foundation.org kvm/x86: fix icebp instruction handling
Andy Lutomirski luto@kernel.org selftests/x86/ptrace_syscall: Fix for yet more glibc interference
Linus Torvalds torvalds@linux-foundation.org tty: vt: fix up tabstops properly
Andri Yngvason andri.yngvason@marel.com can: cc770: Fix use after free in cc770_tx_interrupt()
Andri Yngvason andri.yngvason@marel.com can: cc770: Fix queue stall & dropped RTR reply
Andri Yngvason andri.yngvason@marel.com can: cc770: Fix stalls on rt-linux, remove redundant IRQ ack
Marek Vasut marex@denx.de can: ifi: Check core revision upon probe
Marek Vasut marex@denx.de can: ifi: Repair the error handling
Dan Carpenter dan.carpenter@oracle.com staging: ncpfs: memory corruption in ncp_read_kernel()
Jagdish Gediya jagdish.gediya@nxp.com mtd: nand: fsl_ifc: Read ECCSTAT0 and ECCSTAT1 registers for IFC 2.0
Jagdish Gediya jagdish.gediya@nxp.com mtd: nand: fsl_ifc: Fix eccstat array overflow for IFC ver >= 2.0.0
Jagdish Gediya jagdish.gediya@nxp.com mtd: nand: fsl_ifc: Fix nand waitfunc return value
OuYang ZhiZhong ouyzz@yealink.com mtdchar: fix usage of mtd_ooblayout_ecc()
Masami Hiramatsu mhiramat@kernel.org tracing: probeevent: Fix to support minus offset from symbol
Larry Finger Larry.Finger@lwfinger.net rtlwifi: rtl8723be: Fix loss of signal
Arend Van Spriel arend.vanspriel@broadcom.com brcmfmac: fix P2P_DEVICE ethernet address generation
Vishal Verma vishal.l.verma@intel.com libnvdimm, {btt, blk}: do integrity setup before add_disk()
Takashi Iwai tiwai@suse.de ACPI / watchdog: Fix off-by-one error at resource assignment
Dan Williams dan.j.williams@intel.com acpi, numa: fix pxm to online numa node associations
Greg Kroah-Hartman gregkh@linuxfoundation.org drm: udl: Properly check framebuffer mmap offsets
Michel Dänzer michel.daenzer@amd.com drm/radeon: Don't turn off DP sink when disconnected
Thomas Hellstrom thellstrom@vmware.com drm/vmwgfx: Fix a destoy-while-held mutex problem.
Kirill A. Shutemov kirill.shutemov@linux.intel.com mm/shmem: do not wait for lock_page() in shmem_unused_huge_shrink()
Kirill A. Shutemov kirill.shutemov@linux.intel.com mm/thp: do not wait for lock_page() in deferred_split_scan()
Kirill A. Shutemov kirill.shutemov@linux.intel.com mm/khugepaged.c: convert VM_BUG_ON() to collapse fail
Toshi Kani toshi.kani@hpe.com x86/mm: implement free pmd/pte page interfaces
Toshi Kani toshi.kani@hpe.com mm/vmalloc: add interfaces to free unmapped page table
Jeff Layton jlayton@redhat.com nfsd: remove blocked locks on client teardown
Hans de Goede hdegoede@redhat.com libata: Modify quirks for MX100 to limit NCQ_TRIM quirk to MU01 version
Hans de Goede hdegoede@redhat.com libata: Make Crucial BX100 500GB LPM quirk apply to all firmware versions
Hans de Goede hdegoede@redhat.com libata: Apply NOLPM quirk to Crucial M500 480 and 960GB SSDs
Ju Hyung Park qkrwngud825@gmail.com libata: Enable queued TRIM for Samsung SSD 860
Kai-Heng Feng kai.heng.feng@canonical.com libata: disable LPM for Crucial BX100 SSD 500GB drive
Hans de Goede hdegoede@redhat.com libata: Apply NOLPM quirk to Crucial MX100 512GB SSDs
Eric Biggers ebiggers@google.com libata: don't try to pass through NCQ commands to non-NCQ devices
Eric Biggers ebiggers@google.com libata: remove WARN() for DMA or PIO command without data
Eric Biggers ebiggers@google.com libata: fix length validation of ATAPI-relayed SCSI commands
Takashi Iwai tiwai@suse.de Bluetooth: btusb: Fix quirk for Atheros 1525/QCA6174
Chen-Yu Tsai wens@csie.org clk: sunxi-ng: a31: Fix CLK_OUT_* clock ops
Boris Brezillon boris.brezillon@bootlin.com clk: bcm2835: Protect sections updating shared registers
Boris Brezillon boris.brezillon@bootlin.com clk: bcm2835: Fix ana->maskX definitions
Hans de Goede hdegoede@redhat.com ahci: Add PCI-id for the Highpoint Rocketraid 644L card
Hans de Goede hdegoede@redhat.com PCI: Add function 1 DMA alias quirk for Highpoint RocketRAID 644L
Evgeniy Didin Evgeniy.Didin@synopsys.com mmc: dw_mmc: fix falling from idmac to PIO mode when dw_mci_reset occurs
Takashi Iwai tiwai@suse.de ALSA: hda/realtek - Always immediately update mute LED with pin VREF
Takashi Iwai tiwai@suse.de ALSA: aloop: Fix access to not-yet-ready substream via cable
Takashi Iwai tiwai@suse.de ALSA: aloop: Sync stale timer before release
Kirill Marinushkin k.marinushkin@gmail.com ALSA: usb-audio: Fix parsing descriptor of UAC2 processing unit
Michael Nosthoff committed@heine.so iio: st_pressure: st_accel: pass correct platform data to init
NeilBrown neil@brown.name MIPS: ralink: Remove ralink_halt()
-------------
Diffstat:
Documentation/ABI/testing/sysfs-bus-iio | 2 +- Makefile | 13 ++- arch/arm64/mm/mmu.c | 10 +++ arch/mips/ralink/reset.c | 7 -- arch/x86/Makefile | 9 ++ arch/x86/boot/compressed/misc.c | 4 + arch/x86/entry/entry_64.S | 2 +- arch/x86/events/intel/core.c | 2 +- arch/x86/events/intel/uncore_snbep.c | 33 +++---- arch/x86/include/asm/vmx.h | 1 + arch/x86/kernel/traps.c | 24 +++-- arch/x86/kvm/vmx.c | 9 +- arch/x86/mm/pgtable.c | 48 ++++++++++ arch/x86/net/bpf_jit_comp.c | 3 +- drivers/acpi/acpi_watchdog.c | 4 +- drivers/acpi/numa.c | 10 ++- drivers/ata/ahci.c | 4 +- drivers/ata/libata-core.c | 26 +++++- drivers/ata/libata-scsi.c | 10 ++- drivers/bluetooth/btusb.c | 2 +- drivers/clk/bcm/clk-bcm2835.c | 12 ++- drivers/clk/sunxi-ng/ccu-sun6i-a31.c | 6 +- drivers/gpu/drm/radeon/radeon_connectors.c | 31 +++---- drivers/gpu/drm/udl/udl_fb.c | 9 +- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 28 ++++-- drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 12 ++- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 5 +- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 5 +- drivers/iio/accel/st_accel_core.c | 2 +- drivers/iio/pressure/st_pressure_core.c | 2 +- drivers/mmc/host/dw_mmc.c | 6 +- drivers/mtd/mtdchar.c | 4 +- drivers/mtd/nand/fsl_ifc_nand.c | 32 +++---- drivers/net/can/cc770/cc770.c | 100 +++++++++++++-------- drivers/net/can/cc770/cc770.h | 2 + drivers/net/can/ifi_canfd/ifi_canfd.c | 75 ++++++++++------ .../net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 24 +++-- .../net/wireless/realtek/rtlwifi/rtl8723be/hw.c | 3 +- drivers/nvdimm/blk.c | 3 +- drivers/nvdimm/btt.c | 3 +- drivers/pci/quirks.c | 2 + drivers/staging/lustre/lustre/ptlrpc/sec.c | 2 +- drivers/tty/vt/vt.c | 8 +- drivers/watchdog/wdat_wdt.c | 2 +- fs/ncpfs/ncplib_kernel.c | 4 + fs/nfsd/nfs4state.c | 62 +++++++++---- include/asm-generic/pgtable.h | 10 +++ include/linux/fsl_ifc.h | 6 +- include/uapi/linux/usb/audio.h | 4 +- kernel/bpf/syscall.c | 2 +- kernel/trace/trace_kprobe.c | 4 +- kernel/trace/trace_probe.c | 8 +- kernel/trace/trace_probe.h | 2 +- lib/ioremap.c | 6 +- mm/huge_memory.c | 4 +- mm/khugepaged.c | 7 +- mm/shmem.c | 31 ++++--- sound/drivers/aloop.c | 17 +++- sound/pci/hda/patch_realtek.c | 6 +- tools/perf/builtin-stat.c | 2 +- tools/testing/selftests/x86/Makefile | 2 +- tools/testing/selftests/x86/mpx-mini-test.c | 3 +- tools/testing/selftests/x86/protection_keys.c | 49 ++++++---- tools/testing/selftests/x86/ptrace_syscall.c | 8 +- 64 files changed, 546 insertions(+), 292 deletions(-)
On 03/27/2018 10:26 AM, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.9.91 release. There are 67 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu Mar 29 16:27:08 UTC 2018. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.91-rc1.... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below.
thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks, -- Shuah
stable-rc/linux-4.9.y boot: 118 boots: 0 failed, 106 passed with 10 offline, 2 untried/unknown (v4.9.90-68-gf6c4b8eea9f0)
Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.9.y/kernel/v4.9.9... Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.9.y/kernel/v4.9.90-68-gf...
Tree: stable-rc Branch: linux-4.9.y Git Describe: v4.9.90-68-gf6c4b8eea9f0 Git Commit: f6c4b8eea9f0ff250efcd95723cd73b8f2ecfef6 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Tested: 61 unique boards, 22 SoC families, 19 builds out of 183
Offline Platforms:
arm:
sunxi_defconfig: sun7i-a20-bananapi: 1 offline lab sun7i-a20-cubietruck: 1 offline lab
multi_v7_defconfig: exynos5410-odroidxu: 1 offline lab sun7i-a20-cubietruck: 1 offline lab tegra20-iris-512: 1 offline lab tegra30-beaver: 1 offline lab
exynos_defconfig: exynos5410-odroidxu: 1 offline lab
tegra_defconfig: tegra20-iris-512: 1 offline lab tegra30-beaver: 1 offline lab
arm64:
defconfig: meson-gxbb-odroidc2: 1 offline lab
--- For more info write to info@kernelci.org
On Tue, Mar 27, 2018 at 06:26:52PM +0200, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.9.91 release. There are 67 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu Mar 29 16:27:08 UTC 2018. Anything received after that time might be too late.
The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.91-rc1.... or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.9.y and the diffstat can be found below.
Results from Linaro’s test farm. No regressions on arm64, arm and x86_64.
Summary ------------------------------------------------------------------------
kernel: 4.9.91-rc1 git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git git branch: linux-4.9.y git commit: f6c4b8eea9f0ff250efcd95723cd73b8f2ecfef6 git describe: v4.9.90-68-gf6c4b8eea9f0 Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.9-oe/build/v4.9.90-68-g...
No regressions (compared to build v4.9.90)
Boards, architectures and test suites: -------------------------------------
dragonboard-410c * boot - pass: 20 * kselftest - skip: 27, pass: 36 * libhugetlbfs - skip: 1, pass: 90 * ltp-cap_bounds-tests - pass: 2 * ltp-containers-tests - skip: 17, pass: 64 * ltp-fcntl-locktests-tests - pass: 2 * ltp-filecaps-tests - pass: 2 * ltp-fs-tests - skip: 2, pass: 61 * ltp-fs_bind-tests - pass: 2 * ltp-fs_perms_simple-tests - pass: 19 * ltp-fsx-tests - pass: 2 * ltp-hugetlb-tests - skip: 1, pass: 21 * ltp-io-tests - pass: 3 * ltp-ipc-tests - pass: 9 * ltp-math-tests - pass: 11 * ltp-nptl-tests - pass: 2 * ltp-pty-tests - pass: 4 * ltp-sched-tests - pass: 14 * ltp-securebits-tests - pass: 4 * ltp-syscalls-tests - skip: 148, pass: 1002 * ltp-timers-tests - skip: 1, pass: 12
hi6220-hikey - arm64 * boot - pass: 20 * kselftest - skip: 24, pass: 39 * libhugetlbfs - skip: 1, pass: 90 * ltp-cap_bounds-tests - pass: 2 * ltp-containers-tests - skip: 17, pass: 64 * ltp-fcntl-locktests-tests - pass: 2 * ltp-filecaps-tests - pass: 2 * ltp-fs-tests - skip: 2, pass: 61 * ltp-fs_bind-tests - pass: 2 * ltp-fs_perms_simple-tests - pass: 19 * ltp-fsx-tests - pass: 2 * ltp-hugetlb-tests - skip: 1, pass: 21 * ltp-io-tests - pass: 3 * ltp-ipc-tests - pass: 9 * ltp-math-tests - pass: 11 * ltp-nptl-tests - pass: 2 * ltp-pty-tests - pass: 4 * ltp-sched-tests - skip: 4, pass: 10 * ltp-securebits-tests - pass: 4 * ltp-syscalls-tests - skip: 151, pass: 999 * ltp-timers-tests - skip: 1, pass: 12
juno-r2 - arm64 * boot - pass: 20 * kselftest - skip: 23, pass: 40 * libhugetlbfs - skip: 1, pass: 90 * ltp-cap_bounds-tests - pass: 2 * ltp-containers-tests - skip: 17, pass: 64 * ltp-fcntl-locktests-tests - pass: 2 * ltp-filecaps-tests - pass: 2 * ltp-fs-tests - skip: 2, pass: 61 * ltp-fs_bind-tests - pass: 2 * ltp-fs_perms_simple-tests - pass: 19 * ltp-fsx-tests - pass: 2 * ltp-hugetlb-tests - pass: 22 * ltp-io-tests - pass: 3 * ltp-ipc-tests - pass: 9 * ltp-math-tests - pass: 11 * ltp-nptl-tests - pass: 2 * ltp-pty-tests - pass: 4 * ltp-sched-tests - skip: 4, pass: 10 * ltp-securebits-tests - pass: 4 * ltp-syscalls-tests - skip: 149, pass: 1001 * ltp-timers-tests - skip: 1, pass: 12
qemu_x86_64 * boot - pass: 21 * kselftest - skip: 28, pass: 52 * kselftest-vsyscall-mode-native - skip: 28, pass: 52 * kselftest-vsyscall-mode-none - skip: 28, pass: 52 * ltp-cap_bounds-tests - pass: 2 * ltp-containers-tests - skip: 17, pass: 64 * ltp-fcntl-locktests-tests - pass: 2 * ltp-filecaps-tests - pass: 2 * ltp-fs-tests - skip: 6, pass: 57 * ltp-fs_bind-tests - pass: 2 * ltp-fs_perms_simple-tests - pass: 19 * ltp-fsx-tests - pass: 2 * ltp-io-tests - pass: 3 * ltp-ipc-tests - pass: 9 * ltp-math-tests - pass: 11 * ltp-nptl-tests - pass: 2 * ltp-pty-tests - pass: 4 * ltp-sched-tests - skip: 1, pass: 13 * ltp-securebits-tests - pass: 4 * ltp-syscalls-tests - skip: 149, pass: 1001 * ltp-timers-tests - skip: 1, pass: 12
x15 - arm * boot - pass: 20 * kselftest - skip: 24, pass: 38 * libhugetlbfs - skip: 1, pass: 87 * ltp-cap_bounds-tests - pass: 2 * ltp-containers-tests - skip: 17, pass: 64 * ltp-fcntl-locktests-tests - pass: 2 * ltp-filecaps-tests - pass: 2 * ltp-fs-tests - skip: 2, pass: 61 * ltp-fs_bind-tests - pass: 2 * ltp-fs_perms_simple-tests - pass: 19 * ltp-fsx-tests - pass: 2 * ltp-hugetlb-tests - skip: 2, pass: 20 * ltp-io-tests - pass: 3 * ltp-ipc-tests - pass: 9 * ltp-math-tests - pass: 11 * ltp-nptl-tests - pass: 2 * ltp-pty-tests - pass: 4 * ltp-sched-tests - skip: 1, pass: 13 * ltp-securebits-tests - pass: 4 * ltp-syscalls-tests - skip: 97, pass: 1053 * ltp-timers-tests - skip: 1, pass: 12
x86_64 * boot - pass: 22 * kselftest - skip: 24, fail: 1, pass: 54 * kselftest-vsyscall-mode-native - skip: 24, fail: 1, pass: 54 * kselftest-vsyscall-mode-none - skip: 25, fail: 2, pass: 53 * libhugetlbfs - skip: 1, pass: 90 * ltp-cap_bounds-tests - pass: 2 * ltp-containers-tests - skip: 17, pass: 64 * ltp-fcntl-locktests-tests - pass: 2 * ltp-filecaps-tests - pass: 2 * ltp-fs-tests - skip: 1, pass: 62 * ltp-fs_bind-tests - pass: 2 * ltp-fs_perms_simple-tests - pass: 19 * ltp-fsx-tests - pass: 2 * ltp-hugetlb-tests - pass: 22 * ltp-io-tests - pass: 3 * ltp-ipc-tests - pass: 9 * ltp-math-tests - pass: 11 * ltp-nptl-tests - pass: 2 * ltp-pty-tests - pass: 4 * ltp-sched-tests - skip: 5, pass: 9 * ltp-securebits-tests - pass: 4 * ltp-syscalls-tests - skip: 119, pass: 1031 * ltp-timers-tests - skip: 1, pass: 12
-- Linaro QA (beta) https://qa-reports.linaro.org
On Tue, Mar 27, 2018 at 08:35:01PM -0500, Dan Rue wrote:
qemu_x86_64
- boot - pass: 21
- kselftest - skip: 28, pass: 52
Do you have a list of what you are skipping anywhere? There was some x86 changes that I had to backport that I was worried about getting right here, are you running the x86 kselftests?
thanks,
greg k-h
On Wed, Mar 28, 2018 at 10:21:45AM +0200, Greg Kroah-Hartman wrote:
On Tue, Mar 27, 2018 at 08:35:01PM -0500, Dan Rue wrote:
qemu_x86_64
- boot - pass: 21
- kselftest - skip: 28, pass: 52
Do you have a list of what you are skipping anywhere? There was some x86 changes that I had to backport that I was worried about getting right here, are you running the x86 kselftests?
Yes we run the x86 selftests. Here's the full list of what ran and what was skipped. Remember (I know you know, but for anyone else observing), we run kselftest from 4.15.
breakpoint_test — SKIP efivarfs.sh — SKIP fsgsbase_64 — SKIP ftracetest — SKIP fw_fallback.sh — SKIP fw_filesystem.sh — SKIP gpio-mockup.sh — SKIP ldt_gdt_64 — SKIP main.sh — SKIP mem-on-off-test.sh — SKIP pstore_tests — SKIP reuseport_bpf — SKIP run.sh — SKIP run_vmtests — SKIP seccomp_bpf — SKIP sigreturn_64 — SKIP step_after_suspend_test — SKIP sync_test — SKIP sysctl.sh — SKIP test_align — SKIP test_dev_cgroup — SKIP test_kmod.sh — SKIP test_lpm_map — SKIP test_lru_map — SKIP test_maps — SKIP test_progs — SKIP test_tag — SKIP test_verifier — SKIP 5lvl_64 — PASS bitmap.sh — PASS check_initial_reg_state_64 — PASS cpu-on-off-test.sh — PASS default_file_splice_read.sh — PASS execveat — PASS get_size — PASS inconsistency-check — PASS ioperm_64 — PASS iopl_64 — PASS kcmp_test — PASS membarrier_test — PASS mpx-mini-test_64 — PASS mqueue-lat — PASS msgque — PASS nanosleep — PASS netdevice.sh — PASS nsleep-lat — PASS owner — PASS peeksiginfo — PASS pidns — PASS posix_timers — PASS printf.sh — PASS protection_keys_64 — PASS pstore_post_reboot_tests — PASS ptrace_syscall_64 — PASS raw_skew — PASS reuseaddr_conflict — PASS reuseport_dualstack — PASS rtctest — PASS rtnetlink.sh — PASS run_afpackettests — PASS run_netsocktests — PASS run_tests.sh — PASS sas — PASS seccomp_benchmark — PASS set-timer-lat — PASS single_step_syscall_64 — PASS syscall_nt_64 — PASS sysret_rip_64 — PASS sysret_ss_attrs_64 — PASS test_bpf.sh — PASS test_execve — PASS test_mremap_vdso_64 — PASS test_static_keys.sh — PASS test_user_copy.sh — PASS test_vdso_64 — PASS test_vsyscall_64 — PASS test_xdp_meta.sh — PASS test_xdp_redirect.sh — PASS threadtest — PASS zram.sh — PASS
Dan
On Wed, Mar 28, 2018 at 10:50:35AM -0500, Dan Rue wrote:
On Wed, Mar 28, 2018 at 10:21:45AM +0200, Greg Kroah-Hartman wrote:
On Tue, Mar 27, 2018 at 08:35:01PM -0500, Dan Rue wrote:
qemu_x86_64
- boot - pass: 21
- kselftest - skip: 28, pass: 52
Do you have a list of what you are skipping anywhere? There was some x86 changes that I had to backport that I was worried about getting right here, are you running the x86 kselftests?
Yes we run the x86 selftests. Here's the full list of what ran and what was skipped. Remember (I know you know, but for anyone else observing), we run kselftest from 4.15.
That's good, as kselftest from 4.9 was a bit broken for x86, which is why I backported a bunch of patches for it for this release :)
breakpoint_test — SKIP efivarfs.sh — SKIP fsgsbase_64 — SKIP ftracetest — SKIP fw_fallback.sh — SKIP fw_filesystem.sh — SKIP gpio-mockup.sh — SKIP ldt_gdt_64 — SKIP main.sh — SKIP mem-on-off-test.sh — SKIP pstore_tests — SKIP reuseport_bpf — SKIP run.sh — SKIP run_vmtests — SKIP seccomp_bpf — SKIP sigreturn_64 — SKIP step_after_suspend_test — SKIP sync_test — SKIP sysctl.sh — SKIP test_align — SKIP test_dev_cgroup — SKIP test_kmod.sh — SKIP test_lpm_map — SKIP test_lru_map — SKIP test_maps — SKIP test_progs — SKIP test_tag — SKIP test_verifier — SKIP
Figuring out of any of these are from the tools/testing/selftests/x86/ directory is a pain, that is the tests I was referring to here...
That being said, why are you skipping so many? ldt_gdt_64 should be run, what fails with it? Same for sigreturn_64, which I think means that only 2 tests from the x86 directory are being skipped, right?
Have you gone back and looked at any of those other tests to see why they are being skipped?
thanks,
greg k-h
On Wed, Mar 28, 2018 at 06:21:04PM +0200, Greg Kroah-Hartman wrote:
On Wed, Mar 28, 2018 at 10:50:35AM -0500, Dan Rue wrote:
On Wed, Mar 28, 2018 at 10:21:45AM +0200, Greg Kroah-Hartman wrote:
On Tue, Mar 27, 2018 at 08:35:01PM -0500, Dan Rue wrote:
qemu_x86_64
- boot - pass: 21
- kselftest - skip: 28, pass: 52
Do you have a list of what you are skipping anywhere? There was some x86 changes that I had to backport that I was worried about getting right here, are you running the x86 kselftests?
Yes we run the x86 selftests. Here's the full list of what ran and what was skipped. Remember (I know you know, but for anyone else observing), we run kselftest from 4.15.
That's good, as kselftest from 4.9 was a bit broken for x86, which is why I backported a bunch of patches for it for this release :)
I've noticed these backports. Should we expect to see selftests supported in LTS kernels going forward? What is the current policy on taking selftest backports?
breakpoint_test — SKIP efivarfs.sh — SKIP fsgsbase_64 — SKIP ftracetest — SKIP fw_fallback.sh — SKIP fw_filesystem.sh — SKIP gpio-mockup.sh — SKIP ldt_gdt_64 — SKIP main.sh — SKIP mem-on-off-test.sh — SKIP pstore_tests — SKIP reuseport_bpf — SKIP run.sh — SKIP run_vmtests — SKIP seccomp_bpf — SKIP sigreturn_64 — SKIP step_after_suspend_test — SKIP sync_test — SKIP sysctl.sh — SKIP test_align — SKIP test_dev_cgroup — SKIP test_kmod.sh — SKIP test_lpm_map — SKIP test_lru_map — SKIP test_maps — SKIP test_progs — SKIP test_tag — SKIP test_verifier — SKIP
Figuring out of any of these are from the tools/testing/selftests/x86/ directory is a pain, that is the tests I was referring to here...
Agree. It would be nice if we preserved the directory name - I had the same issue when trying to answer your question.
That being said, why are you skipping so many? ldt_gdt_64 should be run, what fails with it? Same for sigreturn_64, which I think means that only 2 tests from the x86 directory are being skipped, right?
Have you gone back and looked at any of those other tests to see why they are being skipped?
I'll try to keep this short - the tl;dr is that it's historical, and something we're fixing now.
Originally, we just skipped everything that failed so that we could focus on regressions. As new things failed, we have investigated them and reported them upstream or fixed with patches. Over time, many of these original failures have been resolved but the skipfiles may not have been updated because...
Our skipfiles are per-branch and per-board, and we used to have one file for each combination, resulting in dozens of files that ended up with inconsistencies between them over time. So, we converted it to a structured data format that is then parsed at runtime to generate a skipfile for a given board/branch combination.
That work was just completed a couple weeks ago. Now that our kselftest skipfile is a single structured data file[1], we need to go through it and resolve all of the inconsistencies, remove the skips that have long since been resolved, etc. This is work we plan to do in the next couple weeks.
If you look through that file, you'll see quite a few things that are wrong. When we're done auditing it, each skip should have a coherent "reason" for skipping and an accurate branch/board list.
With regard to the specific tests you asked about: - ldt_gdt_64: As of 4.9.89 this is still failing. I'll test again with the new RC. - sigreturn_64: Passing on x86_64 (real hardware) and getting skipped on qemu x86_64. For some reason it fails intermittently on qemu in our environment.
Hope that helps, Dan
[1] https://git.linaro.org/qa/test-definitions.git/tree/automated/linux/kselftes...
On Wed, Mar 28, 2018 at 01:28:28PM -0500, Dan Rue wrote:
On Wed, Mar 28, 2018 at 06:21:04PM +0200, Greg Kroah-Hartman wrote:
On Wed, Mar 28, 2018 at 10:50:35AM -0500, Dan Rue wrote:
On Wed, Mar 28, 2018 at 10:21:45AM +0200, Greg Kroah-Hartman wrote:
On Tue, Mar 27, 2018 at 08:35:01PM -0500, Dan Rue wrote:
qemu_x86_64
- boot - pass: 21
- kselftest - skip: 28, pass: 52
Do you have a list of what you are skipping anywhere? There was some x86 changes that I had to backport that I was worried about getting right here, are you running the x86 kselftests?
Yes we run the x86 selftests. Here's the full list of what ran and what was skipped. Remember (I know you know, but for anyone else observing), we run kselftest from 4.15.
That's good, as kselftest from 4.9 was a bit broken for x86, which is why I backported a bunch of patches for it for this release :)
I've noticed these backports. Should we expect to see selftests supported in LTS kernels going forward? What is the current policy on taking selftest backports?
I applied patches that prevented the x86 patches from even being built on a modern system (i.e. my laptop). I didn't add any new functionality, I just wanted to verify that there were no regressions, which is hard to do when the tests do not build.
As for what to run, yes, use the latest possible seems like the best solution so far.
thanks,
greg k-h
On 03/27/2018 09:26 AM, Greg Kroah-Hartman wrote:
This is the start of the stable review cycle for the 4.9.91 release. There are 67 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Thu Mar 29 16:27:08 UTC 2018. Anything received after that time might be too late.
Build results: total: 145 pass: 145 fail: 0 Qemu test results: total: 137 pass: 137 fail: 0
Guenter