Re: [Sched-tools] [PATCH 09/20] add missed code snip to get deadline parameter

On 27 May 2015 at 10:52, Juri Lelli juri.lelli@arm.com wrote:

Hi,

On 05/13/2015 04:31 AM, pi-cheng.chen wrote:

...

Signed-off-by: Vincent Guittot vincent.guittot@linaro.org

src/rt-app_parse_config.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)

diff --git a/src/rt-app_parse_config.c b/src/rt-app_parse_config.c index 85aa14f..cd0ddcd 100644 --- a/src/rt-app_parse_config.c +++ b/src/rt-app_parse_config.c @@ -364,6 +364,18 @@ parse_thread_data(char *name, struct json_object *obj, int idx, data->min_et = usec_to_timespec(exec); data->max_et = usec_to_timespec(exec);

• /* deadline */
  

• dline = get_int_value_from(obj, "deadline", TRUE, period);
  

• if (dline < exec) {
  

•         log_critical(PIN2 "Deadline cannot be less than exec time");
  

•         exit(EXIT_INV_CONFIG);
  

• }
  

• if (dline > period) {
  

•         log_critical(PIN2 "Deadline cannot be greater than period");
  

•         exit(EXIT_INV_CONFIG);
  

• }
  

• data->deadline = usec_to_timespec(dline);
  

There is already this exact snippet a bit below, after "priority".

Pi-Cheng,

Can you point the original sha1 ? I can't find it in g.l.o to try to understand the duplication

Regards, Vincent

Thanks,

• Juri

...

  /* policy */
  policy_to_string(opts->policy, def_policy);
  policy = get_string_value_from(obj, "policy", TRUE, def_policy);