linaro-kernel October 2013

linaro-kernel@lists.linaro.org

87 participants
222 discussions

[PATCH RFC v1 0/5] ARM64 kernel probes(kprobes) support

by Sandeepa Prabhu

This patchset adds support for basic kernel probes(kprobes), jump probes(jprobes) and return probes(kretprobes) support for AArch64. This kprobes mechanism make use of software breakpoint and single stepping support available in ARM v8 kernel. Basic verification is done with sample test modules available as part of "samples/kprobes/" running on ARM v8 fast model (RTSM). Patch 1 (AArch64-Add-single-step-and-breakpoint-handler-hooks.patch) is v3 version of: http://permalink.gmane.org/gmane.linux.ports.arm.kernel/269733 Changes: v2 -> v3 - Renamed break_lock to break_hook_lock - Use rcu protected list traversal for step_hook - eliminated addr argument for debug hooks, now callback functions shall extract address from pt_regs instead. - refined entry.S changes only to handler 'BRK64' esr value. Patch 2 (arm64-Kernel-code-patching-support.patch) implement basic code patching support needed for kprobes. Similar api is published earlier on LKML/LAKML as part of jump label support: https://lkml.org/lkml/2013/9/25/250 However, for kprobes some changes required with that version, can rebase on new version of patch from Jiang. Sandeepa Prabhu (5): AArch64: Add single-step and breakpoint handler hooks arm64: Kernel code patching support AArch64: Instruction simulation and decode support AArch64: Add Kprobes support for ARM v8 kernel AArch64: Support kretprobe support for ARM v8 arch/arm64/Kconfig | 2 + arch/arm64/include/asm/debug-monitors.h | 23 ++ arch/arm64/include/asm/kprobes.h | 58 +++ arch/arm64/include/asm/probes.h | 48 +++ arch/arm64/include/asm/ptrace.h | 6 + arch/arm64/kernel/Makefile | 2 + arch/arm64/kernel/debug-monitors.c | 85 ++++- arch/arm64/kernel/entry.S | 2 + arch/arm64/kernel/kprobes-arm64.c | 245 ++++++++++++ arch/arm64/kernel/kprobes-arm64.h | 26 ++ arch/arm64/kernel/kprobes.c | 642 ++++++++++++++++++++++++++++++++ arch/arm64/kernel/kprobes.h | 28 ++ arch/arm64/kernel/patch.c | 58 +++ arch/arm64/kernel/patch.h | 20 + arch/arm64/kernel/probes-aarch64.c | 235 ++++++++++++ arch/arm64/kernel/probes-aarch64.h | 127 +++++++ arch/arm64/kernel/probes-common.c | 117 ++++++ arch/arm64/kernel/vmlinux.lds.S | 1 + 18 files changed, 1722 insertions(+), 3 deletions(-) create mode 100644 arch/arm64/include/asm/kprobes.h create mode 100644 arch/arm64/include/asm/probes.h create mode 100644 arch/arm64/kernel/kprobes-arm64.c create mode 100644 arch/arm64/kernel/kprobes-arm64.h create mode 100644 arch/arm64/kernel/kprobes.c create mode 100644 arch/arm64/kernel/kprobes.h create mode 100644 arch/arm64/kernel/patch.c create mode 100644 arch/arm64/kernel/patch.h create mode 100644 arch/arm64/kernel/probes-aarch64.c create mode 100644 arch/arm64/kernel/probes-aarch64.h create mode 100644 arch/arm64/kernel/probes-common.c -- 1.8.1.2

11 years, 4 months

[PATCH] LTP cacheflush01 add arm variant

by Maxim Uvarov

Cache flush on arm provided via __ARM_NR_cacheflush(unsigned long start, unsigned long end, int flags) defined in ./arch/arm/kernel/traps.c. Flags are not used, providing 0 there. Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.com> --- .../kernel/syscalls/cacheflush/cacheflush01.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/testcases/kernel/syscalls/cacheflush/cacheflush01.c b/testcases/kernel/syscalls/cacheflush/cacheflush01.c index 9c02f0a..fae51b4 100644 --- a/testcases/kernel/syscalls/cacheflush/cacheflush01.c +++ b/testcases/kernel/syscalls/cacheflush/cacheflush01.c @@ -137,6 +137,14 @@ int main(int ac, char **av) } /* Invokes cacheflush() with proper parameters */ +#if defined(__arm__) + TEST(ltp_syscall(__ARM_NR_cacheflush, addr, addr + getpagesize(), 0)); + if (TEST_RETURN == 0) { + tst_resm(TPASS, "passed with no errno"); + } else { + tst_resm(TFAIL, "failed with unexpected errno"); + } +#else TEST(ltp_syscall(__NR_cacheflush, addr, getpagesize(), ICACHE)); if (TEST_RETURN == 0) { tst_resm(TPASS, "passed with no errno"); @@ -157,6 +165,7 @@ int main(int ac, char **av) } else { tst_resm(TFAIL, "failed with unexpected errno"); } +#endif cleanup(); tst_exit(); -- 1.7.9.5

11 years, 4 months

linus/master boot: 32 pass, 1 fail (v3.12-rc4)

by Kevin Hilman build bot

Automated DT boot report for various ARM defconfigs. Boot test simply checks if kernel can boot to initramfs with busybox and run some basic commands (e.g. 'cat /proc/cpuinfo'). Tree/Branch: linus/master Git describe: v3.12-rc4 Commit: d0e639c9e0 Linux 3.12-rc4 Failed boot tests (console logs at the end) =========================================== omap4-panda: FAIL: arm-multi_v7_defconfig Full Report =========== arm-tegra_defconfig ------------------- tegra30-beaver PASS: 0 min 17.0 sec arm-omap2plus_defconfig ----------------------- am335x-boneblack PASS: 0 min 30.3 sec omap3-beagle-xm PASS: 0 min 52.5 sec am335x-bone PASS: 0 min 26.1 sec omap3-tobi,3530overo PASS: 0 min 21.3 sec omap4-panda PASS: 1 min 4.2 sec omap4-panda-es PASS: 1 min 10.4 sec omap3-tobi,3730storm PASS: 0 min 23.6 sec omap3-beagle PASS: 0 min 57.0 sec arm-imx_v6_v7_defconfig ----------------------- imx6dl-wandboard,wand-dual PASS: 0 min 16.1 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.0 sec imx6q-wandboard PASS: 0 min 14.7 sec arm-multi_v7_defconfig ---------------------- ste-snowball PASS: 0 min 30.4 sec tegra30-beaver PASS: 0 min 16.7 sec am335x-boneblack PASS: 0 min 34.4 sec omap3-beagle-xm PASS: 0 min 51.9 sec armada-370-mirabox PASS: 0 min 20.3 sec omap4-panda FAIL: 2 min 53.7 sec omap4-panda-es PASS: 1 min 8.8 sec armada-xp-openblocks-ax3-4 PASS: 0 min 22.6 sec sun4i-a10-cubieboard PASS: 0 min 11.3 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.4 sec omap3-tobi,3530overo PASS: 0 min 19.6 sec am335x-bone PASS: 0 min 33.3 sec imx6q-wandboard PASS: 0 min 15.6 sec omap3-tobi,3730storm PASS: 0 min 22.5 sec imx6dl-wandboard,wand-dual PASS: 0 min 16.6 sec omap3-beagle PASS: 1 min 9.0 sec arm-u8500_defconfig ------------------- ste-snowball PASS: 0 min 40.5 sec arm-exynos_defconfig -------------------- exynos5250-arndale PASS: 0 min 28.9 sec arm-mvebu_defconfig ------------------- armada-xp-openblocks-ax3-4 PASS: 0 min 22.1 sec armada-370-mirabox PASS: 0 min 19.9 sec arm-sama5_defconfig ------------------- sama5d35ek PASS: 0 min 18.4 sec Console logs for failures ========================= arm-multi_v7_defconfig ---------------------- omap4-panda: FAIL: last 24 lines of boot log: --------------------------------------------- [ 1.612762] omap_hsmmc 4809c000.mmc: pins are not configured from the driver [ 1.670257] pinctrl-single 4a31e040.pinmux: mux offset out of range: 0x38 (0x38) [ 1.678314] pinctrl-single 4a31e040.pinmux: could not add functions for pinmux_wl12xx_pins 56x [ 1.687561] omap-dma-engine 4a056000.dma-controller: allocating channel for 60 [ 1.687561] omap-dma-engine 4a056000.dma-controller: allocating channel for 59 [ 1.711486] usb 1-1: new high-speed USB device number 2 using ehci-omap [ 1.818298] twl_rtc rtc.11: setting system clock to 2013-10-06 23:14:10 UTC (1381101250) [ 1.867614] hub 1-1:1.0: USB hub found [ 1.871704] hub 1-1:1.0: 5 ports detected [ 1.937866] mmc0: host does not support reading read-only switch. assuming write-enable. [ 1.948516] mmc0: new high speed SD card at address aaaa [ 1.954681] mmcblk0: mmc0:aaaa SD02G 1.84 GiB [ 1.961059] mmcblk0: p1 p2 [ 2.177947] usb 1-1.1: new high-speed USB device number 3 using ehci-omap [ 15.506408] EXT4-fs (mmcblk0p2): recovery complete [ 15.519409] EXT4-fs (mmcblk0p2): mounted filesystem with ordered data mode. Opts: (null) [ 15.527954] VFS: Mounted root (ext4 filesystem) on device 179:2. [ 15.535614] devtmpfs: mounted [ 15.535614] Freeing unused kernel memory: 464K (c0629000 - c069d000) [ 15.961334] init: ureadahead main process (56) terminated with status 5 ~$off # PYBOOT: Exception: userspace: ERROR: Never found root shell # PYBOOT: Time: 173.66 seconds. # PYBOOT: Result: FAIL

11 years, 4 months

linus/master boot: 32 pass, 1 fail (v3.12-rc3-351-ge62063d)

by Kevin Hilman build bot

11 years, 4 months

linus/master boot: 32 pass, 1 fail (v3.12-rc3-341-g4ed5476)

by Kevin Hilman build bot

11 years, 4 months

[PATCH V2] tick: Make sleep length calculation more accurate

by Daniel Lezcano

The sleep_length is computed in the tick_nohz_stop_sched_tick function but it is used later in the code with in between the local irq enabled. cpu_idle_loop tick_nohz_idle_enter [ exits with local irq enabled ] __tick_nohz_idle_enter tick_nohz_stop_sched_tick ... arch_cpu_idle menu_select [ uses here 'sleep_length' ] ... Between the computation of the sleep length and its usage, some interrupts may occur, making the sleep length shorter than actually it is because of the interrupt processing, or different if the timer itself expired. This patch fixes that by moving the sleep_length computation in the tick_nohz_get_sleep_length function and using the tick device's next_event. As the sleep_length field is no longer needed, it is removed from the tick_sched structure. Signed-off-by: Daniel Lezcano <daniel.lezcano(a)linaro.org> Signed-off-by: Stephen Boyd <sboyd(a)codeaurora.org> --- include/linux/tick.h | 2 -- kernel/time/tick-sched.c | 5 +++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/include/linux/tick.h b/include/linux/tick.h index 5128d33..53dbbd7 100644 --- a/include/linux/tick.h +++ b/include/linux/tick.h @@ -48,7 +48,6 @@ enum tick_nohz_mode { * @idle_exittime: Time when the idle state was left * @idle_sleeptime: Sum of the time slept in idle with sched tick stopped * @iowait_sleeptime: Sum of the time slept in idle with sched tick stopped, with IO outstanding - * @sleep_length: Duration of the current idle sleep * @do_timer_lst: CPU was the last one doing do_timer before going idle */ struct tick_sched { @@ -67,7 +66,6 @@ struct tick_sched { ktime_t idle_exittime; ktime_t idle_sleeptime; ktime_t iowait_sleeptime; - ktime_t sleep_length; unsigned long last_jiffies; unsigned long next_jiffies; ktime_t idle_expires; diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index 3612fc7..60b1dcd 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -673,7 +673,6 @@ static ktime_t tick_nohz_stop_sched_tick(struct tick_sched *ts, out: ts->next_jiffies = next_jiffies; ts->last_jiffies = last_jiffies; - ts->sleep_length = ktime_sub(dev->next_event, now); return ret; } @@ -837,8 +836,10 @@ void tick_nohz_irq_exit(void) ktime_t tick_nohz_get_sleep_length(void) { struct tick_sched *ts = &__get_cpu_var(tick_cpu_sched); + struct clock_event_device *dev = __get_cpu_var(tick_cpu_device).evtdev; + ktime_t now = ktime_get(); - return ts->sleep_length; + return ktime_sub(dev->next_event, now); } static void tick_nohz_restart(struct tick_sched *ts, ktime_t now) -- 1.7.9.5

11 years, 4 months

linus/HEAD boot: 33 pass, 0 fail ([rerun] v3.12-rc3-313-g7dee8df)

by Kevin Hilman build bot

11 years, 4 months

linus/master boot: 29 pass, 4 fail (v3.12-rc3-313-g7dee8df)

by Kevin Hilman build bot

Automated DT boot report for various ARM defconfigs. Boot test simply checks if kernel can boot to initramfs with busybox and run some basic commands (e.g. 'cat /proc/cpuinfo'). Tree/Branch: linus/master Git describe: v3.12-rc3-313-g7dee8df Commit: 7dee8dff47 Merge tag 'pm+acpi-3.12-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm Failed boot tests (console logs at the end) =========================================== ste-snowball: FAIL: arm-multi_v7_defconfig armada-xp-openblocks-ax3-4: FAIL: arm-multi_v7_defconfig ste-snowball: FAIL: arm-u8500_defconfig armada-xp-openblocks-ax3-4: FAIL: arm-mvebu_defconfig Full Report =========== arm-tegra_defconfig ------------------- tegra30-beaver PASS: 0 min 17.3 sec arm-omap2plus_defconfig ----------------------- am335x-boneblack PASS: 0 min 29.9 sec omap3-beagle-xm PASS: 0 min 52.8 sec am335x-bone PASS: 0 min 26.3 sec omap3-tobi,3530overo PASS: 0 min 42.4 sec omap4-panda PASS: 1 min 6.0 sec omap4-panda-es PASS: 1 min 10.8 sec omap3-tobi,3730storm PASS: 0 min 41.5 sec omap3-beagle PASS: 0 min 53.3 sec arm-imx_v6_v7_defconfig ----------------------- imx6dl-wandboard,wand-dual PASS: 0 min 16.3 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.2 sec imx6q-wandboard PASS: 0 min 15.0 sec arm-multi_v7_defconfig ---------------------- ste-snowball FAIL: 0 min 38.6 sec tegra30-beaver PASS: 0 min 17.4 sec am335x-boneblack PASS: 0 min 34.6 sec omap3-beagle-xm PASS: 0 min 52.5 sec armada-370-mirabox PASS: 0 min 20.2 sec omap4-panda PASS: 1 min 1.3 sec omap4-panda-es PASS: 1 min 6.7 sec armada-xp-openblocks-ax3-4 FAIL: 0 min 0.2 sec sun4i-a10-cubieboard PASS: 0 min 11.6 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.6 sec omap3-tobi,3530overo PASS: 0 min 40.8 sec am335x-bone PASS: 0 min 33.4 sec imx6q-wandboard PASS: 0 min 15.9 sec omap3-tobi,3730storm PASS: 0 min 43.5 sec imx6dl-wandboard,wand-dual PASS: 0 min 16.9 sec omap3-beagle PASS: 0 min 48.8 sec arm-u8500_defconfig ------------------- ste-snowball FAIL: 0 min 38.6 sec arm-exynos_defconfig -------------------- exynos5250-arndale PASS: 0 min 29.2 sec arm-mvebu_defconfig ------------------- armada-xp-openblocks-ax3-4 FAIL: 0 min 0.2 sec armada-370-mirabox PASS: 0 min 20.0 sec arm-sama5_defconfig ------------------- sama5d35ek PASS: 0 min 18.9 sec Console logs for failures ========================= arm-multi_v7_defconfig ---------------------- ste-snowball: FAIL: last 24 lines of boot log: ---------------------------------------------- After ENABLE_L2CC Flush boot issw code Before call normal U-Boot 2009.11 (sept. 19 2011 - 17:03:11) CPU: ST-Ericsson db8500 v2 (Dual ARM Cortex A9) 998.400 Mhz I2C: ready DRAM: 1 GB MMC: MCDE: startup failed sec_bridge: ISSWAPI_FLUSH_BOOT_CODE: 2 EMMC: 0, MMC: 1 In: serial Out: serial Err: serial Net: smc911x-0 Hit any key to stop autoboot: 1 0 U8500 $ ~$off # PYBOOT: Exception: ERROR: Could not break into autoboot. # PYBOOT: Time: 38.64 seconds. # PYBOOT: Result: FAIL armada-xp-openblocks-ax3-4: FAIL: last 24 lines of boot log: ------------------------------------------------------------ Conmux::Registry::lookup: openblocks: error - ENOENT entry not found ~$off # PYBOOT: Exception: ERROR: Unable to connect to console. Giving up. # PYBOOT: Time: 0.17 seconds. # PYBOOT: Result: FAIL arm-u8500_defconfig ------------------- ste-snowball: FAIL: last 24 lines of boot log: ---------------------------------------------- After ENABLE_L2CC Flush boot issw code Before call normal U-Boot 2009.11 (sept. 19 2011 - 17:03:11) CPU: ST-Ericsson db8500 v2 (Dual ARM Cortex A9) 998.400 Mhz I2C: ready DRAM: 1 GB MMC: MCDE: startup failed sec_bridge: ISSWAPI_FLUSH_BOOT_CODE: 2 EMMC: 0, MMC: 1 In: serial Out: serial Err: serial Net: smc911x-0 Hit any key to stop autoboot: 1 0 U8500 $ ~$off # PYBOOT: Exception: ERROR: Could not break into autoboot. # PYBOOT: Time: 38.61 seconds. # PYBOOT: Result: FAIL arm-mvebu_defconfig ------------------- armada-xp-openblocks-ax3-4: FAIL: last 24 lines of boot log: ------------------------------------------------------------ Conmux::Registry::lookup: openblocks: error - ENOENT entry not found ~$off # PYBOOT: Exception: ERROR: Unable to connect to console. Giving up. # PYBOOT: Time: 0.18 seconds. # PYBOOT: Result: FAIL

11 years, 4 months

linus/master boot: 27 pass, 6 fail (v3.12-rc3-304-g3dbecf0)

by Kevin Hilman build bot

Automated DT boot report for various ARM defconfigs. Boot test simply checks if kernel can boot to initramfs with busybox and run some basic commands (e.g. 'cat /proc/cpuinfo'). Tree/Branch: linus/master Git describe: v3.12-rc3-304-g3dbecf0 Commit: 3dbecf0aa9 Merge tag 'xfs-for-linus-v3.12-rc4' of git://oss.sgi.com/xfs/xfs Failed boot tests (console logs at the end) =========================================== ste-snowball: FAIL: arm-multi_v7_defconfig armada-xp-openblocks-ax3-4: FAIL: arm-multi_v7_defconfig sun4i-a10-cubieboard: FAIL: arm-multi_v7_defconfig ste-snowball: FAIL: arm-u8500_defconfig exynos5250-arndale: FAIL: arm-exynos_defconfig armada-xp-openblocks-ax3-4: FAIL: arm-mvebu_defconfig Full Report =========== arm-tegra_defconfig ------------------- tegra30-beaver PASS: 0 min 17.2 sec arm-omap2plus_defconfig ----------------------- am335x-boneblack PASS: 0 min 29.8 sec omap3-beagle-xm PASS: 0 min 51.8 sec am335x-bone PASS: 0 min 26.4 sec omap3-tobi,3530overo PASS: 0 min 42.3 sec omap4-panda PASS: 1 min 2.6 sec omap4-panda-es PASS: 1 min 22.5 sec omap3-tobi,3730storm PASS: 0 min 44.4 sec omap3-beagle PASS: 0 min 50.9 sec arm-imx_v6_v7_defconfig ----------------------- imx6dl-wandboard,wand-dual PASS: 0 min 16.4 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.3 sec imx6q-wandboard PASS: 0 min 14.9 sec arm-multi_v7_defconfig ---------------------- ste-snowball FAIL: 0 min 38.6 sec tegra30-beaver PASS: 0 min 20.9 sec am335x-boneblack PASS: 0 min 34.6 sec omap3-beagle-xm PASS: 0 min 51.2 sec armada-370-mirabox PASS: 0 min 20.2 sec omap4-panda PASS: 0 min 58.6 sec omap4-panda-es PASS: 1 min 3.7 sec armada-xp-openblocks-ax3-4 FAIL: 0 min 0.2 sec sun4i-a10-cubieboard FAIL: 0 min 6.8 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.6 sec omap3-tobi,3530overo PASS: 0 min 43.9 sec am335x-bone PASS: 0 min 33.4 sec imx6q-wandboard PASS: 0 min 15.8 sec omap3-tobi,3730storm PASS: 0 min 43.7 sec imx6dl-wandboard,wand-dual PASS: 0 min 16.7 sec omap3-beagle PASS: 0 min 49.1 sec arm-u8500_defconfig ------------------- ste-snowball FAIL: 0 min 38.7 sec arm-exynos_defconfig -------------------- exynos5250-arndale FAIL: 0 min 31.4 sec arm-mvebu_defconfig ------------------- armada-xp-openblocks-ax3-4 FAIL: 0 min 0.2 sec armada-370-mirabox PASS: 0 min 20.0 sec arm-sama5_defconfig ------------------- sama5d35ek PASS: 0 min 18.5 sec Console logs for failures ========================= arm-multi_v7_defconfig ---------------------- ste-snowball: FAIL: last 24 lines of boot log: ---------------------------------------------- After ENABLE_L2CC Flush boot issw code Before call normal U-Boot 2009.11 (sept. 19 2011 - 17:03:11) CPU: ST-Ericsson db8500 v2 (Dual ARM Cortex A9) 998.400 Mhz I2C: ready DRAM: 1 GB MMC: MCDE: startup failed sec_bridge: ISSWAPI_FLUSH_BOOT_CODE: 2 EMMC: 0, MMC: 1 In: serial Out: serial Err: serial Net: smc911x-0 Hit any key to stop autoboot: 1 0 U8500 $ ~$off # PYBOOT: Exception: ERROR: Could not break into autoboot. # PYBOOT: Time: 38.64 seconds. # PYBOOT: Result: FAIL armada-xp-openblocks-ax3-4: FAIL: last 24 lines of boot log: ------------------------------------------------------------ Conmux::Registry::lookup: openblocks: error - ENOENT entry not found ~$off # PYBOOT: Exception: ERROR: Unable to connect to console. Giving up. # PYBOOT: Time: 0.17 seconds. # PYBOOT: Result: FAIL sun4i-a10-cubieboard: FAIL: last 24 lines of boot log: ------------------------------------------------------ version U-Boot 2011.09-rc1 (Nov 26 2012 - 14:01:52) Allwinner Technology arm-none-linux-gnueabi-gcc (Sourcery G++ Lite 2010.09-50) 4.5.1 GNU ld (Sourcery G++ Lite 2010.09-50) 2.20.51.20100809 sunxi#setenv ethaddr 2e:40:70:f0:12:08 setenv ethaddr 2e:40:70:f0:12:08 sunxi#setenv console ttyS0,115200 earlyprintk rw root=/dev/mmcblk0p2 rootwait rootfstype=ext4 setenv console ttyS0,115200 earlyprintk rw root=/dev/mmcblk0p2 rootwait rootfstype=ext4 sunxi#setenv initrd_high 0xffffffff setenv initrd_high 0xffffffff sunxi#if test -n ${initenv}; then run initenv; fi if test -n ${initenv}; then run initenv; fi sunxi#if test -n ${preboot}; then run preboot; fi if test -n ${preboot}; then run preboot; fi sunxi#setenv autoload no; setenv autoboot no setenv autoload no; setenv autoboot no sunxi#dhcp dhcp Unknown command 'dhcp' - try 'help' sunxi#~$off # PYBOOT: Exception: u-boot: does not support DHCP. Giving up. # PYBOOT: Time: 6.81 seconds. # PYBOOT: Result: FAIL arm-u8500_defconfig ------------------- ste-snowball: FAIL: last 24 lines of boot log: ---------------------------------------------- After ENABLE_L2CC Flush boot issw code Before call normal U-Boot 2009.11 (sept. 19 2011 - 17:03:11) CPU: ST-Ericsson db8500 v2 (Dual ARM Cortex A9) 998.400 Mhz I2C: ready DRAM: 1 GB MMC: MCDE: startup failed sec_bridge: ISSWAPI_FLUSH_BOOT_CODE: 2 EMMC: 0, MMC: 1 In: serial Out: serial Err: serial Net: smc911x-0 Hit any key to stop autoboot: 1 0 U8500 $ ~$off # PYBOOT: Exception: ERROR: Could not break into autoboot. # PYBOOT: Time: 38.67 seconds. # PYBOOT: Result: FAIL arm-exynos_defconfig -------------------- exynos5250-arndale: FAIL: last 24 lines of boot log: ---------------------------------------------------- Connected to arndale console [channel connected] (~$quit to exit) (user:khilman) is already connected ~$hardreset Command(arndale console)> hardreset (user:jenkins) Reboot arndale Reboot: arndale ; phidget 2 0 : off, sleep, on ~$off # PYBOOT: Exception: ERROR: Could not break into autoboot. # PYBOOT: Time: 31.45 seconds. # PYBOOT: Result: FAIL arm-mvebu_defconfig ------------------- armada-xp-openblocks-ax3-4: FAIL: last 24 lines of boot log: ------------------------------------------------------------ Conmux::Registry::lookup: openblocks: error - ENOENT entry not found ~$off # PYBOOT: Exception: ERROR: Unable to connect to console. Giving up. # PYBOOT: Time: 0.19 seconds. # PYBOOT: Result: FAIL

11 years, 4 months

[RFC PATCH v2] ARM: OMAP4/highbank: Flush L2 cache before disabling

by Taras Kondratiuk

Kexec disables outer cache before jumping to reboot code, but it doesn't flush it explicitly. Flush is done implicitly inside of l2x0_disable(). But some SoC's override default .disable handler and don't flush cache. This may lead to a corrupted memory during Kexec reboot on these platforms. This patch adds cache flush inside of OMAP4 and Highbank outer_cache.disable() handlers to make it consistent with default l2x0_disable(). Also it removes redundant outer_flush_all() call just before outer_disable(). Signed-off-by: Taras Kondratiuk <taras.kondratiuk(a)linaro.org> --- v2: Make the fix specific to platforms that don't use l2x0_disable(). v1: https://patchwork.kernel.org/patch/2974431/ --- Cc: Will Deacon <will.deacon(a)arm.com> Cc: Russell King <linux(a)arm.linux.org.uk> Cc: Rob Herring <rob.herring(a)calxeda.com> Cc: linaro-kernel(a)lists.linaro.org Cc: linux-arm-kernel(a)lists.infradead.org Cc: linux-omap(a)vger.kernel.org --- arch/arm/mach-highbank/highbank.c | 1 + arch/arm/mach-highbank/pm.c | 1 - arch/arm/mach-omap2/omap4-common.c | 1 + 3 files changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-highbank/highbank.c b/arch/arm/mach-highbank/highbank.c index 8e63ccd..22e6f34 100644 --- a/arch/arm/mach-highbank/highbank.c +++ b/arch/arm/mach-highbank/highbank.c @@ -63,6 +63,7 @@ void highbank_set_cpu_jump(int cpu, void *jump_addr) static void highbank_l2x0_disable(void) { + outer_flush_all(); /* Disable PL310 L2 Cache controller */ highbank_smc1(0x102, 0x0); } diff --git a/arch/arm/mach-highbank/pm.c b/arch/arm/mach-highbank/pm.c index 04eddb4..9a5b8a7 100644 --- a/arch/arm/mach-highbank/pm.c +++ b/arch/arm/mach-highbank/pm.c @@ -28,7 +28,6 @@ static int highbank_suspend_finish(unsigned long val) { - outer_flush_all(); outer_disable(); highbank_set_pwr_suspend(); diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c index 5791143..3f44b16 100644 --- a/arch/arm/mach-omap2/omap4-common.c +++ b/arch/arm/mach-omap2/omap4-common.c @@ -163,6 +163,7 @@ void __iomem *omap4_get_l2cache_base(void) static void omap4_l2x0_disable(void) { + outer_flush_all(); /* Disable PL310 L2 Cache controller */ omap_smc1(0x102, 0x0); } -- 1.7.9.5

11 years, 4 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

linaro-kernel October 2013