Linaro-uefi February 2017

linaro-uefi@lists.linaro.org

20 participants
19 discussions

Re: [Linaro-uefi] Problem with building AML file from Dsdt.asl for Juno

by Leif Lindholm

Oh dear... Adding linaro-toolchain(a)lists.linaro.org to see what they have to say (and linaro-uefi, because it's useful information for subscribers of that). Regards, Leif On Tue, Feb 21, 2017 at 08:09:53PM +0000, Evan Lloyd wrote: > To add to Alexei's comments: > It seems there is a bug in the newer GCC Pre-processor that messes with the file case. > (He is currently checking what file system flags might be affecting that, but older versions work fine). > > The questions I'd add are: > Is there someone in Linaro who we might discuss the problem with (on the GCC side)? I think there are Linaro guys involved with it, and they may be able to tell us it is confusion on our part. > Should we be trying to upstream the fix, or just wait for a new GCC? > > Regards, > Evan > > > > From: Alexei Fedorov > Sent: 21 February 2017 16:37 > To: ard.biesheuvel(a)linaro.org; ryan.harkin(a)linaro.org; leif.lindholm(a)linaro.org; Evan Lloyd; Sami Mujawar; Girish Pathak > Cc: Mitch Ishihara; Alexei Fedorov > Subject: Problem with building AML file from Dsdt.asl for Juno > > > Hello, > > > > We are facing a problem when compiling Juno's Dsdt.asl file with the following GCC builds: > > > > gcc-linaro-5.3.1-2016.05-i686-mingw32_aarch64-elf > > gcc-linaro-6.1.1-2016.08-i686-mingw32_aarch64-elf > > gcc-linaro-6.2.1-2016.11-i686-mingw32_aarch64-elf > > gcc-linaro-6.3.1-2017.02-i686-mingw32_aarch64-elf > > > > which all show a similar error: > > > > ... > Trim --source-code -l -o k:\Build\ArmJuno\DEBUG_GCC5\AARCH64\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\OUTPUT\.\Dsdt.iiii k:\Build\ArmJuno\DEBUG_GCC5\AARCH64\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\OUTPUT\.\Dsdt.iii > "C:\ASL\iasl" -pk:\Build\ArmJuno\DEBUG_GCC5\AARCH64\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\OUTPUT\.\Dsdt.aml k:\Build\ArmJuno\DEBUG_GCC5\AARCH64\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\OUTPUT\.\Dsdt.iiii > Error 6126 - Input file does not appear to be an ASL or data table source file > Intel ACPI Component Architecture > make: *** [Makefile:325: k:\Build\ArmJuno\DEBUG_GCC5\AARCH64\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\OUTPUT\Dsdt.aml] Error -1 > > > > It looks like the problem is with GCC pre-processor running on Dsdt.i file (created after > > Trim --asl-file -o k:\Build\ArmJuno\DEBUG_GCC5\AARCH64\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\OUTPUT\.\Dsdt.i -i k:\Build\ArmJuno\DEBUG_GCC5\AARCH64\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\OUTPUT\inc.lst k:\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\Dsdt.asl > > ) > > > > See: > > > "C:\gcc-linaro-6.3.1-2017.02-i686-mingw32_aarch64-elf\bin\aarch64-elf-gcc" -x c -E -include AutoGen.h -Ik:\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables -Ik:\Build\ArmJuno\DEBUG_GCC5\AARCH64\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\DEBUG -Ik:\ArmPkg -Ik:\ArmPkg\Include -Ik:\ArmPlatformPkg -Ik:\ArmPlatformPkg\Include -Ik:\ArmPlatformPkg\ArmVExpressPkg -Ik:\ArmPlatformPkg\ArmVExpressPkg\Include -Ik:\ArmPlatformPkg\ArmJunoPkg -Ik:\ArmPlatformPkg\ArmJunoPkg\Include -Ik:\EmbeddedPkg -Ik:\EmbeddedPkg\Include -Ik:\MdePkg -Ik:\MdePkg\Include -Ik:\MdePkg\Include\AArch64 -Ik:\MdeModulePkg -Ik:\MdeModulePkg\Include -Ik:\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTablesk:\Build\ArmJuno\DEBUG_GCC5AARCH64OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\OUTPUT\.\Dsdt.i > k:\Build\ArmJuno\DEBUG_GCC5\AARCH64\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\OUTPUT\.\Dsdt.iii > > > > For all GCC versions above, the 1st line of Dsdt.iii lists its name & full path in lowercase: > > # 1 "k:\\build\\armjuno\\debug_gcc5\\aarch64\\openplatformpkg\\platforms\\arm\\juno\\acpitables\\acpitables\\output\\dsdt.i" > > > > Compare it with Dsdt.iii after pre-processing by GCC from gcc-linaro-4.9.4-2017.01-i686-mingw32_aarch64-elf release: > > # 1 "k:\\Build\\ArmJuno\\DEBUG_GCC49\\AARCH64\\OpenPlatformPkg\\Platforms\\ARM\\Juno\\AcpiTables\\AcpiTables\\OUTPUT\\.\\Dsdt.i" > > > > For GCC 5.3.1 & above Dsdt.iiii created by > > Trim --source-code -l -o k:\Build\ArmJuno\DEBUG_GCC5\AARCH64\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\OUTPUT\.\Dsdt.iiii k:\Build\ArmJuno\DEBUG_GCC5\AARCH64\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\AcpiTables\OUTPUT\.\Dsdt.iii > > > > has 0 length, which causes iASL compiler to fail with: > > Error 6126 - Input file does not appear to be an ASL or data table source file > > > > We've got a workaround solution for that problem which involves modification of \BaseTools\Conf\build_rule.template: > > > > In ASL section: > [Acpi-Source-Language-File] > <InputFile> > ?.asl, ?.Asl, ?.ASL > > > > by replacing 3 lines as below: > > > <Command.GCC, Command.GCCLD> > # Trim --asl-file -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.i -i $(INC_LIST) ${src} > # "$(ASLPP)" $(ASLPP_FLAGS) $(INC) -I${s_path} $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.i > $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.iii > # Trim --source-code -l -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.iiii $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.iii > "$(ASLPP)" $(ASLPP_FLAGS) $(INC) -I${s_path} ${src} > $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.i > Trim --source-code -l -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.iiii $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.I > > > > Please share your opinion on that matter. > > > > Alexei. > > > > > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

8 years, 4 months

[PATCH v2 0/7] ATAPI support on SiI SATA adapter

by Jeremy Linton

The SiI isn't an AHCI compatible adapter so it implements the EFI ATA pass-through protocol directly. This works for fixed hard drives, but not ATAPI attached devices (CDROM, DVDROM, TAPE, etc). This patch adds read only ATAPI support via the EFI SCSI pass-through protocol, allowing boot from attached CD/DVD. This patch also cleans up, and tweaks recovery paths/etc in the original driver. When combined with the ARM/PCI dma lib changes this allows us to relax the IO alignment requirement that caused grub failures. Finally, the OpenPlatformPkg/Juno must be updated, with another patch to avoid build breaks now that the SiI has a dependency on the SCSI libraries. V1->V2: Formatting corrections per Ard's comments and Daniil's updated patch checker. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeremy Linton <jeremy.linton(a)arm.com> Jeremy Linton (7): EmbeddedPkg: SiI3132: Note that ARM is using this Dxe MdePkg IndustryStandard/Scsi.h: Add sense code macro EmbeddedPkg: SiI3132: Add ScsiProtocol callbacks EmbeddedPkg: SiI3132: Add SCSI protocol support to header EmbeddedPkg: SiI3132: Break out FIS command submission EmbeddedPkg: SiI3132: Cleanup device node creation EmbeddedPkg: SiI3132: Enable SCSI pass-through protocol EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c | 49 ++- EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h | 93 ++++- .../Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf | 2 + .../Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c | 268 ++++++++----- .../Drivers/SataSiI3132Dxe/SiI3132ScsiPassThru.c | 431 +++++++++++++++++++++ MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf | 2 +- MdePkg/Include/IndustryStandard/Scsi.h | 2 + OpenPlatformPkg | 2 +- 8 files changed, 721 insertions(+), 128 deletions(-) create mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132ScsiPassThru.c -- 2.9.3

8 years, 4 months

Stack Alignment is not enabled in ARM EDK2

by Heyi Guo

Hi folks, It seems there is no code to enable stack alignment check in EDK2, while it is required to be enabled according to UEFI spec v2.6, section 2.3.6, page 38. Shall we find somewhere to enable SA? Thanks and regards, Gary (Heyi Guo)

8 years, 4 months

[PATCH] arm: remove set/way cache maintenance

by Ard Biesheuvel

This removes the set/way cache maintenance for the ARM boot path, which is an inappropriate thing to do for GRUB [0]. To avoid the need for cache maintenance on the stack, refactor the boot path so that we no longer touch the stack after the MMU and caches have been disabled. Also, clean the FDT, ATAG array and/or the initrd to the PoC explicitly, so that we can remove the set/way maintenance altogether. (The kernel image itself is already cleaned to the PoC) Note that this requires grub_arm_clean_dcache_range_armv7() to be modified so that it cleans to the PoC rather than to the PoU, which makes it identical to the v6 version. [0] Set/way ops manage the state of the caches of a single core, which is typically done when it is powered up or down. Ensuring that certain memory stores have made it all the way to main memory is a completely different thing, and cannot be achieved on an ARM SMP system with set/way ops. Signed-off-by: Ard Biesheuvel <ard.biesheuvel(a)linaro.org> --- Sending internally, to linaro-uefi@ and selected cc'ees. Gerd has confirmed that this patch solves his issue, but I have no clue whether the coding style or other GRUB-isms are done correctly here. grub-core/kern/arm/cache.S | 72 +++++++-------- grub-core/kern/arm/cache.c | 18 ++-- grub-core/kern/arm/cache_armv7.S | 92 +------------------- grub-core/loader/arm/linux.c | 24 ++--- include/grub/arm/system.h | 5 +- 5 files changed, 58 insertions(+), 153 deletions(-) diff --git a/grub-core/kern/arm/cache.S b/grub-core/kern/arm/cache.S index 354a069fe67a..8960a8944c6f 100644 --- a/grub-core/kern/arm/cache.S +++ b/grub-core/kern/arm/cache.S @@ -49,11 +49,7 @@ FUNCTION(grub_arm_clean_dcache_range_armv7) @ Clean data cache for range to point-of-unification 1: cmp r0, r1 bge 2f -#ifdef ARMV6 mcr p15, 0, r0, c7, c10, 1 @ Clean data cache line by MVA -#else - mcr p15, 0, r0, c7, c11, 1 @ DCCMVAU -#endif add r0, r0, r2 @ Next line b 1b 2: DSB @@ -79,45 +75,39 @@ FUNCTION(grub_arm_invalidate_icache_range_armv7) bx lr #ifdef ARMV6 -FUNCTION(grub_arm_disable_caches_mmu_armv6) +FUNCTION(grub_arm_disable_dcache_mmu_and_boot_armv6) #else -FUNCTION(grub_arm_disable_caches_mmu_armv7) +FUNCTION(grub_arm_disable_dcache_mmu_and_boot_armv7) +#endif + @ preserve arguments - beyond point of no return, so no stacking needed + mov r4, r0 + mov r5, r1 + mov r6, r2 + + @ ensure that the instructions below can be fetched with the Dcache off + adr r0, 0f + adr r1, 1f + mov r2, #4 @ architecturally minimal Dlinesize +#ifdef ARMV6 + bl grub_arm_clean_dcache_range_armv6 +#else + bl grub_arm_clean_dcache_range_armv7 #endif - push {r4, lr} - - @ disable D-cache - mrc p15, 0, r0, c1, c0, 0 - bic r0, r0, #(1 << 2) - mcr p15, 0, r0, c1, c0, 0 - DSB - ISB - - @ clean/invalidate D-cache - bl clean_invalidate_dcache - - @ disable I-cache - mrc p15, 0, r0, c1, c0, 0 - bic r0, r0, #(1 << 12) - mcr p15, 0, r0, c1, c0, 0 - DSB - ISB - - @ invalidate I-cache (also invalidates branch predictors) - mcr p15, 0, r0, c7, c5, 0 - DSB - ISB - - @ clear SCTLR M bit + @ disable D-cache and MMU - I-cache can remain enabled mrc p15, 0, r0, c1, c0, 0 - bic r0, r0, #(1 << 0) + bic r0, r0, #(1 << 2) | (1 << 0) mcr p15, 0, r0, c1, c0, 0 - - mcr p15, 0, r0, c8, c7, 0 @ invalidate TLB - mcr p15, 0, r0, c7, c5, 6 @ invalidate branch predictor - DSB - ISB - - pop {r4, lr} - bx lr - +0: ISB + + /* Boot the kernel. + * Arguments to kernel: + * r0 - 0 + * r1 - machine type + * r2 - address of DTB + */ + mov r0, #0 + mov r1, r5 + mov r2, r6 + bx r4 +1: diff --git a/grub-core/kern/arm/cache.c b/grub-core/kern/arm/cache.c index 34154ccdb0e0..eec17b00f3d1 100644 --- a/grub-core/kern/arm/cache.c +++ b/grub-core/kern/arm/cache.c @@ -33,8 +33,12 @@ void grub_arm_invalidate_icache_range_armv6 (grub_addr_t start, grub_addr_t end, grub_addr_t dlinesz); void grub_arm_invalidate_icache_range_armv7 (grub_addr_t start, grub_addr_t end, grub_addr_t dlinesz); -void grub_arm_disable_caches_mmu_armv6 (void); -void grub_arm_disable_caches_mmu_armv7 (void); +void grub_arm_disable_dcache_mmu_and_boot_armv6 (grub_addr_t linux_addr, + grub_uint32_t machine_type, + void *fdt_addr); +void grub_arm_disable_dcache_mmu_and_boot_armv7 (grub_addr_t linux_addr, + grub_uint32_t machine_type, + void *fdt_addr); grub_uint32_t grub_arm_main_id (void); grub_uint32_t grub_arm_cache_type (void); @@ -253,7 +257,9 @@ grub_arch_sync_caches (void *address, grub_size_t len) } void -grub_arm_disable_caches_mmu (void) +grub_arm_disable_dcache_mmu_and_boot (grub_addr_t linux_addr, + grub_uint32_t machine_type, + void *fdt_addr) { if (type == ARCH_UNKNOWN) probe_caches (); @@ -262,10 +268,12 @@ grub_arm_disable_caches_mmu (void) case ARCH_ARMV5_WRITE_THROUGH: case ARCH_ARMV6_UNIFIED: case ARCH_ARMV6: - grub_arm_disable_caches_mmu_armv6 (); + grub_arm_disable_dcache_mmu_and_boot_armv6 (linux_addr, machine_type, + fdt_addr); break; case ARCH_ARMV7: - grub_arm_disable_caches_mmu_armv7 (); + grub_arm_disable_dcache_mmu_and_boot_armv7 (linux_addr, machine_type, + fdt_addr); break; /* Pacify GCC. */ case ARCH_UNKNOWN: diff --git a/grub-core/kern/arm/cache_armv7.S b/grub-core/kern/arm/cache_armv7.S index 1ef2754af8a7..1d6597956ac8 100644 --- a/grub-core/kern/arm/cache_armv7.S +++ b/grub-core/kern/arm/cache_armv7.S @@ -33,94 +33,4 @@ # define ISB isb #define ARMV7 1 - @ r0 - CLIDR - @ r1 - LoC - @ r2 - current level - @ r3 - num sets - @ r4 - num ways - @ r5 - current set - @ r6 - current way - @ r7 - line size - @ r8 - scratch - @ r9 - scratch - @ r10 - scratch - @ r11 - scratch -clean_invalidate_dcache: - push {r4-r12, lr} - mrc p15, 1, r0, c0, c0, 1 @ Read CLIDR - lsr r1, r0, #24 @ Extract LoC - and r1, r1, #0x7 - - mov r2, #0 @ First level, L1 -2: and r8, r0, #7 @ cache type at current level - cmp r8, #2 - blt 5f @ instruction only, or none, skip level - - @ set current cache level/type (for CCSIDR read) - lsl r8, r2, #1 - mcr p15, 2, r8, c0, c0, 0 @ Write CSSELR (level, type: data/uni) - - @ read current cache information - mrc p15, 1, r8, c0, c0, 0 @ Read CCSIDR - lsr r3, r8, #13 @ Number of sets -1 - - @ Keep only 14 bits of r3 - lsl r3, r3, #18 - lsr r3, r3, #18 - - lsr r4, r8, #3 @ Number of ways -1 - - @ Keep only 9 bits of r4 - lsl r4, r4, #23 - lsr r4, r4, #23 - - and r7, r8, #7 @ log2(line size in words) - 2 - add r7, r7, #2 @ adjust - mov r8, #1 - lsl r7, r8, r7 @ -> line size in words - lsl r7, r7, #2 @ -> bytes - - @ set loop - mov r5, #0 @ current set = 0 -3: lsl r8, r2, #1 @ insert level - clz r9, r7 @ calculate set field offset - mov r10, #31 - sub r9, r10, r9 - lsl r10, r5, r9 - orr r8, r8, r10 @ insert set field - - @ way loop - @ calculate way field offset - mov r6, #0 @ current way = 0 - add r10, r4, #1 - clz r9, r10 @ r9 = way field offset - add r9, r9, #1 -4: lsl r10, r6, r9 - orr r11, r8, r10 @ insert way field - - @ clean and invalidate line by set/way - mcr p15, 0, r11, c7, c14, 2 @ DCCISW - - @ next way - add r6, r6, #1 - cmp r6, r4 - ble 4b - - @ next set - add r5, r5, #1 - cmp r5, r3 - ble 3b - - @ next level -5: lsr r0, r0, #3 @ align next level CLIDR 'type' field - add r2, r2, #1 @ increment cache level counter - cmp r2, r1 - blt 2b @ outer loop - - @ return -6: DSB - ISB - pop {r4-r12, lr} - bx lr - -#include "cache.S" \ No newline at end of file +#include "cache.S" diff --git a/grub-core/loader/arm/linux.c b/grub-core/loader/arm/linux.c index 5b39f02bb2e5..5e3914b7d9d2 100644 --- a/grub-core/loader/arm/linux.c +++ b/grub-core/loader/arm/linux.c @@ -44,8 +44,6 @@ static char *linux_args; static grub_uint32_t machine_type; static void *fdt_addr; -typedef void (*kernel_entry_t) (int, unsigned long, void *); - #define LINUX_ZIMAGE_OFFSET 0x24 #define LINUX_ZIMAGE_MAGIC 0x016f2818 @@ -142,9 +140,12 @@ linux_prepare_atag (void) to += 2; /* Copy updated FDT to its launch location */ - grub_memcpy (atag_orig, tmp_atag, sizeof (grub_uint32_t) * (to - tmp_atag)); + tmp_size = sizeof (grub_uint32_t) * (to - tmp_atag); + grub_memcpy (atag_orig, tmp_atag, tmp_size); grub_free (tmp_atag); + grub_arch_sync_caches (atag_orig, tmp_size); + grub_dprintf ("loader", "ATAG updated for Linux boot\n"); return GRUB_ERR_NONE; @@ -212,6 +213,8 @@ linux_prepare_fdt (void) grub_memcpy (fdt_addr, tmp_fdt, tmp_size); grub_free (tmp_fdt); + grub_arch_sync_caches (fdt_addr, tmp_size); + grub_dprintf ("loader", "FDT updated for Linux boot\n"); return GRUB_ERR_NONE; @@ -224,7 +227,6 @@ failure: static grub_err_t linux_boot (void) { - kernel_entry_t linuxmain; int fdt_valid, atag_valid; fdt_valid = (fdt_addr && grub_fdt_check_header_nosize (fdt_addr) == 0); @@ -266,14 +268,6 @@ linux_boot (void) grub_dprintf ("loader", "Jumping to Linux...\n"); - /* Boot the kernel. - * Arguments to kernel: - * r0 - 0 - * r1 - machine type - * r2 - address of DTB - */ - linuxmain = (kernel_entry_t) linux_addr; - #ifdef GRUB_MACHINE_EFI { grub_err_t err; @@ -283,9 +277,7 @@ linux_boot (void) } #endif - grub_arm_disable_caches_mmu (); - - linuxmain (0, machine_type, fdt_addr); + grub_arm_disable_dcache_mmu_and_boot (linux_addr, machine_type, fdt_addr); return grub_error (GRUB_ERR_BAD_OS, "Linux call returned"); } @@ -431,6 +423,8 @@ grub_cmd_initrd (grub_command_t cmd __attribute__ ((unused)), if (grub_initrd_load (&initrd_ctx, argv, (void *) initrd_start)) goto fail; + grub_arch_sync_caches ((void *) initrd_start, size); + initrd_end = initrd_start + size; return GRUB_ERR_NONE; diff --git a/include/grub/arm/system.h b/include/grub/arm/system.h index f62c18c13a87..5afce696a719 100644 --- a/include/grub/arm/system.h +++ b/include/grub/arm/system.h @@ -9,7 +9,10 @@ enum GRUB_ARM_MACHINE_TYPE_FDT = 0xFFFFFFFF }; -void EXPORT_FUNC(grub_arm_disable_caches_mmu) (void); +void +EXPORT_FUNC(grub_arm_disable_dcache_mmu_and_boot) (grub_addr_t linux_addr, + grub_uint32_t machine_type, + void *fdt_addr); void grub_arm_enable_caches_mmu (void); void grub_arm_enable_mmu (grub_uint32_t *mmu_tables); void grub_arm_clear_mmu_v6 (void); -- 2.7.4

8 years, 4 months

[PATCH v3 0/5] add drivers for Android Fastboot App on HiKey

by Haojian Zhuang

v3: * Squash HiKeyVariable head file into Fastboot driver patch. * Fix with the comments. * Remove platform boot manager. Since Ard is working on figure out a common platform boot manager. * Remove the patch of enabling platform boot manager and android fastboot app for #3. v2: * Fix the register offset sequence in Hi6220 head file. * Remove the unnecessary dependency. Set them in DSC & FDF file instead. v1: * Enable Android Fastboot App on HiKey platform. Haojian Zhuang (5): Platforms/Hisilicon/HiKey: append more register definitions Drivers/Usb/DwUsb: support designware usb Platforms/Hisilicon/HiKey: support all GPIO controller Platforms/Hisilicon/HiKey: support designware USB controller Platforms/Hisilicon/HiKey: add fastboot driver Chips/Hisilicon/Hi6220/Include/Hi6220.h | 51 ++ Drivers/Usb/DwUsbDxe/DwUsbDxe.c | 796 +++++++++++++++++++++ Drivers/Usb/DwUsbDxe/DwUsbDxe.dec | 46 ++ Drivers/Usb/DwUsbDxe/DwUsbDxe.h | 627 ++++++++++++++++ Drivers/Usb/DwUsbDxe/DwUsbDxe.inf | 52 ++ Include/Protocol/DwUsb.h | 81 +++ Platforms/Hisilicon/HiKey/HiKey.dec | 1 + .../HiKey/HiKeyFastbootDxe/HiKeyFastbootDxe.c | 667 +++++++++++++++++ .../HiKey/HiKeyFastbootDxe/HiKeyFastbootDxe.inf | 61 ++ .../Hisilicon/HiKey/HiKeyGpioDxe/HiKeyGpioDxe.c | 96 +++ .../Hisilicon/HiKey/HiKeyGpioDxe/HiKeyGpioDxe.inf | 38 + .../Hisilicon/HiKey/HiKeyUsbDxe/HiKeyUsbDxe.c | 271 +++++++ .../Hisilicon/HiKey/HiKeyUsbDxe/HiKeyUsbDxe.inf | 46 ++ .../Hisilicon/HiKey/Include/Guid/HiKeyVariable.h | 24 + 14 files changed, 2857 insertions(+) create mode 100644 Drivers/Usb/DwUsbDxe/DwUsbDxe.c create mode 100644 Drivers/Usb/DwUsbDxe/DwUsbDxe.dec create mode 100644 Drivers/Usb/DwUsbDxe/DwUsbDxe.h create mode 100644 Drivers/Usb/DwUsbDxe/DwUsbDxe.inf create mode 100644 Include/Protocol/DwUsb.h create mode 100644 Platforms/Hisilicon/HiKey/HiKeyFastbootDxe/HiKeyFastbootDxe.c create mode 100644 Platforms/Hisilicon/HiKey/HiKeyFastbootDxe/HiKeyFastbootDxe.inf create mode 100644 Platforms/Hisilicon/HiKey/HiKeyGpioDxe/HiKeyGpioDxe.c create mode 100644 Platforms/Hisilicon/HiKey/HiKeyGpioDxe/HiKeyGpioDxe.inf create mode 100644 Platforms/Hisilicon/HiKey/HiKeyUsbDxe/HiKeyUsbDxe.c create mode 100644 Platforms/Hisilicon/HiKey/HiKeyUsbDxe/HiKeyUsbDxe.inf create mode 100644 Platforms/Hisilicon/HiKey/Include/Guid/HiKeyVariable.h -- 2.7.4

8 years, 4 months

[Linaro-uefi v1] Hisilicon/D02: update FVMAIN_SEC.fv

by Heyi Guo

We need to rebuild FVMAIN_SEC.fv after enlarging FVMAIN_COMPACT, because the fv size and trustfirmware located base address changed. Signed-off-by: Chenhui Sun <sunchenhui(a)huawei.com> --- Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv | Bin 262144 -> 262144 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv b/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv index bac8767..49b61aa 100644 Binary files a/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv and b/Platforms/Hisilicon/Binary/D02/Sec/FVMAIN_SEC.Fv differ -- 1.9.1

8 years, 4 months

[PATCH v2] EFI: fix build for AARCH64

by Leif Lindholm

AARCH64 build was left out of initial version, so add to .dsc and set ACPI_MACHINE_WIDTH correctly. Also, acpidump.inf specified explicit per-architecture (but identical) CFLAGS. Rather than duplicating this further, use the same setting for all architectures until there is actually a need to diverge. Also update README to make it obvious AArch64 is supported. Signed-off-by: Leif Lindholm <leif.lindholm(a)linaro.org> --- v2 contains a fix for a non-functional issue, which could generate warnings when building with CLANG. generate/efi/AcpiPkg.dsc | 2 +- generate/efi/README | 1 + generate/efi/acpidump/acpidump.inf | 6 ++---- source/include/platform/acefi.h | 2 +- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/generate/efi/AcpiPkg.dsc b/generate/efi/AcpiPkg.dsc index 323d39c..9302555 100644 --- a/generate/efi/AcpiPkg.dsc +++ b/generate/efi/AcpiPkg.dsc @@ -18,7 +18,7 @@ PLATFORM_VERSION = 1.0 DSC_SPECIFICATION = 0x00010005 OUTPUT_DIRECTORY = Build/Acpi - SUPPORTED_ARCHITECTURES = IA32|X64 + SUPPORTED_ARCHITECTURES = AARCH64|IA32|X64 BUILD_TARGETS = DEBUG|RELEASE SKUID_IDENTIFIER = DEFAULT diff --git a/generate/efi/README b/generate/efi/README index 7550e9d..b3ec3ff 100644 --- a/generate/efi/README +++ b/generate/efi/README @@ -20,6 +20,7 @@ But the porting has only been tested in a Linux environment. You can find built EFI binaries (e.x., acpidump.efi) in the following folders: + Build/Acpi/DEBUG_GCC47/AARCH64: aarch64 targets Build/Acpi/DEBUG_GCC47/IA32: i386 targets Build/Acpi/DEBUG_GCC47/X64: x86_64 targets diff --git a/generate/efi/acpidump/acpidump.inf b/generate/efi/acpidump/acpidump.inf index 8d2c979..e5f21c0 100644 --- a/generate/efi/acpidump/acpidump.inf +++ b/generate/efi/acpidump/acpidump.inf @@ -55,7 +55,5 @@ BaseLib [BuildOptions] - MSFT:*_*_IA32_CC_FLAGS = /Oi- /WX- /D_EDK2_EFI /DACPI_DUMP_APP - MSFT:*_*_X64_CC_FLAGS = /Oi- /WX- /D_EDK2_EFI /DACPI_DUMP_APP - GCC:*_*_IA32_CC_FLAGS = -U__linux__ -U_LINUX -D_EDK2_EFI -DACPI_DUMP_APP -fno-builtin -iwithprefix include - GCC:*_*_X64_CC_FLAGS = -U__linux__ -U_LINUX -D_EDK2_EFI -DACPI_DUMP_APP -fno-builtin -iwithprefix include + MSFT:*_*_*_CC_FLAGS = /Oi- /WX- /D_EDK2_EFI /DACPI_DUMP_APP + GCC:*_*_*_CC_FLAGS = -U__linux__ -U_LINUX -D_EDK2_EFI -DACPI_DUMP_APP -fno-builtin -iwithprefix include diff --git a/source/include/platform/acefi.h b/source/include/platform/acefi.h index 8328ab6..75ef89a 100644 --- a/source/include/platform/acefi.h +++ b/source/include/platform/acefi.h @@ -140,7 +140,7 @@ #define VOID void -#if defined(__ia64__) || defined(__x86_64__) +#if defined(__aarch64__) || defined(__ia64__) || defined(__x86_64__) #define ACPI_MACHINE_WIDTH 64 -- 2.10.2

8 years, 4 months

UEFI LinuxLoader app usage

by Jun Nie

I am new to UEFI and trying to boot Linux with LinuxLoader app. But I cannot find detail information for below questions. Could anyone point out where I can find related information or example code? Thanks for your time! 1. How to feed command line to this app so that ProcessAppCommandLine() can process it? 2. And how should I generate device path string for raw blockIO device with specified offset/size? UEFI 2.6 spec does not provide much information in 9.4.5 Media Device Path Rules. Thank you! Jun

8 years, 4 months

[PATCH] Platforms\ARM\Juno\AcpiTables: Use 64-bit Watchdog PCDs

by evan.lloyd＠arm.com

From: Alexei <Alexei.Fedorov(a)arm.com> Update Watchdog PCD access to align with the changes made in Tianocore edk2\ArmPkg\ArmPkg.dec for fixing Bug #361 "ARM Generic Watchdog base addresses must be declared as UINT64 values" https://bugzilla.tianocore.org/show_bug.cgi?id=361 PcdGenericWatchdogControlBase & PcdGenericWatchdogRefreshBase are declared as UINT32 values in ArmPkg.dec, but for platforms with addresses in the memory area above 4GB this causes build error F000: Too large PCD value for datum type [UINT32] of PCD gArmTokenSpaceGuid.PcdGenericWatchdogControlBase Change-Id: Ie4376ef69d5c939751268ed090b8949aeed978be Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Alexei Fedorov <alexei.fedorov(a)arm.com> Signed-off-by: Evan Lloyd <evan.lloyd(a)arm.com> --- Platforms/ARM/Juno/AcpiTables/Gtdt.aslc | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/Platforms/ARM/Juno/AcpiTables/Gtdt.aslc b/Platforms/ARM/Juno/AcpiTables/Gtdt.aslc index 5e2daf9abb8344ff121dace4fa827838b10ac287..5e83802d576b11178a7fdb556086dea41ee0859f 100644 --- a/Platforms/ARM/Juno/AcpiTables/Gtdt.aslc +++ b/Platforms/ARM/Juno/AcpiTables/Gtdt.aslc @@ -92,9 +92,15 @@ #if (JUNO_WATCHDOG_COUNT != 0) { EFI_ACPI_5_1_SBSA_GENERIC_WATCHDOG_STRUCTURE_INIT( - FixedPcdGet32 (PcdGenericWatchdogRefreshBase), FixedPcdGet32 (PcdGenericWatchdogControlBase), 93, 0), + FixedPcdGet64 (PcdGenericWatchdogRefreshBase), + FixedPcdGet64 (PcdGenericWatchdogControlBase), + 93, + 0), EFI_ACPI_5_1_SBSA_GENERIC_WATCHDOG_STRUCTURE_INIT( - FixedPcdGet32 (PcdGenericWatchdogRefreshBase), FixedPcdGet32 (PcdGenericWatchdogControlBase), 94, EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_FLAG_SECURE_TIMER) + FixedPcdGet64 (PcdGenericWatchdogRefreshBase), + FixedPcdGet64 (PcdGenericWatchdogControlBase), + 94, + EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_FLAG_SECURE_TIMER) } #endif }; -- Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")

8 years, 4 months

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Linaro-uefi February 2017