Linaro-uefi March 2017

linaro-uefi@lists.linaro.org

11 participants
29 discussions

by Marcin Wojtas

Hi, After introduction of MvHwDescLib got merged, I submit second version of the RTC support, which now use it as well. Other than that all remarks from v1 are answered, details can be found in the changelog below. The patches are also available in the github. https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/opp… Any comments or remarks would be very welcome. Best regards, Marcin Changelog: v1 -> v2: * Include <Library/UefiBootServicesTableLib.h> instead of extern *gBS * Remove RtcReset function entirely * Add RtcDelayedWrite helper function for modification of time and alarm registers - cleaner code, with common valid comment. * Use MmioAndThenOr32 instead of RtcUpdateMbusTimingParams function, remove magic * Add proper error path instead of assertions * Move defines to local header * Create new RTC description template in MvHwDescLib.h and use it for obtaining controller data. * Sort packages in inf file Marcin Wojtas (2): Platforms/Marvell: Introduce RTC support Platforms/Marvell: Enable RTC library on Armada70x0 platforms Platforms/Marvell/Armada/Armada.dsc.inc | 3 +- Platforms/Marvell/Armada/Armada70x0.dsc | 3 + .../Library/RealTimeClockLib/RealTimeClockLib.c | 335 +++++++++++++++++++++ .../Library/RealTimeClockLib/RealTimeClockLib.inf | 53 ++++ Platforms/Marvell/Include/Library/MvHwDescLib.h | 25 ++ Platforms/Marvell/Marvell.dec | 3 + 6 files changed, 421 insertions(+), 1 deletion(-) create mode 100644 Platforms/Marvell/Armada/Library/RealTimeClockLib/RealTimeClockLib.c create mode 100644 Platforms/Marvell/Armada/Library/RealTimeClockLib/RealTimeClockLib.inf -- 1.8.3.1

8 years, 2 months

[PATCH v3 0/4] Armada 8k preparation

by Marcin Wojtas

Hi, Here's third version of the patchset comprising minor issues fixed pointed in v2. The commits are also available in the github: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/opp… Any remarks or comments will be very welcome. Best regards, Marcin Changelog v2 -> v3: * Add reviewed-by's to 1/4 and 3/4 * 1/4 Add 'Status = EFI_INVALID_PARAMETER' in switch default and remove default variable initalization * 3/4 For clarity leave NonDiscoverable header in PciEmulation as well * 4/4 Fix whitespaces v1 -> v2: * 1/4: Change type of COMPHY_CHIP_INIT callback to VOID and rework Status usage * 2/4: Add 'Reviewed-by' * 3/4: - Sort includes in header - Rename 'storage' to 'nondiscoverable' in all macros and names - Add defines for array sizes in definition - Add defines for base addresses, so that they describe HW block and device - Add comments for sections * 4/4: - Remove 'Ptr' suffixes - Move and rename DEV_ENABLED macro from PciEmulation driver - use it in ComPhy code - Simplify obtaining enabled Sata ports and do not return EFI_SUCCESS on PCD mismatch (lane enabled in ComPhy, despite the controller disabled) - Add macros for controller ID's - Remove unrelated style fixes - Rewrite error print information in ComPhyCp110Init, because from now we have more root causes than PLL Konstantin Porotchkin (4): Platforms/Marvell: ComPhyLib: Fix compilation warning Platforms/Marvell: Add support for COMPHY on CP slaves Platform/Marvell: Extend and share the platform description Platform/Marvell: ComPhyLib: Enable SATA PHY init for multiple devices Platforms/Marvell/Armada/Armada70x0.dsc | 9 +- Platforms/Marvell/Include/Library/MvHwDescLib.h | 106 ++++++++++++++++++++++ Platforms/Marvell/Library/ComPhyLib/ComPhyCp110.c | 45 ++++++--- Platforms/Marvell/Library/ComPhyLib/ComPhyLib.c | 8 +- Platforms/Marvell/Library/ComPhyLib/ComPhyLib.h | 4 +- Platforms/Marvell/Library/ComPhyLib/ComPhyLib.inf | 3 +- Platforms/Marvell/Marvell.dec | 3 - Platforms/Marvell/PciEmulation/PciEmulation.c | 51 ++--------- 8 files changed, 156 insertions(+), 73 deletions(-) create mode 100644 Platforms/Marvell/Include/Library/MvHwDescLib.h -- 1.8.3.1

8 years, 2 months

[PATCH v2 0/4] Armada 8k preparation

by Marcin Wojtas

Hi, I submit v2 of Armada 7k/8k improvements. It addresses all comments from review and add some minor improvements. Details can be found in the changelog and commit logs. The commits are also available in the github: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/opp… Any remarks or comments will be very welcome. Best regards, Marcin Changelog v1 -> v2: * 1/4: Change type of COMPHY_CHIP_INIT callback to VOID and rework Status usage * 2/4: Add 'Reviewed-by' * 3/4: - Sort includes in header - Rename 'storage' to 'nondiscoverable' in all macros and names - Add defines for array sizes in definition - Add defines for base addresses, so that they describe HW block and device - Add comments for sections * 4/4: - Remove 'Ptr' suffixes - Move and rename DEV_ENABLED macro from PciEmulation driver - use it in ComPhy code - Simplify obtaining enabled Sata ports and do not return EFI_SUCCESS on PCD mismatch (lane enabled in ComPhy, despite the controller disabled) - Add macros for controller ID's - Remove unrelated style fixes - Rewrite error print information in ComPhyCp110Init, because from now we have more root causes than PLL Konstantin Porotchkin (4): Platforms/Marvell: ComPhyLib: Fix compilation warning Platforms/Marvell: Add support for COMPHY on CP slaves Platform/Marvell: Extend and share the platform description Platform/Marvell: ComPhyLib: Enable SATA PHY init for multiple devices Platforms/Marvell/Armada/Armada70x0.dsc | 9 +- Platforms/Marvell/Include/Library/MvHwDescLib.h | 106 ++++++++++++++++++++++ Platforms/Marvell/Library/ComPhyLib/ComPhyCp110.c | 46 ++++++---- Platforms/Marvell/Library/ComPhyLib/ComPhyLib.c | 8 +- Platforms/Marvell/Library/ComPhyLib/ComPhyLib.h | 4 +- Platforms/Marvell/Library/ComPhyLib/ComPhyLib.inf | 3 +- Platforms/Marvell/Marvell.dec | 4 - Platforms/Marvell/PciEmulation/PciEmulation.c | 52 ++--------- 8 files changed, 156 insertions(+), 76 deletions(-) create mode 100644 Platforms/Marvell/Include/Library/MvHwDescLib.h -- 1.8.3.1

8 years, 2 months

[PATCH] Platforms: add BootLogoLib resolutions

by Ard Biesheuvel

Add a resolution for BootLogoLib to all users of the ArmPkg version of PlatformBootManagerLib, so that we can add the dependency upstream. This allows us to move to shared code for quiet [graphical] boot, and get rid of a IntelFrameworkModulePkg dependency along the way. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheuvel(a)linaro.org> --- Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc | 1 + Platforms/AMD/Styx/Overdrive1000Board/Overdrive1000Board.dsc | 1 + Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc | 1 + Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 1 + Platforms/Hisilicon/HiKey/HiKey.dsc | 1 + 5 files changed, 5 insertions(+) diff --git a/Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc b/Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc index cb8b6cd0d822..e46ab466bff5 100644 --- a/Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc +++ b/Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc @@ -125,6 +125,7 @@ DEFINE DO_KCS = 0 CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf + BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf diff --git a/Platforms/AMD/Styx/Overdrive1000Board/Overdrive1000Board.dsc b/Platforms/AMD/Styx/Overdrive1000Board/Overdrive1000Board.dsc index 60ceb715ed79..367a11143aab 100644 --- a/Platforms/AMD/Styx/Overdrive1000Board/Overdrive1000Board.dsc +++ b/Platforms/AMD/Styx/Overdrive1000Board/Overdrive1000Board.dsc @@ -128,6 +128,7 @@ DEFINE DO_KCS = 1 CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf + BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf # diff --git a/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc b/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc index dcab8fb43cec..dc0bb99b6eca 100644 --- a/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc +++ b/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc @@ -129,6 +129,7 @@ DEFINE DO_KCS = 1 CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf + BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf # diff --git a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc index 431d6d0f76ce..c22fa0fa5f0b 100644 --- a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc +++ b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc @@ -122,6 +122,7 @@ # BDS Libraries UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf + BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf AcpiLib|EmbeddedPkg/Library/AcpiLib/AcpiLib.inf FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf diff --git a/Platforms/Hisilicon/HiKey/HiKey.dsc b/Platforms/Hisilicon/HiKey/HiKey.dsc index a9b29f2b0e9b..8f16f2706574 100644 --- a/Platforms/Hisilicon/HiKey/HiKey.dsc +++ b/Platforms/Hisilicon/HiKey/HiKey.dsc @@ -63,6 +63,7 @@ FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf + BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf -- 2.7.4

8 years, 2 months

[PATCH] Platforms: remove PcdShellFile PCD definition from generic BDS users

by Ard Biesheuvel

The users of the generic BDS no longer need to carry a definition of the PCD gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile now that the PlatformBootManagerLib implementation in ArmPkg does not use it anymore. So get rid of it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheuvel(a)linaro.org> --- Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc | 1 - Platforms/AMD/Styx/Overdrive1000Board/Overdrive1000Board.dsc | 1 - Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc | 1 - Platforms/ARM/Juno/ArmJuno.dsc | 1 - Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 1 - Platforms/Hisilicon/HiKey/HiKey.dsc | 3 --- 6 files changed, 8 deletions(-) diff --git a/Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc b/Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc index e46ab466bff5..355442bcfca6 100644 --- a/Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc +++ b/Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc @@ -357,7 +357,6 @@ DEFINE DO_KCS = 0 gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 } - gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|L"AMD Seattle" diff --git a/Platforms/AMD/Styx/Overdrive1000Board/Overdrive1000Board.dsc b/Platforms/AMD/Styx/Overdrive1000Board/Overdrive1000Board.dsc index 367a11143aab..e245b536dde1 100644 --- a/Platforms/AMD/Styx/Overdrive1000Board/Overdrive1000Board.dsc +++ b/Platforms/AMD/Styx/Overdrive1000Board/Overdrive1000Board.dsc @@ -359,7 +359,6 @@ DEFINE DO_KCS = 1 gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 } - gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|L"SoftIron Overdrive 1000" diff --git a/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc b/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc index dc0bb99b6eca..53c7d67bd9b6 100644 --- a/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc +++ b/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc @@ -364,7 +364,6 @@ DEFINE DO_KCS = 1 gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 } - gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|L"AMD Seattle" diff --git a/Platforms/ARM/Juno/ArmJuno.dsc b/Platforms/ARM/Juno/ArmJuno.dsc index 4080c0bc7bd6..1f56643ae996 100644 --- a/Platforms/ARM/Juno/ArmJuno.dsc +++ b/Platforms/ARM/Juno/ArmJuno.dsc @@ -170,7 +170,6 @@ gEmbeddedTokenSpaceGuid.PcdMetronomeTickPeriod|1000 gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE - gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } # # SMBIOS entry point version diff --git a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc index c22fa0fa5f0b..fdd5341971b7 100644 --- a/Platforms/ARM/VExpress/ArmVExpress.dsc.inc +++ b/Platforms/ARM/VExpress/ArmVExpress.dsc.inc @@ -421,7 +421,6 @@ gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE - gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } # use the TTY terminal type gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4 diff --git a/Platforms/Hisilicon/HiKey/HiKey.dsc b/Platforms/Hisilicon/HiKey/HiKey.dsc index 8f16f2706574..773c5809aa5d 100644 --- a/Platforms/Hisilicon/HiKey/HiKey.dsc +++ b/Platforms/Hisilicon/HiKey/HiKey.dsc @@ -318,9 +318,6 @@ gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|10 - # GUID of the UEFI Shell - gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } - # GUID of the UI app gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 } -- 2.7.4

8 years, 2 months

Re: [Linaro-uefi] [linaro-uefi][ArmMmuLib] Is it a bug?

by Heyi Guo

Any comments? 在 3/16/2017 9:03 PM, Heyi Guo 写道: > Hi folks, > > In "ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c", line 262, I > found below code which seems like a bug. Could you help to confirm? > > 262 TableAttributes = TT_TABLE_AP_NO_PERMISSION; > 263 if (Attributes & TT_NS) { > 264 TableAttributes = TT_TABLE_NS; > 265 } > 266 > > Why not a "|=" is used at line 264? Are TT_TABLE_AP_NO_PERMISSION and > TT_TABLE_NS exclusive? > > Thanks and regards, > > Gary (Heyi Guo) > >

8 years, 2 months

[linaro-uefi] How to implement GOP frame buffer

by Heyi Guo

Hi Ard, To support UEFI GOP frame buffer, is it enough to provide UEFI GOP protocol and valid FrameBufferBase and FrameBufferSize via GOP mode? I still have some question. As we are using a PCIe VGA device, the frame buffer might probably be certain PCIe memory resource BAR of VGA device. Then is it possible for OS to re-enumerate PCIe bus and re-allocate memory BAR resources? If so, who will be responsible to update frame buffer base? Thanks and regards, Heyi Guo (Gary)

8 years, 2 months

[PATCH 0/4] Armada 8k preparation

by Marcin Wojtas

Hi, As agreed during RTC support review, we submit first a series being a preparation for adding Armada 80x0 SoC support, which is a superset of existing in OpenPlatformPkg Armada 70x0. Because currently the devices hardware description is unnecessarily added in the PCD's, we begin a cleanup, allowing to achieve more flexible and scalable approach. This patchset is a beginning of Armada 7k/8k support improvement, that will allow to store SoC's description in one place, accessible for the drivers and libraries. In near future more peripherals will be described in a similar way to storage devices, that are registered via PciEmulation. The commits are also available in the github: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/opp… Any remarks or comments will be very welcome. Best regards, Marcin Konstantin Porotchkin (4): Platforms/Marvell: ComPhyLib: Fix compilation warning Platforms/Marvell: Add support for COMPHY on CP slaves Platform/Marvell: Extend and share the platform description Platform/Marvell: ComPhyLib: Enable SATA PHY init for multiple devices Platforms/Marvell/Armada/Armada70x0.dsc | 9 +-- Platforms/Marvell/Include/Library/MvHwDescLib.h | 78 +++++++++++++++++++++++ Platforms/Marvell/Library/ComPhyLib/ComPhyCp110.c | 52 ++++++++++----- Platforms/Marvell/Library/ComPhyLib/ComPhyLib.c | 8 ++- Platforms/Marvell/Library/ComPhyLib/ComPhyLib.inf | 3 +- Platforms/Marvell/Marvell.dec | 4 -- Platforms/Marvell/PciEmulation/PciEmulation.c | 44 ++----------- 7 files changed, 128 insertions(+), 70 deletions(-) create mode 100644 Platforms/Marvell/Include/Library/MvHwDescLib.h -- 1.8.3.1

8 years, 2 months

[PATCH] Platforms/StyxSpiFvDxe: fix potential boot crash on varstore write

by Ard Biesheuvel

The varstore shadow FV is kept in sync with actual SPI flash read, write and erase operations. Since we only expose a small slice of the SPI flash for the variable store, we keep an internal LBA offset and take it into account when translating shadow FV LBAs to actual LBAs. As it turns out, the erase routine applies the LBA offset incorrectly, resulting in the wrong flash block being erased, and the wrong range to be erased in the shadow FV, which could result in a crash if the memory access is out of bounds. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheuvel(a)linaro.org> --- Platforms/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.c | 1 - 1 file changed, 1 deletion(-) diff --git a/Platforms/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.c b/Platforms/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.c index 03fd9e816b96..f544af3eeb2d 100644 --- a/Platforms/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.c +++ b/Platforms/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.c @@ -439,7 +439,6 @@ StyxSpiFvDxeErase ( for (Start = VA_ARG (Args, EFI_LBA); Start != EFI_LBA_LIST_TERMINATOR; Start = VA_ARG (Args, EFI_LBA)) { - Start += mNvStorageLbaOffset; Length = VA_ARG (Args, UINTN); Status = mIscpDxeProtocol->AmdExecuteEraseFvBlockDxe (mIscpDxeProtocol, (Start + mNvStorageLbaOffset) * BLOCK_SIZE, -- 2.7.4

8 years, 2 months

[PATCH v4 0/6] ATAPI support on SiI SATA adapter

by Jeremy Linton

The SiI isn't an AHCI compatible adapter so it implements the EFI ATA pass-through protocol directly. This works for fixed hard drives, but not ATAPI attached devices (CDROM, DVDROM, TAPE, etc). This patch adds read only ATAPI support via the EFI SCSI pass-through protocol, allowing boot from attached CD/DVD. This patch also cleans up, and tweaks recovery paths/etc in the original driver. When combined with the ARM/PCI dma lib changes this allows us to relax the IO alignment requirement that caused grub failures. Finally, the OpenPlatformPkg/Juno must be updated, with another patch to avoid build breaks now that the SiI has a dependency on the SCSI libraries. V3->V4 Fixed a bug that in theory kept multiple ATAPI devices from working. More patch formatting fixes per Ard Dropped the sense validation logic, and changes to the Mde header V2->V3: Send the correct patch, rather than the one I was running the patch checker against. V1->V2: Formatting corrections per Ard's comments and Daniil's updated patch checker. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeremy Linton <jeremy.linton(a)arm.com> Jeremy Linton (6): EmbeddedPkg: SiI3132: Note that ARM is using this Dxe EmbeddedPkg: SiI3132: Add ScsiProtocol callbacks EmbeddedPkg: SiI3132: Add SCSI protocol support to header EmbeddedPkg: SiI3132: Break out FIS command submission EmbeddedPkg: SiI3132: Cleanup device node creation EmbeddedPkg: SiI3132: Enable SCSI pass-through protocol EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c | 52 ++- EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h | 103 ++++- .../Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf | 2 + .../Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c | 280 ++++++++------ .../Drivers/SataSiI3132Dxe/SiI3132ScsiPassThru.c | 424 +++++++++++++++++++++ MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf | 2 +- OpenPlatformPkg | 2 +- 7 files changed, 725 insertions(+), 140 deletions(-) create mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132ScsiPassThru.c -- 2.9.3

8 years, 2 months

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Linaro-uefi March 2017