Linaro-uefi April 2017

linaro-uefi@lists.linaro.org

15 participants
30 discussions

[PATCH] Platforms/ARM/Juno: fix RELEASE build with new PciHostBridgeLib

by Leif Lindholm

An array of static strings is set up for use in printing debug messages. This makes some compilers unhappy when building in RELEASE mode. So hide the definition behind #ifndef MDE_NDEBUG. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm <leif.lindholm(a)linaro.org> --- Platforms/ARM/Juno/Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Platforms/ARM/Juno/Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.c b/Platforms/ARM/Juno/Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.c index f5cb254465..5263a2985d 100644 --- a/Platforms/ARM/Juno/Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.c +++ b/Platforms/ARM/Juno/Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.c @@ -138,9 +138,11 @@ PciHostBridgeFreeRootBridges ( } +#ifndef MDEPKG_NDEBUG STATIC CONST CHAR16 mPciHostBridgeLibAcpiAddressSpaceTypeStr[][4] = { L"Mem", L"I/O", L"Bus" }; +#endif /** Inform the platform that the resource conflict happens. -- 2.11.0

9 years, 1 month

[PATCH] Platforms/AMD/Styx: fix duplicate typedef in AmdIscpDxe

by Leif Lindholm

The struct _AMD_ISCP_DXE_PROTOCOL is given an early typedef, only to be defined as "typedef struct _AMD_ISCP_DXE_PROTOCOL..." later on. Delete the duplication. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm <leif.lindholm(a)linaro.org> --- .../AMD/Styx/Binary/AmdModulePkg/Include/Protocol/AmdIscpDxeProtocol.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Platforms/AMD/Styx/Binary/AmdModulePkg/Include/Protocol/AmdIscpDxeProtocol.h b/Platforms/AMD/Styx/Binary/AmdModulePkg/Include/Protocol/AmdIscpDxeProtocol.h index 5daeb0cbc2..50db778453 100644 --- a/Platforms/AMD/Styx/Binary/AmdModulePkg/Include/Protocol/AmdIscpDxeProtocol.h +++ b/Platforms/AMD/Styx/Binary/AmdModulePkg/Include/Protocol/AmdIscpDxeProtocol.h @@ -279,7 +279,6 @@ EFI_STATUS *---------------------------------------------------------------------------------------- */ /// ISCP DXE Protocol Structure -typedef struct _AMD_ISCP_DXE_PROTOCOL { AMD_EXECUTE_CPU_CORE_RESET AmdExecuteCpuCoreReset; ///< Execute CPU Core Reset AMD_EXECUTE_CPU_RETRIEVE_ID AmdExecuteCpuRetrieveId; ///< Execute CPU Retrieve ID @@ -304,6 +303,6 @@ struct _AMD_ISCP_DXE_PROTOCOL { AMD_EXECUTE_BMC_PRESENT AmdExecuteBmcPresent; ///< Execute BMC presence check AMD_EXECUTE_RETRIEVE_BERT_RECORD AmdExecuteRetrieveBertRecord; ///< Execute Retrieve Boot Error Record AMD_EXECUTE_REGISTER_ERROR_SOURCE AmdExecuteRegisterErrorSource; ///< Execute Register Generic Hardware Error Source -} AMD_ISCP_DXE_PROTOCOL; +}; #endif //_AMD_ISCP_DXE_PROTOCOL_H_ -- 2.11.0

9 years, 1 month

[PATCH v2 0/2] Platforms/AMD: fix legacy interrupt routing

by Ard Biesheuvel

Update the DTS and ACPI descriptions with correct information about the routing of legacy interrupts. For DT, this comes down to updating the interrupt-map with distinct sets of 4 GIC interrupt lines per PCIe slot. For ACPI, we need to update the PNP0A08 node and add three companion devices, one for each slot, whose _PRT methods describe the legacy interrupt routing of each respective slot. The _PRT method at the root of the PCI ACPI hierarchy is updated to map INTA (which is shared by all functions of the bridge device) to GIC interrupt #320. With this change, the boot log is free of warnings and non-MSI capable devices work as expected. Tested on Cello with xhci_hcd.quirks=64 passed on the kernel command line, in which case the xhci interrupt is routed to GIC interrupt #324 Ard Biesheuvel (2): Platforms/AMD: correct legacy PCI interrupt routing in DSDT Platforms/AMD: correct legacy PCI interrupt routing in DTS Platforms/AMD/Styx/AcpiTables/Dsdt.asl | 63 +++++++++++--------- Platforms/AMD/Styx/OverdriveBoard/FdtBlob/styx-overdrive.dtb | Bin 7973 -> 8123 bytes Platforms/AMD/Styx/OverdriveBoard/FdtBlob/styx-overdrive.dts | 20 +++++-- 3 files changed, 49 insertions(+), 34 deletions(-) -- 2.9.3

9 years, 1 month

[PATCH] Hisilicon: Fix ACPI/DSDT table checksum error

by Chenhui Sun

Refresh checksum after changing DSDT table. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi.guo(a)linaro.org> Signed-off-by: Yi Li <phoenix.liyi(a)huawei.com> Signed-off-by: Chenhui Sun <chenhui.sun(a)linaro.org> --- Chips/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/Chips/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.c b/Chips/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.c index 41f5692..1f74d31 100644 --- a/Chips/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.c +++ b/Chips/Hisilicon/Drivers/AcpiPlatformDxe/EthMac.c @@ -442,6 +442,29 @@ static EFI_STATUS ProcessDSDT( return EFI_SUCCESS; } +STATIC +VOID +AcpiCheckSum ( + IN OUT EFI_ACPI_SDT_HEADER *Table + ) +{ + UINTN ChecksumOffset; + UINT8 *Buffer; + + ChecksumOffset = OFFSET_OF (EFI_ACPI_DESCRIPTION_HEADER, Checksum); + Buffer = (UINT8 *)Table; + + // + // set checksum to 0 first + // + Buffer[ChecksumOffset] = 0; + + // + // Update checksum value + // + Buffer[ChecksumOffset] = CalculateCheckSum8 (Buffer, Table->Length); +} + EFI_STATUS EthMacInit(void) { EFI_STATUS Status; @@ -478,6 +501,7 @@ EFI_STATUS EthMacInit(void) ProcessDSDT(AcpiTableProtocol, TableHandle); AcpiTableProtocol->Close(TableHandle); + AcpiCheckSum (Table); } return EFI_SUCCESS; -- 1.9.1

9 years, 1 month

[PATCH 1/2] Chips/Hisilicon: add missing UefiBootManagerLib resolution to shared .inc

by Ard Biesheuvel

Upstream EDK2 changes now require platforms that build the UEFI Shell from source to provide a resolution for UefiBootManagerLib, and some other library class it transitively depends on. So add them to the DSC include shared between the HiSilicon platforms. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheuvel(a)linaro.org> --- Chips/Hisilicon/Hisilicon.dsc.inc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Chips/Hisilicon/Hisilicon.dsc.inc b/Chips/Hisilicon/Hisilicon.dsc.inc index d856a659a8fb..716900874274 100644 --- a/Chips/Hisilicon/Hisilicon.dsc.inc +++ b/Chips/Hisilicon/Hisilicon.dsc.inc @@ -198,7 +198,12 @@ HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf + +[LibraryClasses.common.UEFI_DRIVER,LibraryClasses.common.UEFI_APPLICATION] + DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf + ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf + UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf [LibraryClasses.common.UEFI_DRIVER] ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf -- 2.9.3

9 years, 1 month

[PATCH v3 0/6] Platforms/ARM: FVP spring cleaning -- OpenPlatformPkg edition

by Ard Biesheuvel

This is now mainly focused on FVP, although some changes affect TC2 and Juno as well. However, the switch to DtPlatformDxe, which is the primary purpose of this series, is only implemented for FVP. Note that the full functionality is only enabled when building with DT_SUPPORT=TRUE, in which case the platform is built with a bunch of DTB images built in, and a menu option that allows choosing between ACPI and DT (which does require working non-volatile storage). Without DT support, the platform is essentially ACPI only, unless a DTB is supplied to the OS via one of the available out-of-band mechanisms. Ard Biesheuvel (6): Platforms/VExpress: remove unused logo PCD Platforms/VExpress: remove unused StatusCode references Platforms/VExpress: get rid of Tiano compression Platforms/VExpress: remove BdsLib library class resolutions Platforms/FVP: add DtPlatformDtbLoaderLib implementation Platforms/FVP-AArch64: switch to simpler DT platform driver Platforms/ARM/Juno/ArmJuno.dsc | 8 ++ Platforms/ARM/Juno/ArmJuno.fdf | 9 -- Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.dsc | 13 +- Platforms/ARM/VExpress/ArmVExpress-CTA15-A7.fdf | 16 --- Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc | 33 ++--- Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.fdf | 54 ++------ Platforms/ARM/VExpress/ArmVExpress.dsc.inc | 24 +--- Platforms/ARM/VExpress/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.c | 134 ++++++++++++++++++++ Platforms/ARM/VExpress/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf | 39 ++++++ 9 files changed, 221 insertions(+), 109 deletions(-) create mode 100644 Platforms/ARM/VExpress/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.c create mode 100644 Platforms/ARM/VExpress/Library/ArmVExpressDtPlatformDtbLoaderLib/ArmVExpressDtPlatformDtbLoaderLib.inf -- 2.9.3

9 years, 1 month

[PATCH] Platforms/Marvell/Armada: remove ARM BdsLib resolution

by Ard Biesheuvel

The EBL shell nog longer depends on the deprecated ARM BdsLib, so remove the library class resolution for it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <ard.biesheuvel(a)linaro.org> --- Platforms/Marvell/Armada/Armada.dsc.inc | 1 - 1 file changed, 1 deletion(-) diff --git a/Platforms/Marvell/Armada/Armada.dsc.inc b/Platforms/Marvell/Armada/Armada.dsc.inc index bdaf53710d9b..475fc6d05379 100644 --- a/Platforms/Marvell/Armada/Armada.dsc.inc +++ b/Platforms/Marvell/Armada/Armada.dsc.inc @@ -128,7 +128,6 @@ # SemihostLib|ArmPkg/Library/SemihostLib/SemihostLib.inf # BDS Libraries - BdsLib|ArmPkg/Library/BdsLib/BdsLib.inf CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf GenericBdsLib|IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf PlatformBdsLib|ArmPlatformPkg/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf -- 2.9.3

9 years, 1 month

[Linaro-uefi v3 0/3] D03/D05 platforms bug fix

by Chenhui Sun

ode can also be found in linaro repo: http://git.linaro.org/people/heyi.guo/OpenPlatformPkg.git branch: rp-17.04-04 Mainly include * refine the code style according Leif's comments * drop the "Hisilicon: Fix ACPI/DSDT table checksum error" path this time, and will send out after ERP17.04 Chenhui Sun (2): Hisilicon: disable RC Option Rom Hisilicon: Add reconfig lane number feature shaochangliang (1): Hisilicon/PCIe: Fix the probability of I350 enumeration fail issue. .../Hi1610/Drivers/PcieInit1610/PcieInitLib.c | 184 ++++++++++++++++++++- .../Hi1610/Drivers/PcieInit1610/PcieInitLib.h | 4 + Chips/Hisilicon/Include/Regs/HisiPcieV1RegOffset.h | 5 + 3 files changed, 191 insertions(+), 2 deletions(-) -- 1.9.1

9 years, 1 month

[PATCH 0/6] Armada 7k CompPhy upgrade

by Marcin Wojtas

Hi, I submit a series of patches adding analog parameters configuration sequences for Sata and Pcie, 10G link (SFI + RXAUI) initalization and 2 minor improvements. Also first part of PCD rework is added, moving the controllers description to MvHwDescLib. Per-board lanes description new implementation will be submitted after this one. The commits are also available in the github: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/opp… Any remarks or comments will be very welcome. Best regards, Marcin Marcin Wojtas (6): Platform/Marvell: ComPhyLib: Cleanup and fix SerDes lanes assignment Platform/Marvell: ComPhyLib: Mark failing lane as unconnected Platform/Marvell: ComPhyLib: Configure analog parameters for SATA Platform/Marvell: ComPhyLib: Configure analog parameters for PCIE Platform/Marvell: ComPhyLib: Add missing SFI and RXAUI configuration Platform/Marvell: ComPhyLib: Move devices description to MvHwDescLib Documentation/Marvell/PortingGuide/ComPhy.txt | 60 +- Platforms/Marvell/Armada/Armada70x0.dsc | 13 +- Platforms/Marvell/Include/Library/MvComPhyLib.h | 5 + Platforms/Marvell/Include/Library/MvHwDescLib.h | 38 + Platforms/Marvell/Library/ComPhyLib/ComPhyCp110.c | 886 +++++++++++++++++++++- Platforms/Marvell/Library/ComPhyLib/ComPhyLib.c | 96 ++- Platforms/Marvell/Library/ComPhyLib/ComPhyLib.h | 318 +++++++- Platforms/Marvell/Library/ComPhyLib/ComPhyLib.inf | 26 +- Platforms/Marvell/Marvell.dec | 28 +- 9 files changed, 1278 insertions(+), 192 deletions(-) -- 1.8.3.1

9 years, 1 month

[Linaro-uefi v3 0/3] D03/D05 platforms bug fix

by Chenhui Sun

9 years, 1 month

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Linaro-uefi April 2017