I will change author waip23@foxmail.com to huangming23@huawei.com, and add "Signed-off-by: heyi.guo@linaro.org " in all patchs.
-----邮件原件----- 发件人: Leif Lindholm [mailto:leif.lindholm@linaro.org] 发送时间: 2017年9月21日 21:12 收件人: Heyi Guo heyi.guo@linaro.org 抄送: linaro-uefi@lists.linaro.org; edk2-devel@lists.01.org; graeme.gregory@linaro.org; ard.biesheuvel@linaro.org; Guoheyi guoheyi@huawei.com; wanghuiqiang wanghuiqiang@huawei.com; Huangming (Mark) huangming23@huawei.com; zhangjinsong (A) zhangjinsong2@huawei.com; waip23@126.com; Ming Huang waip23@foxmail.com 主题: Re: [PATCH edk2-platforms v3 09/11] D05/ACPI: Disable D05 SAS0 and SAS2
On Thu, Sep 21, 2017 at 06:59:55PM +0800, Heyi Guo wrote:
From: Ming Huang waip23@foxmail.com
Can you ensure all "From: " tags use the proper huawei.com addresses? Signed-off-by below is already correct. Also, since you are sending these patches out, you should also add your "Signed-off-by:" below that of the patch author. (Please double check this on other patches where I have missed it.)
Apart from that, this patch is fine.
/ Leif
There are no interface from SAS0 and SAS2 controller on D05, so SAS0 and SAS2 can't be use.
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang huangming23@huawei.com
Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl index 93beb95..6455130 100644 --- a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl +++ b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Dsdt/D05Sas.asl @@ -88,6 +88,11 @@ Scope(_SB) Store(0x7ffff, CLK) Sleep(1) }
- Method (_STA, 0, NotSerialized)
- {
Return (0x0)- } }
Device(SAS1) { @@ -239,6 +244,11 @@ Scope(_SB) Store(0x7ffff, CLK) Sleep(1) }
- Method (_STA, 0, NotSerialized)
- {
Return (0x0)- } }
} -- 1.9.1