12 Oct
2016
12 Oct
'16
8:53 a.m.
Hi Leif,
Thanks for your review. In general I agree with all of your comments, so I wouldn't response to them. The only exception is your question here, please find answear inline.
Best Regards, Jan
EmbeddedPkg/EmbeddedMonotonicCounter/EmbeddedMonotonicCounter.inf
- EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf
OK, so this doesn't really affect this patch, but can you explain why you decided to not use ResetRuntimeDxe?
We have used ResetRuntimeDxe for our old Reset implementation, but it wasn't compatible with ResetRuntimeService (and obviously didn't work from OS). That's why I decided to write completely new driver. As I review ResetRuntimeDxe code, I think I should use it and add my driver as LibResetSystem implementation. I will try to achieve it in v2.