On 2 November 2016 at 22:49, Leif Lindholm leif.lindholm@linaro.org wrote:
On Wed, Nov 02, 2016 at 11:39:43PM +0100, Marcin Wojtas wrote:
2016-11-02 22:56 GMT+01:00 Ard Biesheuvel ard.biesheuvel@linaro.org:
[...]
Great, thanks! It seems like all we need is there. I have a dillema now - since it's under review on EDK2 lists, I have doubts if there is any reason for adding similar solution in OPP.
I would very much prefer to not add your implementation to OPP only to delete it again a week or two later.
It may be a good moment to adjust to your solution and test - if everything is fine, we can drop our driver - what do you think?
Yes, that sounds good.
I know it's hard to predict, but when do you expect to get it merged? It's important due to tight schedule we have:/ In case of problems we will try to enhance OPP driver to be accepted and later replace solution, once it's ready - we still have almost a month to go.
I am not overly concerned by this. Worst case, we could add Ard's generic solution to OPP as a stop-gap solution.
I have a couple of questions:
- Is it possible to use it with multiple devices?
Yes.
- Is there any exaple of usage?
See Ard's recent posts to linaro-uefi for moving the AMD platforms onto this infrastructure.
- Sata in current silicone revision has some quirks (non-dma
coherent, +2 other minor stuff, which was avoided by substituting PciIoMemRead/Write with custom functions). Is there any backdoor in your design for creating sort of wrappers?
(pass, I'll let Ard answer)
No, not currently. And if this issue is fixed in recent silicon revisions, I would prefer not to merge the workaround at all.
- Do you have some branch in public repo, so that it would be easier
to obtain the patches?
Again, see Ard's recent posts to edk2-devel and linaro-uefi.
https://git.linaro.org/people/ard.biesheuvel/uefi-next.git/log/?h=pciio-emu
Note that there is discussion about moving this into MdeModulePkg, and renaming and/or modifying core parts of the infrastructure, so at the moment, this is somewhat of a moving target. However, I would be *very* interested in understanding the issues and/or limitations that you run into when using this code, so please don't hesitate to ping me with questions and/or comments (ardb on #linaro-enterprise)
Thanks, Ard.