On Fri, Jul 15, 2016 at 08:47:28AM +0200, Jan Dąbroś wrote:
Hi Leif,
Please find inline comments.
Best Regards, Jan
- gMarvellTokenSpaceGuid.PcdChip0ComPhyTypes|L"SGMII2;USB3_HOST0;SGMII0;SATA1;USB3_HOST1;PCIE2"
- gMarvellTokenSpaceGuid.PcdChip0ComPhySpeeds|L"3125;5000;1250;5000;5000;5000"
Hmm, the above two lines suggest to me that what we're actually dealing with here is a flattened structure of specific outputs from "Chip0"? If correct, this could be more clearly described in Documentation/Marvell/PortingGuide/ComPhy.txt (so actually a comment for 1/8).
Yes, we are describing configurations of outputs from simple chip. It is a bit like MPP (more complex). I will try to describe these PCDs more clearly.
diff --git a/Platforms/Marvell/Armada/Library/Armada70x0Lib/Armada70x0Lib.c b/Platforms/Marvell/Armada/Library/Armada70x0Lib/Armada70x0Lib.c index a2b25e1..9694e0f 100644 --- a/Platforms/Marvell/Armada/Library/Armada70x0Lib/Armada70x0Lib.c +++ b/Platforms/Marvell/Armada/Library/Armada70x0Lib/Armada70x0Lib.c @@ -16,6 +16,7 @@ #include <Library/ArmLib.h> #include <Library/ArmPlatformLib.h> #include <Library/MppLib.h> +#include <Library/ComPhyLib.h>
Move up one line to keep alphabetical sort order?
Ok.
#include <Ppi/ArmMpCoreInfo.h>
@@ -94,6 +95,7 @@ ArmPlatformInitialize (
//TODO: Add basic platfrom initialization
Does this comment still belong here?
Later on (in the one of the next patchsets) there will be Utmi library init call added here, that's why it wasn't removed. But all in all (and noting typo in this comment :)) I think it may be removed in this patch.
Either is fine with me. Thanks!
/ Leif