On Mon, Aug 22, 2016 at 12:25:18PM -0400, Alan Ott wrote:
Hi Leif, I thought I gave a quick response last week. I was on conference WiFi so maybe it got stuck in my phone.
I wouldn't normally ping someone this soon, but you sounded quite keen before so I figured something had been dropped.
For clarification - I have pushed the full driver, I just did not push the snippet that includes it in Juno builds.
Ok, great. I'll rebase on what's now upstream. I plan on getting to that today, so expect new patches maybe tonight or tomorrow.
Looking forward to it :)
This does leave a functionality gap (for now) on Juno, since the mechanism for setting the MAC address is one of the bits that disappeared. But especially after Daniils work making the driver portable enough that it builds (and works!) as EBC, I really want to make sure any platform-specific bits don't get included in the main driver.
I'm actually using that part too, because I'm testing on a board right now with an unprogrammed MAC. His code for MAC setting worked fine for me (the MAC came out backwards, but that's minor). I can submit a patch adding that feature (and put Daniil's name on it) in my series.
I'd like to figure out a cleaner way of doing it. Preferably relegate this entirely to a standalone app that let's you program up your MAC (and then not do anything special in the driver at all). But at the very least, the Pcds had to go.
So, by all means include the patch in the series, but I'm unlikely to merge it at this point. It is however clearly useful for development.
Regards,
Leif