On Tue, Feb 13, 2018 at 12:59:50AM +0000, Haojian Zhuang wrote:
On 02/13/2018 08:23 AM, Guo Heyi wrote:
Hi Haojian,
Dw8250SerialPortRuntimeLib actually depends on DW8250 hardware IP; if there isn't such device on Hikey, then you can't use this library instance indeed.
But I think PeiDxeDebugLibReportStatusCode should be some common code, however it depends on ReportStatusCodeLib and Status Code PEIM and Status code DXE driver. Have you added them too?
If I leave PeiDxeDebugLibReportStatusCode and move Dw8250SerialPortRuntimeLib out, I'll meet UEFI crash. It seems the debug lib is depended on serial port lib.
This is strange, because you should have your own SerialPortLib of your platform, otherwise error will occur when you build your UEFI.
And I consider that Dw8250 serial port is only valid on D02. So I decide to move them out.
I agree.
Regards,
Heyi
Best Regards Haojian