Hi Alan,
Are you using PCD variable or configuration protocol to set MAC address?
Thanks,
Daniil
________________________________ From: Alan Ott alan@softiron.co.uk Sent: Monday, August 22, 2016 11:25:18 AM To: Leif Lindholm Cc: linaro-uefi@lists.linaro.org; Daniil Egranov; ard.biesheuvel@linaro.org; ryan.harkin@linaro.org Subject: Re: [PATCH 0/7] Patches for the MarvellYukon driver
On 08/22/2016 11:58 AM, Leif Lindholm wrote:
Hi Alan,
Ping?
Hi Leif, I thought I gave a quick response last week. I was on conference WiFi so maybe it got stuck in my phone.
For clarification - I have pushed the full driver, I just did not push the snippet that includes it in Juno builds.
Ok, great. I'll rebase on what's now upstream. I plan on getting to that today, so expect new patches maybe tonight or tomorrow.
On Thu, Aug 18, 2016 at 09:55:52PM +0100, Leif Lindholm wrote:
Many thanks.
Took a bit longer to push than I at first expected, since after a quick glance I took a bit of a hatchet to it, and verified with Daniil.
This does leave a functionality gap (for now) on Juno, since the mechanism for setting the MAC address is one of the bits that disappeared. But especially after Daniils work making the driver portable enough that it builds (and works!) as EBC, I really want to make sure any platform-specific bits don't get included in the main driver.
I'm actually using that part too, because I'm testing on a board right now with an unprogrammed MAC. His code for MAC setting worked fine for me (the MAC came out backwards, but that's minor). I can submit a patch adding that feature (and put Daniil's name on it) in my series.
For this reason, I have not pushed the patch enabling the driver on Juno.
Talking to Daniil, he also felt that your version of the fix for the RELEASE build was the cleaner one - so I have left that bit out, and the driver currently builds only with DEBUG :)
Ok, that's fine. It did take me a while to find the right definition for that.
Alan.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.