With the update to the DMA lib, and the FIS submission cleanups the SiI driver now works fine with alignments less than a full page. Large alignment requirements cause problems with grub. Decrease it to a sane value.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeremy Linton jeremy.linton@arm.com --- EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c b/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c index 52b79fd..737e398 100644 --- a/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c +++ b/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c @@ -103,7 +103,7 @@ SataSiI3132Constructor ( Instance->PciIo = PciIo;
Instance->AtaPassThruMode.Attributes = EFI_ATA_PASS_THRU_ATTRIBUTES_PHYSICAL | EFI_ATA_PASS_THRU_ATTRIBUTES_LOGICAL; - Instance->AtaPassThruMode.IoAlign = 0x1000; + Instance->AtaPassThruMode.IoAlign = 0x4;
// Initialize SiI3132 ports SataSiI3132PortConstructor (Instance, 0); @@ -120,7 +120,7 @@ SataSiI3132Constructor ( Instance->AtaPassThruProtocol.ResetDevice = SiI3132ResetDevice;
Instance->ExtScsiPassThruMode.Attributes = EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_PHYSICAL | EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_LOGICAL; - Instance->ExtScsiPassThruMode.IoAlign = 0x1000; + Instance->ExtScsiPassThruMode.IoAlign = 0x4;
// Set SCSI Pass Thru Protocol Instance->ExtScsiPassThru.Mode = &Instance->ExtScsiPassThruMode;