29 Oct
2015
29 Oct
'15
7:53 p.m.
29.10.2015 18:25, Vladimir 'φ-coder/phcoder' Serbinenko пишет:
+if [ "x$machine" != xaarch64 ]; then
- multiboot_cmd="multiboot"
- module_linux_cmd="module"
- module_initrd_cmd="module --nounzip"
+else
- multiboot_cmd="xen_hypervisor"
- module_linux_cmd="xen_linux"
- module_initrd_cmd="xen_initrd"
+fi
Please do not hardcode an assumption that grub-mkconfig is executed on the same machine as GRUB is booted. I know that we have instances of such assumption in some cases but we'd like to eliminate them. Alternatives:
- Check arch on boot time
This makes it even more difficult for os-prober to parse grub.cfg. We need some alternative before going this route.
- Check that new xen commands are supported (define a new feature)
Please add xen_* aliases on x86 as well
Yes, that's better.