Hi Leif,
在 11/29/2016 7:42 PM, Leif Lindholm 写道:
On Tue, Nov 29, 2016 at 01:18:26PM +0800, Heyi Guo wrote:
Hi Leif,
Welcome back :)
Please help to review the RP1612 v4 version patchsets, thanks.
Yes, working from home today to do just that.
So if we are genuinely looking to remove the feature of verifying that the RAM is basically functional - why are we not just dropping the GenericMemoryTestDxe instead of replacing it with NullMemoryTestDxe?
Regards,
Leif
It's cost about 2 minutes on 256G memory platform,Even the SPARSE one? Sure, that is substantial. But it also sounds too much. We should definitely look into that post release.
We tested it at D05 using SPARSE mode, it also takes a long time.
yes, this protocol is required because we still using IntelBds,and we also think that using NullMemoryTestDxe is better.
Why?
It is just not to do the memory testing when switching to NullMemoryTestDxe, only speed up the boot time and no other benefits, but we do not keep to maintain D02 now, so just switch it on D03 and D05.
thanks, Heyi
I don't have a D02 here to test on, but it certainly builds fine without it. And from inspection, the runtime check for it does not trigger an ASSERT or even an error condition.
So what benefit does including NullMemoryTestDxe give you?
Regards,
Leif
Thanks, HeyiSame comment applies to D03 patch.
/ Leif
> Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Heyi Guo heyi.guo@linaro.org > --- > Platforms/Hisilicon/D02/Pv660D02.dsc | 2 +- > Platforms/Hisilicon/D02/Pv660D02.fdf | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Platforms/Hisilicon/D02/Pv660D02.dsc > b/Platforms/Hisilicon/D02/Pv660D02.dsc > index c11fa4e..d6fbcb9 100644 > --- a/Platforms/Hisilicon/D02/Pv660D02.dsc > +++ b/Platforms/Hisilicon/D02/Pv660D02.dsc > @@ -429,7 +429,7 @@ > # > # Memory test > # > - MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/GenericMemoryTestDxe.inf > + > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf > MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf > diff --git a/Platforms/Hisilicon/D02/Pv660D02.fdf > b/Platforms/Hisilicon/D02/Pv660D02.fdf > index ec4d749..c941e4e 100644 > --- a/Platforms/Hisilicon/D02/Pv660D02.fdf > +++ b/Platforms/Hisilicon/D02/Pv660D02.fdf > @@ -278,7 +278,7 @@ READ_LOCK_STATUS = TRUE > # > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > - INF MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/GenericMemoryTestDxe.inf > + INF > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf > INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf > INF IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf > -- > 1.9.1 >