On 7 March 2017 at 22:21, Leif Lindholm leif.lindholm@linaro.org wrote:
On Thu, Mar 02, 2017 at 09:39:07AM +0800, Haojian Zhuang wrote:
On 2017/3/1 22:32, Leif Lindholm wrote:
Hi Haojian,
I have not had any reply to my email on my comment on v3: https://lists.linaro.org/pipermail/linaro-uefi/2017-February/003930.html where I point out that I have had no reply to my comment on v2: https://lists.linaro.org/pipermail/linaro-uefi/2017-February/003886.html
And none of the points I raise there appear to have been addressed.
Actually I already applied those comments. But I don't have the DwUSB spec. My document only covers a few register definitions. I have to leave some hard code values since I don't know the definitions too.
OK, I noticed that the first few comments had not been addressed and assumed it applied throughout.
This is why it is useful to respond to review feedback rather than just submitting a new revision.
With that in mind...
On Wed, Feb 15, 2017 at 10:54:56PM +0800, Haojian Zhuang wrote:
Support Designware USB controller.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang haojian.zhuang@linaro.org
Drivers/Usb/DwUsbDxe/DwUsbDxe.c | 861 ++++++++++++++++++++++++++++++++++++++ Drivers/Usb/DwUsbDxe/DwUsbDxe.dec | 45 ++ Drivers/Usb/DwUsbDxe/DwUsbDxe.h | 641 ++++++++++++++++++++++++++++ Drivers/Usb/DwUsbDxe/DwUsbDxe.inf | 52 +++ Include/Protocol/DwUsb.h | 81 ++++ 5 files changed, 1680 insertions(+) create mode 100644 Drivers/Usb/DwUsbDxe/DwUsbDxe.c create mode 100644 Drivers/Usb/DwUsbDxe/DwUsbDxe.dec create mode 100644 Drivers/Usb/DwUsbDxe/DwUsbDxe.h create mode 100644 Drivers/Usb/DwUsbDxe/DwUsbDxe.inf create mode 100644 Include/Protocol/DwUsb.h
diff --git a/Drivers/Usb/DwUsbDxe/DwUsbDxe.c b/Drivers/Usb/DwUsbDxe/DwUsbDxe.c new file mode 100644 index 0000000..13b85b1 --- /dev/null +++ b/Drivers/Usb/DwUsbDxe/DwUsbDxe.c @@ -0,0 +1,861 @@ +/** @file
- Copyright (c) 2015-2017, Linaro. All rights reserved.
- This program and the accompanying materials
- are licensed and made available under the terms and conditions of the BSD License
- which accompanies this distribution. The full text of the license may be found at
- http://opensource.org/licenses/bsd-license.php
- THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
- WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+**/
+#include <IndustryStandard/Usb.h> +#include <Library/ArmLib.h> +#include <Library/BaseLib.h> +#include <Library/BaseMemoryLib.h> +#include <Library/CacheMaintenanceLib.h> +#include <Library/DebugLib.h> +#include <Library/IoLib.h> +#include <Library/MemoryAllocationLib.h> +#include <Library/TimerLib.h> +#include <Library/UefiBootServicesTableLib.h> +#include <Library/UefiDriverEntryPoint.h> +#include <Library/UefiRuntimeServicesTableLib.h> +#include <Library/UncachedMemoryAllocationLib.h> +#include <Protocol/DwUsb.h> +#include <Protocol/UsbDevice.h>
+#include "DwUsbDxe.h"
+#define USB_TYPE_LENGTH 16 +#define USB_BLOCK_HIGH_SPEED_SIZE 512 +#define DATA_SIZE 32768 +#define CMD_SIZE 512 +#define MATCH_CMD_LITERAL(Cmd, Buf) (!AsciiStrnCmp (Cmd, Buf, sizeof (Cmd) - 1))
For example, this one is not a hard-coded value, and yet my comment was not addressed.
OK, I'm not going to go through and point out which bits have been addressed or not.
Please go back to my reply from 7 February and respond to the comments I make in there. We can have a discussion about items you don't think it is correct or realistic to address in the way I suggest, or where you do not understand my comments.
/ Leif
Leif,
I replied the email on Feb 7th, since I just have resources to follow this issue now.
I think that mosts of issues are resolved in v4 patch set. And I can't fix those magic number since they're also secrets to me. Because I don't have any spec on this IP.
Best Regards Haojian