Re: [Linaro-uefi] [PATCH v2 3/4] Platform/Hisilicon: move out dxe runtime lib from common file

On 02/13/2018 08:23 AM, Guo Heyi wrote:

Hi Haojian,

Dw8250SerialPortRuntimeLib actually depends on DW8250 hardware IP; if there isn't such device on Hikey, then you can't use this library instance indeed.

But I think PeiDxeDebugLibReportStatusCode should be some common code, however it depends on ReportStatusCodeLib and Status Code PEIM and Status code DXE driver. Have you added them too?

If I leave PeiDxeDebugLibReportStatusCode and move Dw8250SerialPortRuntimeLib out, I'll meet UEFI crash. It seems the debug lib is depended on serial port lib.

And I consider that Dw8250 serial port is only valid on D02. So I decide to move them out.

Best Regards Haojian