Re: [Linaro-uefi] [RFC 1/1] SBSAQemu: Initial implementation for QemuSBSA

On Fri, 21 Dec 2018 at 13:49, Radoslaw Biernacki radoslaw.biernacki@linaro.org wrote:

This patch implement a variant of ArmVirtQemu which follow SBSA spec. Initial support for nondiscoverable AHCI, VGA and single DRAM window over 32bit address space.

Using FDF to compose EFI flash images with ATF images. Flash0 (secure) is used by BL1 and FIP (BL2 + BL31). Flash1 contains EFI code and EFI variables.

For compilation ATF bl1.bin and fip.bin images are needed in workspace. Follow ATF/docs/plat/sbsa.rst to build those.

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Radoslaw Biernacki radoslaw.biernacki@linaro.org

---

Silicon/Qemu/SBSAQemuPkg.dec | 45 ++ Platform/SBSAQemu/SBSAQemu.dsc | 807 ++++++++++++++++++++ Platform/SBSAQemu/SBSAQemu.fdf | 368 +++++++++ Silicon/Qemu/Drivers/SBSAQemuPlatformDxe/SBSAQemuPlatformDxe.inf | 47 ++ Silicon/Qemu/Library/SBSANorFlashQemuLib/SBSANorFlashQemuLib.inf | 35 + Silicon/Qemu/Library/SBSAPciHostBridgeLib/SBSAPciHostBridgeLib.inf | 44 ++ Silicon/Qemu/Library/SBSAQemuLib/SBSAQemuLib.inf | 54 ++ Silicon/Qemu/Drivers/SBSAQemuPlatformDxe/SBSAQemuPlatformDxe.c | 61 ++ Silicon/Qemu/Library/SBSANorFlashQemuLib/SBSANorFlashQemuLib.c | 45 ++ Silicon/Qemu/Library/SBSAPciHostBridgeLib/SBSAPciHostBridgeLib.c | 201 +++++ Silicon/Qemu/Library/SBSAQemuLib/SBSAQemuLib.c | 148 ++++ Silicon/Qemu/Library/SBSAQemuLib/SBSAQemuMem.c | 109 +++ Silicon/Qemu/Library/SBSAQemuLib/SBSAQemuHelper.S | 63 ++ 13 files changed, 2027 insertions(+) create mode 100644 Silicon/Qemu/SBSAQemuPkg.dec create mode 100644 Platform/SBSAQemu/SBSAQemu.dsc create mode 100644 Platform/SBSAQemu/SBSAQemu.fdf create mode 100644 Silicon/Qemu/Drivers/SBSAQemuPlatformDxe/SBSAQemuPlatformDxe.inf create mode 100644 Silicon/Qemu/Library/SBSANorFlashQemuLib/SBSANorFlashQemuLib.inf create mode 100644 Silicon/Qemu/Library/SBSAPciHostBridgeLib/SBSAPciHostBridgeLib.inf create mode 100644 Silicon/Qemu/Library/SBSAQemuLib/SBSAQemuLib.inf create mode 100644 Silicon/Qemu/Drivers/SBSAQemuPlatformDxe/SBSAQemuPlatformDxe.c create mode 100644 Silicon/Qemu/Library/SBSANorFlashQemuLib/SBSANorFlashQemuLib.c create mode 100644 Silicon/Qemu/Library/SBSAPciHostBridgeLib/SBSAPciHostBridgeLib.c create mode 100644 Silicon/Qemu/Library/SBSAQemuLib/SBSAQemuLib.c create mode 100644 Silicon/Qemu/Library/SBSAQemuLib/SBSAQemuMem.c create mode 100644 Silicon/Qemu/Library/SBSAQemuLib/SBSAQemuHelper.S

diff --git a/Silicon/Qemu/SBSAQemuPkg.dec b/Silicon/Qemu/SBSAQemuPkg.dec new file mode 100644 index 0000000000..c01c741e10 --- /dev/null +++ b/Silicon/Qemu/SBSAQemuPkg.dec @@ -0,0 +1,45 @@ +#/** @file +# +# Copyright (c) 2011-2018, ARM Limited. All rights reserved. +# Copyright (c) 2015, Intel Corporation. All rights reserved.

Add Linaro

+# +# This program and the accompanying materials +# are licensed and made available under the terms and conditions of the BSD License +# which accompanies this distribution. The full text of the license may be found at +# http://opensource.org/licenses/bsd-license.php +# +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. +# +#**/

+[Defines]

• DEC_SPECIFICATION = 0x00010005

Please update to 0x0001001B (v1.27)

• PACKAGE_NAME = ArmVirtSBSAPlatformPkg

Please align the name with the filename

• PACKAGE_GUID = 8db32c5a-2821-43e2-b4ac-bc148e2b0b05
• PACKAGE_VERSION = 0.1

+################################################################################ +# +# Include Section - list of Include Paths that are provided by this package. +# Comments are used for Keywords and Module Types. +# +# Supported Module Types: +# BASE SEC PEI_CORE PEIM DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER DXE_SAL_DRIVER UEFI_DRIVER UEFI_APPLICATION +# +################################################################################ +#[Includes.common] +# Include # Root include for the package

+[LibraryClasses]

• ArmPlatformLib|Include/Library/ArmPlatformLib.h

+[Guids.common]

• gArmVirtSBSAQemuPlatformTokenSpaceGuid = { 0xaab3bea9, 0xa8e8, 0x4e76, { 0xb5, 0x3a, 0x35, 0x22, 0x11, 0xce, 0xf7, 0xf7 } }

+[PcdsFixedAtBuild.common]

• # Non discoverable devices Pcds
• gArmVirtSBSAQemuPlatformTokenSpaceGuid.PcdPlatformAHCIBase|0|UINT64|0x00000001
• gArmVirtSBSAQemuPlatformTokenSpaceGuid.PcdPlatformAHCISize|0x10000|UINT32|0x00000002

This is going to be tedious, but please use camel case for acronyms as well, i.e., Sbsa not SBSA, and Ahci not AHCI

diff --git a/Platform/SBSAQemu/SBSAQemu.dsc b/Platform/SBSAQemu/SBSAQemu.dsc new file mode 100644 index 0000000000..cc47b23152 --- /dev/null +++ b/Platform/SBSAQemu/SBSAQemu.dsc @@ -0,0 +1,807 @@ +# +# Copyright (c) 2011-2015, ARM Limited. All rights reserved. +# Copyright (c) 2014, Linaro Limited. All rights reserved.

Bump year

+# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved. +# +# This program and the accompanying materials +# are licensed and made available under the terms and conditions of the BSD License +# which accompanies this distribution. The full text of the license may be found at +# http://opensource.org/licenses/bsd-license.php +# +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. +# +#

+################################################################################ +# +# Defines Section - statements that will be processed to create a Makefile. +# +################################################################################ +[Defines]

• PLATFORM_NAME = SBSAQemu
• PLATFORM_GUID = feb0325c-b93d-4e47-8844-b832adeb9e0c
• PLATFORM_VERSION = 0.1
• DSC_SPECIFICATION = 0x00010005

0x0001001C is the latest version of the DSC spec

• OUTPUT_DIRECTORY = Build/SBSAQemu-$(ARCH)

Please drop the $ARCH

• SUPPORTED_ARCHITECTURES = AARCH64
• BUILD_TARGETS = DEBUG|RELEASE|NOOPT
• SKUID_IDENTIFIER = DEFAULT
• FLASH_DEFINITION = Platform/SBSAQemu/SBSAQemu.fdf
• #
• # Defines for default states. These can be changed on the command line.
• # -D FLAG=VALUE
• #
• DEFINE SECURE_BOOT_ENABLE = FALSE
• DEFINE HTTP_BOOT_ENABLE = FALSE

Please enable these unconditionally

• DEFINE DEBUG_PRINT_ERROR_LEVEL = 0x8000004F
• DEFINE TTY_TERMINAL = TRUE

Same here: nobody is ever going to disable this so just drop the conditionals altogether

+[BuildOptions.common.EDKII.DXE_CORE,BuildOptions.common.EDKII.DXE_DRIVER,BuildOptions.common.EDKII.UEFI_DRIVER,BuildOptions.common.EDKII.UEFI_APPLICATION]

• GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000

This is the default now for all toolchains except GCC48, so you can drop this.

+[BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER]

• GCC:*_*_ARM_DLINK_FLAGS = -z common-page-size=0x1000
• GCC:*_*_AARCH64_DLINK_FLAGS = -z common-page-size=0x10000
• RVCT:*_*_ARM_DLINK_FLAGS = --scatter $(EDK_TOOLS_PATH)/Scripts/Rvct-Align4K.sct

Drop the ARM bits here

+[LibraryClasses.common] +!if $(TARGET) == RELEASE

• DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf

+!else

• DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf

+!endif

• DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
• BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
• SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf
• BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.inf
• SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
• PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLibNull.inf
• PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
• PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
• PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
• IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicArmVirt.inf
• UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
• CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
• UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
• HobLib|ArmVirtPkg/Library/ArmVirtDxeHobLib/ArmVirtDxeHobLib.inf
• UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
• DevicePathLib|MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiDevicePathLibDevicePathProtocol.inf
• UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
• DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
• DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
• UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
• UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf
• HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
• UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
• SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
• ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
• FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf
• UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
• OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
• #
• # Ramdisk Requirements
• #
• FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
• # Allow dynamic PCDs
• #
• PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
• # use the accelerated BaseMemoryLibOptDxe by default, overrides for SEC/PEI below
• BaseMemoryLib|MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf
• # Networking Requirements
• NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
• DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf
• UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf
• IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf

+!if $(NETWORK_IP6_ENABLE) == TRUE

• TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf

+!endif +!if $(HTTP_BOOT_ENABLE) == TRUE

• HttpLib|MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.inf

+!endif

• #
• # It is not possible to prevent the ARM compiler from inserting calls to intrinsic functions.
• # This library provides the instrinsic functions such a compiler may generate calls to.
• #
• NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
• # Add support for GCC stack protector
• NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
• # ARM Architectural Libraries
• CacheMaintenanceLib|ArmPkg/Library/ArmCacheMaintenanceLib/ArmCacheMaintenanceLib.inf
• DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLib.inf
• CpuExceptionHandlerLib|ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.inf
• ArmDisassemblerLib|ArmPkg/Library/ArmDisassemblerLib/ArmDisassemblerLib.inf
• ArmGicLib|ArmPkg/Drivers/ArmGic/ArmGicLib.inf
• ArmGicArchLib|ArmPkg/Library/ArmGicArchLib/ArmGicArchLib.inf
• ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf
• ArmHvcLib|ArmPkg/Library/ArmHvcLib/ArmHvcLib.inf
• ArmGenericTimerCounterLib|ArmPkg/Library/ArmGenericTimerVirtCounterLib/ArmGenericTimerVirtCounterLib.inf
• PlatformPeiLib|ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf
• MemoryInitPeiLib|ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.inf
• ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
• # ARM PL031 RTC Driver
• RealTimeClockLib|ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf
• TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
• # ARM PL011 UART Driver
• PL011UartLib|ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf
• #
• # Uncomment (and comment out the next line) For RealView Debugger. The Standard IO window
• # in the debugger will show load and unload commands for symbols. You can cut and paste this
• # into the command window to load symbols. We should be able to use a script to do this, but
• # the version of RVD I have does not support scripts accessing system memory.
• #
• #PeCoffExtraActionLib|ArmPkg/Library/RvdPeCoffExtraActionLib/RvdPeCoffExtraActionLib.inf
• PeCoffExtraActionLib|ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.inf
• #PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoffExtraActionLibNull.inf
• DebugAgentLib|MdeModulePkg/Library/DebugAgentLibNull/DebugAgentLibNull.inf
• DebugAgentTimerLib|EmbeddedPkg/Library/DebugAgentTimerLibNull/DebugAgentTimerLibNull.inf
• # PCI Libraries
• PciLib|MdePkg/Library/BasePciLibPciExpress/BasePciLibPciExpress.inf
• PciExpressLib|MdePkg/Library/BasePciExpressLib/BasePciExpressLib.inf
• PciCapLib|OvmfPkg/Library/BasePciCapLib/BasePciCapLib.inf
• PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCapPciSegmentLib.inf
• PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.inf
• # USB Libraries
• UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
• #
• # CryptoPkg libraries needed by multiple firmware features
• #

+!if ($(SECURE_BOOT_ENABLE) == TRUE) || ($(NETWORK_IP6_ENABLE) == TRUE)

• IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
• OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
• BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf

+!endif

• #
• # Secure Boot dependencies
• #

+!if $(SECURE_BOOT_ENABLE) == TRUE

• TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf
• AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
• # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree
• PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf

+!else

• TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
• AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf

+!endif

• VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
• UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
• ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseReportStatusCodeLibNull.inf
• ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
• ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
• ArmPlatformLib|ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf
• TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
• NorFlashPlatformLib|Silicon/Qemu/Library/SBSANorFlashQemuLib/SBSANorFlashQemuLib.inf
• CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
• BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf
• PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
• CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
• FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
• PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.inf
• PciHostBridgeLib|Silicon/Qemu/Library/SBSAPciHostBridgeLib/SBSAPciHostBridgeLib.inf
• FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf

+!if $(HTTP_BOOT_ENABLE) == TRUE

• HttpLib|MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.inf

+!endif

• # Serial driver
• SerialPortLib|ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf
• PL011UartClockLib|ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.inf

+[LibraryClasses.common.SEC]

• PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
• BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
• DebugAgentLib|ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.inf
• DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf

Drop this one, it is going away.

• HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
• PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
• PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf
• MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf

+[LibraryClasses.common.PEI_CORE]

• PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf
• BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
• HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
• PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
• MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
• PeiCoreEntryPoint|MdePkg/Library/PeiCoreEntryPoint/PeiCoreEntryPoint.inf
• PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
• OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
• PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
• UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
• ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
• PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf

+[LibraryClasses.common.PEIM]

• PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf
• BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
• HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf
• PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
• MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
• PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf
• PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf
• OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
• PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
• PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf
• UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
• ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
• PeiServicesTablePointerLib|ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf
• ArmPlatformLib|Silicon/Qemu/Library/SBSAQemuLib/SBSAQemuLib.inf

+[LibraryClasses.common.DXE_CORE]

• HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf
• MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllocationLib.inf
• DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf
• ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
• UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
• PerformanceLib|MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf

+[LibraryClasses.common.DXE_DRIVER]

• SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf
• PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
• MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
• NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf

+[LibraryClasses.common.UEFI_APPLICATION]

• UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
• PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
• MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
• HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf

+[LibraryClasses.common.UEFI_DRIVER]

• UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
• ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
• PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
• MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
• UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf

+[LibraryClasses.common.DXE_RUNTIME_DRIVER]

• MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
• CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf

+!if $(TARGET) != RELEASE

• DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf

+!endif

+!if $(SECURE_BOOT_ENABLE) == TRUE

• BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf

+!endif

+[BuildOptions]

• RVCT:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG

Drop this, it is ARM only.

• GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG
• #
• # Disable deprecated APIs.
• #
• RVCT:*_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES

Same here

• GCC:*_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES

In both cases above, it means you can drop the GCC: prefix as well

+################################################################################ +# +# Pcd Section - list of all EDK II PCD Entries defined by this Platform +# +################################################################################

+[PcdsFeatureFlag.common]

• gEfiMdeModulePkgTokenSpaceGuid.PcdHiiOsRuntimeSupport|FALSE
• # Use the Vector Table location in CpuDxe. We will not copy the Vector Table at PcdCpuVectorBaseAddress
• gArmTokenSpaceGuid.PcdRelocateVectorTable|FALSE
• gEmbeddedTokenSpaceGuid.PcdPrePiProduceMemoryTypeInformationHob|TRUE
• gEfiMdeModulePkgTokenSpaceGuid.PcdTurnOffUsbLegacySupport|TRUE
• gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderPciTranslation|TRUE
• gUefiOvmfPkgTokenSpaceGuid.PcdQemuBootOrderMmioTranslation|TRUE
• ## If TRUE, Graphics Output Protocol will be installed on virtual handle created by ConsplitterDxe.
• # It could be set FALSE to save size.
• gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
• gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE

+[PcdsFeatureFlag.AARCH64]

Just drop this section header and merge with the common section above

• #
• # Activate AcpiSdtProtocol
• #
• gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE

+[PcdsFixedAtBuild.common]

• gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000
• gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000
• gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength|1000000
• gEfiMdePkgTokenSpaceGuid.PcdSpinLockTimeout|10000000
• gEfiMdePkgTokenSpaceGuid.PcdDebugClearMemoryValue|0xAF
• gEfiMdePkgTokenSpaceGuid.PcdPostCodePropertyMask|0
• gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|320
• # DEBUG_ASSERT_ENABLED 0x01
• # DEBUG_PRINT_ENABLED 0x02
• # DEBUG_CODE_ENABLED 0x04
• # CLEAR_MEMORY_ENABLED 0x08
• # ASSERT_BREAKPOINT_ENABLED 0x10
• # ASSERT_DEADLOOP_ENABLED 0x20

+!if $(TARGET) == RELEASE

• gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x21

+!else

• gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x2f

+!endif

• # DEBUG_INIT 0x00000001 // Initialization
• # DEBUG_WARN 0x00000002 // Warnings
• # DEBUG_LOAD 0x00000004 // Load events
• # DEBUG_FS 0x00000008 // EFI File system
• # DEBUG_POOL 0x00000010 // Alloc & Free (pool)
• # DEBUG_PAGE 0x00000020 // Alloc & Free (page)
• # DEBUG_INFO 0x00000040 // Informational debug messages
• # DEBUG_DISPATCH 0x00000080 // PEI/DXE/SMM Dispatchers
• # DEBUG_VARIABLE 0x00000100 // Variable
• # DEBUG_BM 0x00000400 // Boot Manager
• # DEBUG_BLKIO 0x00001000 // BlkIo Driver
• # DEBUG_NET 0x00004000 // SNP Driver
• # DEBUG_UNDI 0x00010000 // UNDI Driver
• # DEBUG_LOADFILE 0x00020000 // LoadFile
• # DEBUG_EVENT 0x00080000 // Event messages
• # DEBUG_GCD 0x00100000 // Global Coherency Database changes
• # DEBUG_CACHE 0x00200000 // Memory range cachability changes
• # DEBUG_VERBOSE 0x00400000 // Detailed debug messages that may
• # // significantly impact boot performance
• # DEBUG_ERROR 0x80000000 // Error
• gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|$(DEBUG_PRINT_ERROR_LEVEL)
• #
• # Optional feature to help prevent EFI memory map fragments
• # Turned on and off via: PcdPrePiProduceMemoryTypeInformationHob
• # Values are in EFI Pages (4K). DXE Core will make sure that
• # at least this much of each type of memory can be allocated
• # from a single memory range. This way you only end up with
• # maximum of two fragements for each type in the memory map
• # (the memory used, and the free memory that was prereserved
• # but not used).
• #
• gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory|0
• gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS|0
• gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType|0

+!if $(SECURE_BOOT_ENABLE) == TRUE

• gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesData|600
• gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesCode|400
• gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiBootServicesCode|1500

+!else

• gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesData|300
• gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesCode|150
• gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiBootServicesCode|1000

+!endif

• gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiBootServicesData|12000
• gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiLoaderCode|20
• gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiLoaderData|0

+!if $(SECURE_BOOT_ENABLE) == TRUE

• # override the default values from SecurityPkg to ensure images from all sources are verified in secure boot
• gEfiSecurityPkgTokenSpaceGuid.PcdOptionRomImageVerificationPolicy|0x04
• gEfiSecurityPkgTokenSpaceGuid.PcdFixedMediaImageVerificationPolicy|0x04
• gEfiSecurityPkgTokenSpaceGuid.PcdRemovableMediaImageVerificationPolicy|0x04

+!endif

+!if $(TTY_TERMINAL) == TRUE

• # Set terminal type to TtyTerm, the value encoded is EFI_TTY_TERM_GUID
• gArmVirtTokenSpaceGuid.PcdTerminalTypeGuidBuffer|{0x80, 0x6d, 0x91, 0x7d, 0xb1, 0x5b, 0x8c, 0x45, 0xa4, 0x8f, 0xe2, 0x5f, 0xdd, 0x51, 0xef, 0x94}

+!endif

• #
• # Enable strict image permissions for all images. (This applies
• # only to images that were built with >= 4 KB section alignment.)
• #
• gEfiMdeModulePkgTokenSpaceGuid.PcdImageProtectionPolicy|0x3
• #
• # Enable NX memory protection for all non-code regions, including OEM and OS
• # reserved ones, with the exception of LoaderData regions, of which OS loaders
• # (i.e., GRUB) may assume that its contents are executable.
• #
• gEfiMdeModulePkgTokenSpaceGuid.PcdDxeNxMemoryProtectionPolicy|0xC000000000007FD1
• #
• # Enable the non-executable DXE stack. (This gets set up by DxeIpl)
• #
• gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack|TRUE
• gArmPlatformTokenSpaceGuid.PcdCoreCount|1

+!if $(ARCH) == AARCH64

Drop this, it is implied

• gArmTokenSpaceGuid.PcdVFPEnabled|1

+!endif

• gArmPlatformTokenSpaceGuid.PcdCPUCoresStackBase|0x800007c000
• gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize|0x4000
• gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
• gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800
• # Size of the region used by UEFI in permanent memory (Reserved 64MB)
• gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x04000000
• ## Trustzone enable (to make the transition from EL3 to EL2 in ArmPlatformPkg/Sec)
• gArmTokenSpaceGuid.PcdTrustzoneSupport|FALSE

Drop this it is unused.

• #
• # ARM PrimeCell
• #
• ## Default Terminal Type
• ## 0-PCANSI, 1-VT100, 2-VT00+, 3-UTF8, 4-TTYTERM

+!if $(TTY_TERMINAL) == TRUE

• gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4

+!else

• gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|1

+!endif

• #
• # ARM Virtual Architectural Timer -- fetch frequency from QEMU (TCG) or KVM
• #
• gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|0

+!if $(HTTP_BOOT_ENABLE) == TRUE

• gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE

+!endif

• # System Memory Base -- fixed at 0x80_0000_0000
• gArmTokenSpaceGuid.PcdSystemMemoryBase|0x8000000000
• # RAD no DT
• # initial location of the device tree blob passed by QEMU -- base of DRAM
• # gArmVirtTokenSpaceGuid.PcdDeviceTreeInitialBaseAddress|0x8000000000
• gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
• gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
• #
• # The maximum physical I/O addressability of the processor, set with
• # BuildCpuHob().
• #
• gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|16
• # Non discoverable devices (AHCI,EHCI)
• gArmVirtSBSAQemuPlatformTokenSpaceGuid.PcdPlatformAHCIBase|0x09050000
• gArmVirtSBSAQemuPlatformTokenSpaceGuid.PcdPlatformAHCISize|0x00010000
• # RAD missing EHCI here
• # PL011 - Serial Terminal
• # (use of PL011SerialPortLib, SerialPortInitialize() called from ArmVirtPkg/PrePi/PrePi.c)

Drop this line

• gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x09000000
• gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|38400
• gEfiMdePkgTokenSpaceGuid.PcdUartDefaultDataBits|8
• gEfiMdePkgTokenSpaceGuid.PcdUartDefaultParity|0
• gEfiMdePkgTokenSpaceGuid.PcdUartDefaultStopBits|0
• # Timer IRQs
• # PPI #13
• gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum|29
• # PPI #14
• gArmTokenSpaceGuid.PcdArmArchTimerIntrNum|30
• # PPI #11
• gArmTokenSpaceGuid.PcdArmArchTimerVirtIntrNum|27
• # PPI #10
• gArmTokenSpaceGuid.PcdArmArchTimerHypIntrNum|26
• ## PL031 RealTimeClock
• gArmPlatformTokenSpaceGuid.PcdPL031RtcBase|0x09010000

+[PcdsFixedAtBuild.AARCH64]

Drop this section header

• # Clearing BIT0 in this PCD prevents installing a 32-bit SMBIOS entry point,
• # if the entry point version is >= 3.0. AARCH64 OSes cannot assume the
• # presence of the 32-bit entry point anyway (because many AARCH64 systems
• # don't have 32-bit addressable physical RAM), and the additional allocations
• # below 4 GB needlessly fragment the memory map. So expose the 64-bit entry
• # point only, for entry point versions >= 3.0.
• gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosEntryPointProvideMethod|0x2
• # ACPI predates the AARCH64 architecture by 5 versions, so
• # we only target OSes that support ACPI v5.0 or later
• gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
• # set PcdPciExpressBaseAddress to MAX_UINT64, which signifies that this
• # PCD and PcdPciDisableBusEnumeration have not been assigned yet
• gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0x90000000
• gArmTokenSpaceGuid.PcdPciIoTranslation|0x8fff0000
• gArmTokenSpaceGuid.PcdPciMmio32Translation|0x0
• gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0
• ## If TRUE, OvmfPkg/AcpiPlatformDxe will not wait for PCI
• # enumeration to complete before installing ACPI tables.
• gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration|FALSE

+[PcdsDynamicDefault.common]

• gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3
• # System Memory Size -- 1 MB initially, actual size will be fetched from DT
• # RAD as no DT will be used we should pass this by some other method
• gArmTokenSpaceGuid.PcdSystemMemorySize|0x08000000

Align the size with the comment

• #
• # ARM General Interrupt Controller
• #
• gArmTokenSpaceGuid.PcdGicDistributorBase|0x08000000
• gArmTokenSpaceGuid.PcdGicRedistributorsBase|0x080A0000
• # RAD GicV2 only
• gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0x0

Just drop it then

• #
• # Set video resolution for boot options
• # PlatformDxe can set the former at runtime.
• #
• gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution|800
• gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution|600
• # Set video resolution for text setup.
• gEfiMdeModulePkgTokenSpaceGuid.PcdSetupVideoHorizontalResolution|640
• gEfiMdeModulePkgTokenSpaceGuid.PcdSetupVideoVerticalResolution|480
• #
• # SMBIOS entry point version
• #
• gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosVersion|0x0300
• gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosDocRev|0x0
• gUefiOvmfPkgTokenSpaceGuid.PcdQemuSmbiosValidated|FALSE

Do we need this?

+[PcdsDynamicHii]

• gArmVirtTokenSpaceGuid.PcdForceNoAcpi|L"ForceNoAcpi"|gArmVirtVariableGuid|0x0|FALSE|NV,BS

Drop this

+################################################################################ +# +# Components Section - list of all EDK II Modules needed by this Platform +# +################################################################################

+[Components.common]

• #
• # Ramdisk support
• #
• MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
• #
• # UEFI application (Shell Embedded Boot Loader)
• #
• ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf {

• <PcdsFixedAtBuild>

•  gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
  

• }
• ShellPkg/Application/Shell/Shell.inf {

• <LibraryClasses>

•  ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
  

•  NULL|ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.inf
  

•  NULL|ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1CommandsLib.inf
  

•  NULL|ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.inf
  

•  NULL|ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.inf
  

•  NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
  

•  NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
  

•  NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
  

+!if $(NETWORK_IP6_ENABLE) == TRUE

•  NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
  

+!endif

Can you add the acpiview driver here as well please?

•  HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
  

•  PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
  

•  BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
  

• <PcdsFixedAtBuild>

•  gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0xFF
  

•  gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
  

•  gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|8000
  

• }
• #
• # PEI Phase modules
• #
• ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
• MdeModulePkg/Core/Pei/PeiMain.inf
• MdeModulePkg/Universal/PCD/Pei/Pcd.inf {

• <LibraryClasses>

•  PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
  

• }
• ArmPlatformPkg/PlatformPei/PlatformPeim.inf
• ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf
• ArmPkg/Drivers/CpuPei/CpuPei.inf
• MdeModulePkg/Universal/Variable/Pei/VariablePei.inf

You can drop this (and we should drop it from ArmVirtQemu as well) Same for the FDF

• MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf {

• <LibraryClasses>

•  NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
  

• }
• #
• # DXE
• #
• MdeModulePkg/Core/Dxe/DxeMain.inf {

• <LibraryClasses>

•  NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf
  

•  DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
  

• }
• MdeModulePkg/Universal/PCD/Dxe/Pcd.inf {

• <LibraryClasses>

•  PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
  

• }
• #
• # Architectural Protocols
• #
• ArmPkg/Drivers/CpuDxe/CpuDxe.inf
• MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf
• MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf {

• <LibraryClasses>

•  NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
  

•  # don't use unaligned CopyMem () on the UEFI varstore NOR flash region
  

•  BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
  

• }

+!if $(SECURE_BOOT_ENABLE) == TRUE

• MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf {

• <LibraryClasses>

•  NULL|SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.inf
  

• }
• SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf

+!else

• MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf

+!endif

• MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf
• MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf
• MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf
• MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf
• EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
• EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf
• MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
• MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
• MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
• MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
• MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
• MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
• ArmPkg/Drivers/ArmGic/ArmGicDxe.inf
• ArmPkg/Drivers/TimerDxe/TimerDxe.inf
• ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
• MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
• #
• # FAT filesystem + GPT/MBR partitioning
• #
• MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
• MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
• MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
• FatPkg/EnhancedFatDxe/Fat.inf
• MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf
• #
• # Bds
• #
• MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf {

• <LibraryClasses>

•  DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
  

•  PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
  

• }
• MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
• MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
• MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf
• MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
• MdeModulePkg/Logo/LogoDxe.inf
• MdeModulePkg/Application/UiApp/UiApp.inf {

• <LibraryClasses>

•  NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf
  

•  NULL|MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf
  

•  NULL|MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf
  

• }
• #
• # Networking stack
• #
• MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf
• MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf
• MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
• MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
• MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf
• MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf
• MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
• MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
• MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
• MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
• MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf

+!if $(HTTP_BOOT_ENABLE) == TRUE

• NetworkPkg/DnsDxe/DnsDxe.inf
• NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf
• NetworkPkg/HttpDxe/HttpDxe.inf
• NetworkPkg/HttpBootDxe/HttpBootDxe.inf

+!endif

• # NonDiscoverableDevices
• Silicon/Qemu/Drivers/SBSAQemuPlatformDxe/SBSAQemuPlatformDxe.inf
• MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.inf
• # IDE/AHCI Support
• OvmfPkg/SataControllerDxe/SataControllerDxe.inf
• MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
• MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
• #
• # SCSI Bus and Disk Driver
• #
• MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
• MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
• #
• # SMBIOS Support
• #
• # RAD temporaly dissabled

+#MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf { +# <LibraryClasses> +# NULL|OvmfPkg/Library/SmbiosVersionLib/DetectSmbiosVersionLib.inf +# } +# OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf

• #
• # PCI support
• #
• ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf
• MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
• MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
• #
• # Video support (VGA)
• #
• OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf

OK, so we are emulating VGA. That is fine, given that we only execute under emulation.

• #
• # USB Support
• #
• MdeModulePkg/Bus/Pci/UhciDxe/UhciDxe.inf
• MdeModulePkg/Bus/Pci/EhciDxe/EhciDxe.inf
• MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
• MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf
• MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf
• MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf

+[Components.AARCH64]

• #
• # ACPI Support
• #
• MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
• # RAD do not force dependency on EDKII_PLATFORM_HAS_ACPI_GUID by
• # PlatformHasAcpiLib.inf as we only use ACPI
• #
• # EBC support
• #
• MdeModulePkg/Universal/EbcDxe/EbcDxe.inf
• MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf
• OvmfPkg/PlatformDxe/Platform.inf

Do we need this?

diff --git a/Platform/SBSAQemu/SBSAQemu.fdf b/Platform/SBSAQemu/SBSAQemu.fdf new file mode 100644 index 0000000000..f6e4dac3e1 --- /dev/null +++ b/Platform/SBSAQemu/SBSAQemu.fdf @@ -0,0 +1,368 @@ +# +# Copyright (c) 2011-2015, ARM Limited. All rights reserved. +# Copyright (c) 2014, Linaro Limited. All rights reserved. +# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved. +# +# This program and the accompanying materials +# are licensed and made available under the terms and conditions of the BSD License +# which accompanies this distribution. The full text of the license may be found at +# http://opensource.org/licenses/bsd-license.php +# +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. +#

+################################################################################ +# +# FD Section for FLASH0 +# +# The [FD] Section is made up of the definition statements and a +# description of what goes into the Flash Device Image. Each FD section +# defines one flash "device" image. A flash device image may be one of +# the following: Removable media bootable image (like a boot floppy +# image,) an Option ROM image (that would be "flashed" into an add-in +# card,) a System "Flash" image (that would be burned into a system's +# flash) or an Update ("Capsule") image that will be used to update and +# existing system flash. +# +################################################################################

+[FD.SBSA_FLASH0] +BaseAddress = 0x00000000 +Size = 0x00200000 +ErasePolarity = 1 +# This one is tricky, it must be: BlockSize * NumBlocks = Size

Just drop that silly comment :-)

+BlockSize = 0x00001000 +NumBlocks = 0x200

+################################################################################ +# +# Following are lists of FD Region layout which correspond to the locations of different +# images within the flash device. +# +# Regions must be defined in ascending order and may not overlap. +# +# A Layout Region start with a eight digit hex offset (leading "0x" required) followed by +# the pipe "|" character, followed by the size of the region, also in hex with the leading +# "0x" characters. Like: +# Offset|Size +# PcdOffsetCName|PcdSizeCName +# RegionType <FV, DATA, or FILE> +# +################################################################################ +## Place for Trusted Firmware +# flash0 is secure so we put here the BL1 +0x00000000|0x00008000 +FILE = bl1.bin

+# and FIP (BL2 + BL31) +0x00008000|0x00020000 +FILE = fip.bin

+################################################################################ +# +# FD Section for FLASH1 +# +################################################################################

+[FD.SBSA_FLASH1] +BaseAddress = 0x04000000|gArmTokenSpaceGuid.PcdFdBaseAddress +Size = 0x002C0000|gArmTokenSpaceGuid.PcdFdSize +ErasePolarity = 1 +# This one is tricky, it must be: BlockSize * NumBlocks = Size +BlockSize = 0x00001000 +NumBlocks = 0x2C0

+## Place for EFI (BL33) +# This offset + BaseAddress (0x04000000) must be given for PRELOADED_BL33_BASE at ATF compilation +0x00000000|0x00200000 +gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize +FV = FVMAIN_COMPACT

+## Place for Variables. They share flash1 with EFI +# Must be aligned to Flash Block size 0x40000 +0x00200000|0x00040000 +gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase|gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize +#NV_VARIABLE_STORE +DATA = {

• ## This is the EFI_FIRMWARE_VOLUME_HEADER
• # ZeroVector []
• 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
• 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
• # FileSystemGuid: gEfiSystemNvDataFvGuid =
• # { 0xFFF12B8D, 0x7696, 0x4C8B,
• # { 0xA9, 0x85, 0x27, 0x47, 0x07, 0x5B, 0x4F, 0x50 }}
• 0x8D, 0x2B, 0xF1, 0xFF, 0x96, 0x76, 0x8B, 0x4C,
• 0xA9, 0x85, 0x27, 0x47, 0x07, 0x5B, 0x4F, 0x50,
• # FvLength: 0xC0000
• 0x00, 0x00, 0x0C, 0x00, 0x00, 0x00, 0x00, 0x00,
• # Signature "_FVH" # Attributes
• 0x5f, 0x46, 0x56, 0x48, 0xff, 0xfe, 0x04, 0x00,
• # HeaderLength # CheckSum # ExtHeaderOffset #Reserved #Revision
• 0x48, 0x00, 0x28, 0x09, 0x00, 0x00, 0x00, 0x02,
• # Blockmap[0]: 0x3 Blocks * 0x40000 Bytes / Block
• 0x3, 0x00, 0x00, 0x00, 0x00, 0x00, 0x04, 0x00,
• # Blockmap[1]: End
• 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
• ## This is the VARIABLE_STORE_HEADER
• # It is compatible with SECURE_BOOT_ENABLE == FALSE as well.
• # Signature: gEfiAuthenticatedVariableGuid =
• # { 0xaaf32c78, 0x947b, 0x439a,
• # { 0xa1, 0x80, 0x2e, 0x14, 0x4e, 0xc3, 0x77, 0x92 }}
• 0x78, 0x2c, 0xf3, 0xaa, 0x7b, 0x94, 0x9a, 0x43,
• 0xa1, 0x80, 0x2e, 0x14, 0x4e, 0xc3, 0x77, 0x92,
• # Size: 0x40000 (gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize) -
• # 0x48 (size of EFI_FIRMWARE_VOLUME_HEADER) = 0x3ffb8
• # This can speed up the Variable Dispatch a bit.
• 0xB8, 0xFF, 0x03, 0x00,
• # FORMATTED: 0x5A #HEALTHY: 0xFE #Reserved: UINT16 #Reserved1: UINT32
• 0x5A, 0xFE, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00

+}

+0x00240000|0x00040000 +gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase|gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize +#NV_FTW_WORKING +DATA = {

• # EFI_FAULT_TOLERANT_WORKING_BLOCK_HEADER->Signature = gEdkiiWorkingBlockSignatureGuid =
• # { 0x9e58292b, 0x7c68, 0x497d, { 0xa0, 0xce, 0x65, 0x0, 0xfd, 0x9f, 0x1b, 0x95 }}
• 0x2b, 0x29, 0x58, 0x9e, 0x68, 0x7c, 0x7d, 0x49,
• 0xa0, 0xce, 0x65, 0x0, 0xfd, 0x9f, 0x1b, 0x95,
• # Crc:UINT32 #WorkingBlockValid:1, WorkingBlockInvalid:1, Reserved
• 0x5b, 0xe7, 0xc6, 0x86, 0xFE, 0xFF, 0xFF, 0xFF,
• # WriteQueueSize: UINT64
• 0xE0, 0xFF, 0x03, 0x00, 0x00, 0x00, 0x00, 0x00

+}

+0x00280000|0x00040000 +gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize +#NV_FTW_SPARE

+################################################################################ +# +# FV Section +# +# [FV] section is used to define what components or modules are placed within a flash +# device file. This section also defines order the components and modules are positioned +# within the image. The [FV] section consists of define statements, set statements and +# module statements. +# +################################################################################

+[FV.FvMain] +FvNameGuid = 706c8e7f-306e-4dbc-a4ca-c8615d0d1b96 +BlockSize = 0x40 +NumBlocks = 0 # This FV gets compressed so make it just big enough +FvAlignment = 16 # FV alignment and FV attributes setting. +ERASE_POLARITY = 1 +MEMORY_MAPPED = TRUE +STICKY_WRITE = TRUE +LOCK_CAP = TRUE +LOCK_STATUS = TRUE +WRITE_DISABLED_CAP = TRUE +WRITE_ENABLED_CAP = TRUE +WRITE_STATUS = TRUE +WRITE_LOCK_CAP = TRUE +WRITE_LOCK_STATUS = TRUE +READ_DISABLED_CAP = TRUE +READ_ENABLED_CAP = TRUE +READ_STATUS = TRUE +READ_LOCK_CAP = TRUE +READ_LOCK_STATUS = TRUE

• INF MdeModulePkg/Core/Dxe/DxeMain.inf
• INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf
• #
• # PI DXE Drivers producing Architectural Protocols (EFI Services)
• #
• INF ArmPkg/Drivers/CpuDxe/CpuDxe.inf
• INF MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf
• INF MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
• INF MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf
• INF MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf
• INF MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf

+!if $(SECURE_BOOT_ENABLE) == TRUE

• INF SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf

+!endif

• INF MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf
• INF MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystemRuntimeDxe.inf
• INF EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
• INF EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf
• INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
• #
• # Multiple Console IO support
• #
• INF MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
• INF MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
• INF MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
• INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
• INF MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
• INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf
• INF ArmPkg/Drivers/TimerDxe/TimerDxe.inf
• INF ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.inf
• INF MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf
• #
• # FAT filesystem + GPT/MBR partitioning + UDF filesystem
• #
• INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
• INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
• INF FatPkg/EnhancedFatDxe/Fat.inf
• INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
• INF MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf
• #
• # UEFI application (Shell Embedded Boot Loader)
• #
• INF ShellPkg/Application/Shell/Shell.inf
• INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
• #
• # Bds
• #
• INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
• INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
• INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
• INF MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf
• INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
• INF MdeModulePkg/Application/UiApp/UiApp.inf
• #
• # Networking stack
• #
• INF MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf
• INF MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf
• INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
• INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
• INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf
• INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf
• INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
• INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf

+!if $(NETWORK_IP6_ENABLE) == TRUE

• INF NetworkPkg/Ip6Dxe/Ip6Dxe.inf
• INF NetworkPkg/TcpDxe/TcpDxe.inf
• INF NetworkPkg/Udp6Dxe/Udp6Dxe.inf
• INF NetworkPkg/Dhcp6Dxe/Dhcp6Dxe.inf
• INF NetworkPkg/Mtftp6Dxe/Mtftp6Dxe.inf
• INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
• INF NetworkPkg/IScsiDxe/IScsiDxe.inf

+!else

• INF MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
• INF MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
• INF MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf

+!endif +!if $(HTTP_BOOT_ENABLE) == TRUE

• INF NetworkPkg/DnsDxe/DnsDxe.inf
• INF NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf
• INF NetworkPkg/HttpDxe/HttpDxe.inf
• INF NetworkPkg/HttpBootDxe/HttpBootDxe.inf

+!endif

• #
• # SCSI Bus and Disk Driver
• #
• INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
• INF MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
• #
• # SMBIOS Support
• #
• # RAD temporarly disabled

+# INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf +# INF OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf

• #
• # ACPI Support
• #

+!if $(ARCH) == AARCH64

• INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
• INF MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf
• #
• # EBC support
• #
• INF MdeModulePkg/Universal/EbcDxe/EbcDxe.inf

+!endif

• #
• # PCI support
• #
• INF ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf
• INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
• INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
• #
• # Video support
• #
• INF OvmfPkg/PlatformDxe/Platform.inf
• #
• # USB Support
• #
• INF MdeModulePkg/Bus/Pci/UhciDxe/UhciDxe.inf
• INF MdeModulePkg/Bus/Pci/EhciDxe/EhciDxe.inf
• INF MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
• INF MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf
• INF MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf
• INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf
• #
• # TianoCore logo (splash screen)
• #
• INF MdeModulePkg/Logo/LogoDxe.inf
• #
• # Ramdisk support
• #
• INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf

+[FV.FVMAIN_COMPACT] +FvAlignment = 16 +ERASE_POLARITY = 1 +MEMORY_MAPPED = TRUE +STICKY_WRITE = TRUE +LOCK_CAP = TRUE +LOCK_STATUS = TRUE +WRITE_DISABLED_CAP = TRUE +WRITE_ENABLED_CAP = TRUE +WRITE_STATUS = TRUE +WRITE_LOCK_CAP = TRUE +WRITE_LOCK_STATUS = TRUE +READ_DISABLED_CAP = TRUE +READ_ENABLED_CAP = TRUE +READ_STATUS = TRUE +READ_LOCK_CAP = TRUE +READ_LOCK_STATUS = TRUE

• INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
• INF MdeModulePkg/Core/Pei/PeiMain.inf
• INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
• INF ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf
• INF ArmPkg/Drivers/CpuPei/CpuPei.inf
• INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf
• INF MdeModulePkg/Universal/Variable/Pei/VariablePei.inf
• INF MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
• # IDE/AHCI Support
• INF OvmfPkg/SataControllerDxe/SataControllerDxe.inf
• INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf
• INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
• INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf
• INF MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf
• # NonDiscoverableDevices
• INF Silicon/Qemu/Drivers/SBSAQemuPlatformDxe/SBSAQemuPlatformDxe.inf
• INF MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.inf
• #VGA
• INF OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf
• FILE FV_IMAGE = 9E21FD93-9C72-4c15-8C4B-E77F1DB2D792 {
• SECTION GUIDED EE4E5898-3914-4259-9D6E-DC7BD79403CF PROCESSING_REQUIRED = TRUE {

•  SECTION FV_IMAGE = FVMAIN
  

• }
• }

+!include ArmVirtPkg/ArmVirtRules.fdf.inc diff --git a/Silicon/Qemu/Drivers/SBSAQemuPlatformDxe/SBSAQemuPlatformDxe.inf b/Silicon/Qemu/Drivers/SBSAQemuPlatformDxe/SBSAQemuPlatformDxe.inf new file mode 100644 index 0000000000..dd30368c74 --- /dev/null +++ b/Silicon/Qemu/Drivers/SBSAQemuPlatformDxe/SBSAQemuPlatformDxe.inf @@ -0,0 +1,47 @@ +## @file +# This driver effectuates Qemu SBSA platform configuration settings +# +# Copyright (c) 2014 - 2016, Linaro Ltd. All rights reserved.<BR> +# +# This program and the accompanying materials are +# licensed and made available under the terms and conditions of the BSD License +# which accompanies this distribution. The full text of the license may be found at +# http://opensource.org/licenses/bsd-license.php +# +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. +# +##

+[Defines]

• INF_VERSION = 0x00010005

0x0001001c

• BASE_NAME = SBSAQemuPlatformDxe
• FILE_GUID = 6c592dc9-76c8-474f-93b2-bf1e8f15ae34
• MODULE_TYPE = DXE_DRIVER
• VERSION_STRING = 1.0
• ENTRY_POINT = InitializeSBSAQemuPlatformDxe

+[Sources]

• SBSAQemuPlatformDxe.c

+[Packages]

• EmbeddedPkg/EmbeddedPkg.dec
• MdeModulePkg/MdeModulePkg.dec
• MdePkg/MdePkg.dec
• ArmVirtPkg/ArmVirtPkg.dec
• Silicon/Qemu/SBSAQemuPkg.dec

Do you really need all of these? And please sort the ones you keep.

+[LibraryClasses]

• PcdLib
• DebugLib
• NonDiscoverableDeviceRegistrationLib
• UefiDriverEntryPoint

+[Pcd]

• gArmVirtSBSAQemuPlatformTokenSpaceGuid.PcdPlatformAHCIBase
• gArmVirtSBSAQemuPlatformTokenSpaceGuid.PcdPlatformAHCISize

+[Depex]

• TRUE

diff --git a/Silicon/Qemu/Library/SBSANorFlashQemuLib/SBSANorFlashQemuLib.inf b/Silicon/Qemu/Library/SBSANorFlashQemuLib/SBSANorFlashQemuLib.inf new file mode 100644 index 0000000000..0220983ac7 --- /dev/null +++ b/Silicon/Qemu/Library/SBSANorFlashQemuLib/SBSANorFlashQemuLib.inf @@ -0,0 +1,35 @@ +#/** @file +# +# Component description file for SBSANorFlashQemuLib module +# +# Copyright (c) 2014, Linaro Ltd. All rights reserved.<BR> +# +# This program and the accompanying materials +# are licensed and made available under the terms and conditions of the BSD License +# which accompanies this distribution. The full text of the license may be found at +# http://opensource.org/licenses/bsd-license.php +# +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. +# +#**/

+[Defines]

• INF_VERSION = 0x00010005

version

• BASE_NAME = SBSANorFlashQemuLib
• FILE_GUID = c53d904d-de50-40f1-a148-a2ece48303d8
• MODULE_TYPE = DXE_DRIVER

Use BASE for libraries without a constructor. (I know this is just copy/paste but let's get it right nonetheless)

• VERSION_STRING = 1.0
• LIBRARY_CLASS = NorFlashPlatformLib

+[Sources.common]

• SBSANorFlashQemuLib.c

+[Packages]

• MdePkg/MdePkg.dec
• ArmPlatformPkg/ArmPlatformPkg.dec
• ArmPkg/ArmPkg.dec

+[FixedPcd]

• gArmTokenSpaceGuid.PcdFdBaseAddress
• gArmTokenSpaceGuid.PcdFdSize

diff --git a/Silicon/Qemu/Library/SBSAPciHostBridgeLib/SBSAPciHostBridgeLib.inf b/Silicon/Qemu/Library/SBSAPciHostBridgeLib/SBSAPciHostBridgeLib.inf new file mode 100644 index 0000000000..667b1b4d2e --- /dev/null +++ b/Silicon/Qemu/Library/SBSAPciHostBridgeLib/SBSAPciHostBridgeLib.inf @@ -0,0 +1,44 @@ +## @file +# PCI Host Bridge Library instance for pci-ecam-generic DT nodes +# +# Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR> +# +# This program and the accompanying materials are licensed and made available +# under the terms and conditions of the BSD License which accompanies this +# distribution. The full text of the license may be found at +# http://opensource.org/licenses/bsd-license.php. +# +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR +# IMPLIED. +# +# +##

+[Defines]

• INF_VERSION = 0x00010005

version

• BASE_NAME = SBSAPciHostBridgeLib
• FILE_GUID = 151dbef1-332d-4a8f-963e-b8f6bebb891d
• MODULE_TYPE = DXE_DRIVER
• VERSION_STRING = 1.0
• LIBRARY_CLASS = PciHostBridgeLib

+# +# The following information is for reference only and not required by the build +# tools. +# +# VALID_ARCHITECTURES = AARCH64 +#

+[Sources]

• SBSAPciHostBridgeLib.c

+[Packages]

• MdeModulePkg/MdeModulePkg.dec
• MdePkg/MdePkg.dec

+[LibraryClasses]

• DebugLib

+[Depex]

• TRUE

diff --git a/Silicon/Qemu/Library/SBSAQemuLib/SBSAQemuLib.inf b/Silicon/Qemu/Library/SBSAQemuLib/SBSAQemuLib.inf new file mode 100644 index 0000000000..79c1fc1ad8 --- /dev/null +++ b/Silicon/Qemu/Library/SBSAQemuLib/SBSAQemuLib.inf @@ -0,0 +1,54 @@ +#/* @file +# +# Copyright (c) 2011-2015, ARM Limited. All rights reserved. +# Copyright (c) 2014-2017, Linaro Limited. All rights reserved. +# +# This program and the accompanying materials are licensed and made available +# under the terms and conditions of the BSD License which accompanies this +# distribution. The full text of the license may be found at +# http://opensource.org/licenses/bsd-license.php +# +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. +# +#*/

+[Defines]

• INF_VERSION = 0x0001001A
• BASE_NAME = SBSAQemuLib
• FILE_GUID = 6454006f-4236-46e2-9be4-4bba8d4b29fb
• MODULE_TYPE = BASE
• VERSION_STRING = 1.0
• LIBRARY_CLASS = ArmPlatformLib

+[Sources]

• SBSAQemuMem.c
• SBSAQemuLib.c
• SBSAQemuHelper.S

+[Packages]

• MdePkg/MdePkg.dec
• MdeModulePkg/MdeModulePkg.dec
• ArmPkg/ArmPkg.dec
• ArmPlatformPkg/ArmPlatformPkg.dec
• EmbeddedPkg/EmbeddedPkg.dec

+[LibraryClasses]

• ArmLib
• BaseMemoryLib
• DebugLib
• PcdLib
• MemoryAllocationLib

+[Pcd]

• gArmTokenSpaceGuid.PcdSystemMemoryBase
• gArmTokenSpaceGuid.PcdSystemMemorySize

+[FixedPcd]

• gArmTokenSpaceGuid.PcdFdBaseAddress
• gArmTokenSpaceGuid.PcdFdSize
• gArmTokenSpaceGuid.PcdArmPrimaryCoreMask
• gArmTokenSpaceGuid.PcdArmPrimaryCore

+[Ppis]

• gArmMpCoreInfoPpiGuid

diff --git a/Silicon/Qemu/Drivers/SBSAQemuPlatformDxe/SBSAQemuPlatformDxe.c b/Silicon/Qemu/Drivers/SBSAQemuPlatformDxe/SBSAQemuPlatformDxe.c new file mode 100644 index 0000000000..861e426051 --- /dev/null +++ b/Silicon/Qemu/Drivers/SBSAQemuPlatformDxe/SBSAQemuPlatformDxe.c @@ -0,0 +1,61 @@ +/** @file +* FDT client protocol driver for qemu,mach-virt-ahci DT node +* +* Copyright (c) 2014 - 2016, Linaro Ltd. All rights reserved.<BR> +*

bump year

+* This program and the accompanying materials are +* licensed and made available under the terms and conditions of the BSD License +* which accompanies this distribution. The full text of the license may be found at +* http://opensource.org/licenses/bsd-license.php +* +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. +* +**/

+#include <Library/BaseLib.h> +#include <Library/PcdLib.h> +#include <Library/DebugLib.h> +#include <Library/UefiBootServicesTableLib.h> +#include <Library/UefiDriverEntryPoint.h> +#include <Library/NonDiscoverableDeviceRegistrationLib.h>

+#include <Protocol/FdtClient.h>

+EFI_STATUS +EFIAPI +InitializeSBSAQemuPlatformDxe (

• IN EFI_HANDLE ImageHandle,
• IN EFI_SYSTEM_TABLE *SystemTable
• )

+{

• EFI_STATUS Status;
• UINTN Size;
• VOID* Base;
• DEBUG ((EFI_D_INFO, "%a: InitializeSBSAQemuPlatformDxe called\n", __FUNCTION__));
• Base = (VOID*)(UINTN)PcdGet64(PcdPlatformAHCIBase);

space before ( when calling a function

• ASSERT (Base != NULL);
• Size = (UINTN)PcdGet32(PcdPlatformAHCISize);

same here

• ASSERT (Size != 0);
• DEBUG ((EFI_D_INFO, "%a: Got platform AHCI %llx %u\n",

EFI_F_xxx constants are deprecated, please use DEBUG_INFO instead

•     __FUNCTION__, Base, Size));
  

• Status = RegisterNonDiscoverableMmioDevice (

•               NonDiscoverableDeviceTypeAhci,
  

•               NonDiscoverableDeviceDmaTypeCoherent,
  

•               NULL,
  

•               NULL,
  

•               1,
  

•               Base, Size);
  

• if (EFI_ERROR(Status)) {
• DEBUG((EFI_D_ERROR, "%a: NonDiscoverable: Cannot install AHCI device @%p"

Space before ( and use DEBUG_ERROR

•         "(Staus == %r)\n", __FUNCTION__, Base, Status));
  

• return Status;
• }
• return EFI_SUCCESS;

+} diff --git a/Silicon/Qemu/Library/SBSANorFlashQemuLib/SBSANorFlashQemuLib.c b/Silicon/Qemu/Library/SBSANorFlashQemuLib/SBSANorFlashQemuLib.c new file mode 100644 index 0000000000..78a2e35744 --- /dev/null +++ b/Silicon/Qemu/Library/SBSANorFlashQemuLib/SBSANorFlashQemuLib.c @@ -0,0 +1,45 @@ +/** @file

• Copyright (c) 2014, Linaro Ltd. All rights reserved.<BR>

bump year

• This program and the accompanying materials
• are licensed and made available under the terms and conditions of the BSD License
• which accompanies this distribution. The full text of the license may be found at
• http://opensource.org/licenses/bsd-license.php
• THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
• WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
• **/

+#include <Base.h> +#include <Library/NorFlashPlatformLib.h>

+#define QEMU_NOR_BLOCK_SIZE SIZE_256KB

+EFI_STATUS +NorFlashPlatformInitialization (

• VOID
• )

+{

• return EFI_SUCCESS;

+}

+NOR_FLASH_DESCRIPTION mNorFlashDevice =

STATIC

+{

• FixedPcdGet64(PcdFdBaseAddress),
• FixedPcdGet64(PcdFdBaseAddress),
• FixedPcdGet32(PcdFdSize),

spaces before (

• QEMU_NOR_BLOCK_SIZE

+};

+EFI_STATUS +NorFlashPlatformGetDevices (

• OUT NOR_FLASH_DESCRIPTION **NorFlashDescriptions,
• OUT UINT32 *Count
• )

+{

• *NorFlashDescriptions = &mNorFlashDevice;
• *Count = 1;
• return EFI_SUCCESS;

+} diff --git a/Silicon/Qemu/Library/SBSAPciHostBridgeLib/SBSAPciHostBridgeLib.c b/Silicon/Qemu/Library/SBSAPciHostBridgeLib/SBSAPciHostBridgeLib.c new file mode 100644 index 0000000000..20a3e04741 --- /dev/null +++ b/Silicon/Qemu/Library/SBSAPciHostBridgeLib/SBSAPciHostBridgeLib.c @@ -0,0 +1,201 @@ +/** @file

• PCI Host Bridge Library instance for pci-ecam-generic DT nodes
• Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>

bump year

• This program and the accompanying materials are licensed and made available
• under the terms and conditions of the BSD License which accompanies this
• distribution. The full text of the license may be found at
• http://opensource.org/licenses/bsd-license.php.
• THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
• WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
• IMPLIED.

+**/ +#include <PiDxe.h> +#include <Library/PciHostBridgeLib.h> +#include <Library/DebugLib.h> +#include <Library/DevicePathLib.h> +#include <Library/MemoryAllocationLib.h> +#include <Library/UefiBootServicesTableLib.h>

+#include <Protocol/PciRootBridgeIo.h> +#include <Protocol/PciHostBridgeResourceAllocation.h>

+#pragma pack(1) +typedef struct {

• ACPI_HID_DEVICE_PATH AcpiDevicePath;
• EFI_DEVICE_PATH_PROTOCOL EndDevicePath;

+} EFI_PCI_ROOT_BRIDGE_DEVICE_PATH; +#pragma pack ()

+STATIC EFI_PCI_ROOT_BRIDGE_DEVICE_PATH mEfiPciRootBridgeDevicePath = {

• {
• {

•  ACPI_DEVICE_PATH,
  

•  ACPI_DP,
  

•  {
  

•    (UINT8) (sizeof(ACPI_HID_DEVICE_PATH)),
  

•    (UINT8) ((sizeof(ACPI_HID_DEVICE_PATH)) >> 8)
  

•  }
  

• },
• EISA_PNP_ID(0x0A03),
• 0
• },
• {
• END_DEVICE_PATH_TYPE,
• END_ENTIRE_DEVICE_PATH_SUBTYPE,
• {

•  END_DEVICE_PATH_LENGTH,
  

•  0
  

• }
• }

+};

+GLOBAL_REMOVE_IF_UNREFERENCED +CHAR16 *mPciHostBridgeLibAcpiAddressSpaceTypeStr[] = {

• L"Mem", L"I/O", L"Bus"

+};

+STATIC PCI_ROOT_BRIDGE mRootBridge = {

• /** UINT32 Segment; Segment number */
• 0,
• /** UINT64 Supports; Supported attributes */
• EFI_PCI_ATTRIBUTE_ISA_IO_16 | EFI_PCI_ATTRIBUTE_ISA_MOTHERBOARD_IO |
• EFI_PCI_ATTRIBUTE_VGA_IO_16 | EFI_PCI_ATTRIBUTE_VGA_PALETTE_IO_16,
• /** UINT64 Attributes; Initial attributes */
• EFI_PCI_ATTRIBUTE_ISA_IO_16 | EFI_PCI_ATTRIBUTE_ISA_MOTHERBOARD_IO |
• EFI_PCI_ATTRIBUTE_VGA_IO_16 | EFI_PCI_ATTRIBUTE_VGA_PALETTE_IO_16,
• /** BOOLEAN DmaAbove4G; DMA above 4GB memory */
• TRUE,
• /** BOOLEAN NoExtendedConfigSpace; When FALSE, the root bridge supports

•      Extended (4096-byte) Configuration Space.  When TRUE, the root bridge
  

•      supports 256-byte Configuration Space only. */
  

• FALSE,
• /** BOOLEAN ResourceAssigned; Resource assignment status of the root bridge.

•      Set to TRUE if Bus/IO/MMIO resources for root bridge have been assigned */
  

• FALSE,
• /** UINT64 AllocationAttributes; Allocation attributes. */
• EFI_PCI_HOST_BRIDGE_COMBINE_MEM_PMEM |
• EFI_PCI_HOST_BRIDGE_MEM64_DECODE, /* as Mmio64Size > 0 */
• /** PCI_ROOT_BRIDGE_APERTURE Bus; Bus aperture which can be used by the root

•  bridge. */
  

• { 0, 255 }, /* ECAM size == 0x10000000 */
• /** PCI_ROOT_BRIDGE_APERTURE Io; IO aperture which can be used by the root

•           bridge, PIO_CHILD_BASE, PIO_SIZE (gArmTokenSpaceGuid.PcdPciIoTranslation
  

•           as CpuBase */
  

• { 0x0UL, 0x0UL + 0x00010000UL - 1UL },
• /** PCI_ROOT_BRIDGE_APERTURE Mem; MMIO aperture below 4GB which can be used by

•  the root bridge. MMIO32_CPU_BASE, MMIO32_SIZE
  

•           (gArmTokenSpaceGuid.PcdPciMmio32Translation as 0x0) */
  

• { 0x10000000UL, 0x10000000UL + 0x7fff0000UL - 1UL },
• /** PCI_ROOT_BRIDGE_APERTURE MemAbove4G; MMIO aperture above 4GB which can be

•  used by the root bridge. MMIO64_CPU_BASE, MMIO64_SIZE
  

•           (gArmTokenSpaceGuid.PcdPciMmio64Translation as 0x0) */
  

• { 0x100000000ULL, 0x100000000ULL + 0x7F00000000ULL - 1ULL },
• /** PCI_ROOT_BRIDGE_APERTURE PMem; Prefetchable MMIO aperture below 4GB which

•  can be used by the root bridge.
  

•  In our case, mo separate ranges for prefetchable and non-prefetchable BARs */
  

• { MAX_UINT64, 0 },
• /** PCI_ROOT_BRIDGE_APERTURE PMemAbove4G; Prefetchable MMIO aperture above 4GB

•  which can be used by the root bridge. */
  

• { MAX_UINT64, 0 },
• /** EFI_DEVICE_PATH_PROTOCOL *DevicePath; Device path. */
• (EFI_DEVICE_PATH_PROTOCOL *)&mEfiPciRootBridgeDevicePath,

I guess you tried to stay below 80 columns, but legibility is more important to me. Please two columns: one for the values and one for the comments, e.g.,

EFI_PCI_ATTRIBUTE_ISA_IO_16 | EFI_PCI_ATTRIBUTE_ISA_MOTHERBOARD_IO | EFI_PCI_ATTRIBUTE_VGA_IO_16 | EFI_PCI_ATTRIBUTE_VGA_PALETTE_IO_16, // UINT64 Attributes

+};

+/**

• Return all the root bridge instances in an array.
• @param Count Return the count of root bridge instances.
• @return All the root bridge instances in an array.

•      The array should be passed into PciHostBridgeFreeRootBridges()
  

•      when it's not used.
  

+**/ +PCI_ROOT_BRIDGE * +EFIAPI +PciHostBridgeGetRootBridges (

• UINTN *Count
• )

+{

• *Count = 1;
• return &mRootBridge;

+}

+/**

• Free the root bridge instances array returned from
• PciHostBridgeGetRootBridges().
• @param Bridges The root bridge instances array.
• @param Count The count of the array.

+**/ +VOID +EFIAPI +PciHostBridgeFreeRootBridges (

• PCI_ROOT_BRIDGE *Bridges,
• UINTN Count
• )

+{

• ASSERT (Count == 1);

+}

+/**

• Inform the platform that the resource conflict happens.
• @param HostBridgeHandle Handle of the Host Bridge.
• @param Configuration Pointer to PCI I/O and PCI memory resource

•                      descriptors. The Configuration contains the resources
  

•                      for all the root bridges. The resource for each root
  

•                      bridge is terminated with END descriptor and an
  

•                      additional END is appended indicating the end of the
  

•                      entire resources. The resource descriptor field
  

•                      values follow the description in
  

•                      EFI_PCI_HOST_BRIDGE_RESOURCE_ALLOCATION_PROTOCOL
  

•                      .SubmitResources().
  

+**/ +VOID +EFIAPI +PciHostBridgeResourceConflict (

• EFI_HANDLE HostBridgeHandle,
• VOID *Configuration
• )

+{

• EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *Descriptor;
• UINTN RootBridgeIndex;
• DEBUG ((EFI_D_ERROR, "PciHostBridge: Resource conflict happens!\n"));
• RootBridgeIndex = 0;
• Descriptor = (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *) Configuration;
• while (Descriptor->Desc == ACPI_ADDRESS_SPACE_DESCRIPTOR) {
• DEBUG ((EFI_D_ERROR, "RootBridge[%d]:\n", RootBridgeIndex++));
• for (; Descriptor->Desc == ACPI_ADDRESS_SPACE_DESCRIPTOR; Descriptor++) {

•  ASSERT (Descriptor->ResType <
  

•          (sizeof (mPciHostBridgeLibAcpiAddressSpaceTypeStr) /
  

•           sizeof (mPciHostBridgeLibAcpiAddressSpaceTypeStr[0])
  

•           )
  

•          );
  

•  DEBUG ((EFI_D_ERROR, " %s: Length/Alignment = 0x%lx / 0x%lx\n",
  

•          mPciHostBridgeLibAcpiAddressSpaceTypeStr[Descriptor->ResType],
  

•          Descriptor->AddrLen, Descriptor->AddrRangeMax
  

•          ));
  

•  if (Descriptor->ResType == ACPI_ADDRESS_SPACE_TYPE_MEM) {
  

•    DEBUG ((EFI_D_ERROR, "     Granularity/SpecificFlag = %ld / %02x%s\n",
  

•            Descriptor->AddrSpaceGranularity, Descriptor->SpecificFlag,
  

•            ((Descriptor->SpecificFlag &
  

•              EFI_ACPI_MEMORY_RESOURCE_SPECIFIC_FLAG_CACHEABLE_PREFETCHABLE
  

•              ) != 0) ? L" (Prefetchable)" : L""
  

•            ));
  

•  }
  

• }
• //
• // Skip the END descriptor for root bridge
• //
• ASSERT (Descriptor->Desc == ACPI_END_TAG_DESCRIPTOR);
• Descriptor = (EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *)(

•               (EFI_ACPI_END_TAG_DESCRIPTOR *)Descriptor + 1
  

•               );
  

• }

+} diff --git a/Silicon/Qemu/Library/SBSAQemuLib/SBSAQemuLib.c b/Silicon/Qemu/Library/SBSAQemuLib/SBSAQemuLib.c new file mode 100644 index 0000000000..038e955db5 --- /dev/null +++ b/Silicon/Qemu/Library/SBSAQemuLib/SBSAQemuLib.c @@ -0,0 +1,148 @@ +/** @file +* +* Copyright (c) 2011-2012, ARM Limited. All rights reserved. +* +* This program and the accompanying materials +* are licensed and made available under the terms and conditions of the BSD License +* which accompanies this distribution. The full text of the license may be found at +* http://opensource.org/licenses/bsd-license.php +* +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. +* +**/

+#include <Library/ArmLib.h> +#include <Library/ArmPlatformLib.h>

+#include <Ppi/ArmMpCoreInfo.h>

+ARM_CORE_INFO mArmPlatformNullMpCoreInfoTable[] = {

• {
• // Cluster 0, Core 0
• 0x0, 0x0,
• // MP Core MailBox Set/Get/Clear Addresses and Clear Value
• (EFI_PHYSICAL_ADDRESS)0,
• (EFI_PHYSICAL_ADDRESS)0,
• (EFI_PHYSICAL_ADDRESS)0,
• (UINT64)0xFFFFFFFF
• },
• {
• // Cluster 0, Core 1
• 0x0, 0x1,
• // MP Core MailBox Set/Get/Clear Addresses and Clear Value
• (EFI_PHYSICAL_ADDRESS)0,
• (EFI_PHYSICAL_ADDRESS)0,
• (EFI_PHYSICAL_ADDRESS)0,
• (UINT64)0xFFFFFFFF
• },
• {
• // Cluster 0, Core 2
• 0x0, 0x2,
• // MP Core MailBox Set/Get/Clear Addresses and Clear Value
• (EFI_PHYSICAL_ADDRESS)0,
• (EFI_PHYSICAL_ADDRESS)0,
• (EFI_PHYSICAL_ADDRESS)0,
• (UINT64)0xFFFFFFFF
• },
• {
• // Cluster 0, Core 3
• 0x0, 0x3,
• // MP Core MailBox Set/Get/Clear Addresses and Clear Value
• (EFI_PHYSICAL_ADDRESS)0,
• (EFI_PHYSICAL_ADDRESS)0,
• (EFI_PHYSICAL_ADDRESS)0,
• (UINT64)0xFFFFFFFF
• }

+};

+// This function should be better located into TimerLib implementation +RETURN_STATUS +EFIAPI +TimerConstructor (

• VOID
• )

+{

• return EFI_SUCCESS;

+}

+/**

• Return the current Boot Mode
• This function returns the boot reason on the platform

+**/ +EFI_BOOT_MODE +ArmPlatformGetBootMode (

• VOID
• )

+{

• return BOOT_WITH_FULL_CONFIGURATION;

+}

+/**

• Initialize controllers that must setup in the normal world
• This function is called by the ArmPlatformPkg/PrePi or ArmPlatformPkg/PlatformPei
• in the PEI phase.

+**/ +RETURN_STATUS +ArmPlatformInitialize (

• IN UINTN MpId
• )

+{

• if (!ArmPlatformIsPrimaryCore (MpId)) {
• return RETURN_SUCCESS;
• }
• //TODO: Implement me
• return RETURN_SUCCESS;

+}

+EFI_STATUS +PrePeiCoreGetMpCoreInfo (

• OUT UINTN *CoreCount,
• OUT ARM_CORE_INFO **ArmCoreTable
• )

+{

• if (ArmIsMpCore()) {
• *CoreCount = sizeof(mArmPlatformNullMpCoreInfoTable) / sizeof(ARM_CORE_INFO);
• *ArmCoreTable = mArmPlatformNullMpCoreInfoTable;
• return EFI_SUCCESS;
• } else {
• return EFI_UNSUPPORTED;
• }

+}

+ARM_MP_CORE_INFO_PPI mMpCoreInfoPpi = { PrePeiCoreGetMpCoreInfo };

+EFI_PEI_PPI_DESCRIPTOR gPlatformPpiTable[] = {

• {
• EFI_PEI_PPI_DESCRIPTOR_PPI,
• &gArmMpCoreInfoPpiGuid,
• &mMpCoreInfoPpi
• }

+};

+VOID +ArmPlatformGetPlatformPpiList (

• OUT UINTN *PpiListSize,
• OUT EFI_PEI_PPI_DESCRIPTOR **PpiList
• )

+{

• if (ArmIsMpCore()) {
• *PpiListSize = sizeof(gPlatformPpiTable);
• *PpiList = gPlatformPpiTable;
• } else {
• *PpiListSize = 0;
• *PpiList = NULL;
• }

+}

I think we can drop the mpcoreinfo pieces entirely, and always return an empty platform PPI list. Could you please try that?

diff --git a/Silicon/Qemu/Library/SBSAQemuLib/SBSAQemuMem.c b/Silicon/Qemu/Library/SBSAQemuLib/SBSAQemuMem.c new file mode 100644 index 0000000000..e96f39e9e4 --- /dev/null +++ b/Silicon/Qemu/Library/SBSAQemuLib/SBSAQemuMem.c @@ -0,0 +1,109 @@ +/** @file

• Copyright (c) 2014-2017, Linaro Limited. All rights reserved.

bump year

• This program and the accompanying materials are licensed and made available
• under the terms and conditions of the BSD License which accompanies this
• distribution. The full text of the license may be found at
• http://opensource.org/licenses/bsd-license.php
• THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
• WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.

+**/

+#include <Base.h> +#include <Library/ArmLib.h> +#include <Library/BaseMemoryLib.h> +#include <Library/DebugLib.h> +#include <Library/PcdLib.h> +#include <Library/MemoryAllocationLib.h>

+// Number of Virtual Memory Map Descriptors +#define MAX_VIRTUAL_MEMORY_MAP_DESCRIPTORS 4

+/**

• Return the Virtual Memory Map of your platform
• This Virtual Memory Map is used by MemoryInitPei Module to initialize the MMU
• on your platform.
• @param[out] VirtualMemoryMap Array of ARM_MEMORY_REGION_DESCRIPTOR

•                                describing a Physical-to-Virtual Memory
  

•                                mapping. This array must be ended by a
  

•                                zero-filled entry. The allocated memory
  

•                                will not be freed.
  

+**/ +VOID +ArmPlatformGetVirtualMemoryMap (

• OUT ARM_MEMORY_REGION_DESCRIPTOR **VirtualMemoryMap
• )

+{

• ARM_MEMORY_REGION_DESCRIPTOR *VirtualMemoryTable;
• //RETURN_STATUS PcdStatus;
• //
• // RAD following need to be fetch from ATF
• //
• //ASSERT (FixedPcdGet64 (PcdSystemMemoryBase) == NewBase);
• //PcdStatus = PcdSet64S (PcdSystemMemorySize, NewSize);
• //ASSERT_RETURN_ERROR (PcdStatus);
• //
• // We need to make sure that the machine we are running on has at least
• // 128 MB of memory configured, and is currently executing this binary from
• // NOR flash. This prevents a device tree image in DRAM from getting
• // clobbered when our caller installs permanent PEI RAM, before we have a
• // chance of marking its location as reserved or copy it to a freshly
• // allocated block in the permanent PEI RAM in the platform PEIM.
• //
• //ASSERT (NewSize >= SIZE_128MB);
• //ASSERT (
• // (((UINT64)PcdGet64 (PcdFdBaseAddress) +
• // (UINT64)PcdGet32 (PcdFdSize)) <= NewBase) ||
• // ((UINT64)PcdGet64 (PcdFdBaseAddress) >= (NewBase + NewSize)));

Just drop these asserts and the preceding comment

• ASSERT (VirtualMemoryMap != NULL);
• VirtualMemoryTable = AllocatePool (sizeof (ARM_MEMORY_REGION_DESCRIPTOR) *

•                                 MAX_VIRTUAL_MEMORY_MAP_DESCRIPTORS);
  

• if (VirtualMemoryTable == NULL) {
• DEBUG ((DEBUG_ERROR, "%a: Error: Failed AllocatePool()\n", __FUNCTION__));
• return;
• }

• // System DRAM
• VirtualMemoryTable[0].PhysicalBase = PcdGet64 (PcdSystemMemoryBase);
• VirtualMemoryTable[0].VirtualBase = VirtualMemoryTable[0].PhysicalBase;
• VirtualMemoryTable[0].Length = PcdGet64 (PcdSystemMemorySize);
• VirtualMemoryTable[0].Attributes = ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK;
• DEBUG ((DEBUG_INFO, "%a: Dumping System DRAM Memory Map:\n"

•  "\tPhysicalBase: 0x%lX\n"
  

•  "\tVirtualBase: 0x%lX\n"
  

•  "\tLength: 0x%lX\n",
  

•  __FUNCTION__,
  

•  VirtualMemoryTable[0].PhysicalBase,
  

•  VirtualMemoryTable[0].VirtualBase,
  

•  VirtualMemoryTable[0].Length));
  

• // Peripheral space before DRAM
• VirtualMemoryTable[1].PhysicalBase = 0x0;
• VirtualMemoryTable[1].VirtualBase = 0x0;
• VirtualMemoryTable[1].Length = VirtualMemoryTable[0].PhysicalBase;
• VirtualMemoryTable[1].Attributes = ARM_MEMORY_REGION_ATTRIBUTE_DEVICE;
• // Remap the FD region as normal executable memory
• VirtualMemoryTable[2].PhysicalBase = PcdGet64 (PcdFdBaseAddress);
• VirtualMemoryTable[2].VirtualBase = VirtualMemoryTable[2].PhysicalBase;
• VirtualMemoryTable[2].Length = FixedPcdGet32 (PcdFdSize);
• VirtualMemoryTable[2].Attributes = ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK;

Please align this with the latest QEMU changes. We no longer map page 0x0, and on this platform, we should not map secure-only ranges at all.

• // End of Table
• ZeroMem (&VirtualMemoryTable[3], sizeof (ARM_MEMORY_REGION_DESCRIPTOR));
• *VirtualMemoryMap = VirtualMemoryTable;

+} diff --git a/Silicon/Qemu/Library/SBSAQemuLib/SBSAQemuHelper.S b/Silicon/Qemu/Library/SBSAQemuLib/SBSAQemuHelper.S new file mode 100644 index 0000000000..9f7ebeee11 --- /dev/null +++ b/Silicon/Qemu/Library/SBSAQemuLib/SBSAQemuHelper.S @@ -0,0 +1,63 @@ +# +# Copyright (c) 2011-2013, ARM Limited. All rights reserved. +# Copyright (c) 2016-2017, Linaro Limited. All rights reserved. +#

bump year

+# This program and the accompanying materials +# are licensed and made available under the terms and conditions of the BSD License +# which accompanies this distribution. The full text of the license may be found at +# http://opensource.org/licenses/bsd-license.php +# +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. +# +#

+#include <AsmMacroIoLibV8.h> +#include <Library/ArmLib.h>

+ASM_FUNC(ArmPlatformPeiBootAction)

• ret

+//UINTN +//ArmPlatformGetCorePosition ( +// IN UINTN MpId +// ); +// With this function: CorePos = (ClusterId * 4) + CoreId +ASM_FUNC(ArmPlatformGetCorePosition)

• and x1, x0, #ARM_CORE_MASK
• and x0, x0, #ARM_CLUSTER_MASK
• add x0, x1, x0, LSR #6
• ret

+//UINTN +//ArmPlatformGetPrimaryCoreMpId ( +// VOID +// ); +ASM_FUNC(ArmPlatformGetPrimaryCoreMpId)

• MOV32 (w0, FixedPcdGet32 (PcdArmPrimaryCore))
• ret

+//UINTN +//ArmPlatformIsPrimaryCore ( +// IN UINTN MpId +// ); +ASM_FUNC(ArmPlatformIsPrimaryCore)

• MOV32 (w1, FixedPcdGet32 (PcdArmPrimaryCoreMask))
• and x0, x0, x1
• MOV32 (w1, FixedPcdGet32 (PcdArmPrimaryCore))
• cmp w0, w1
• mov x0, #1
• mov x1, #0
• csel x0, x0, x1, eq
• ret

+// +// Bits 0..2 of the AA64MFR0_EL1 system register encode the size of the +// physical address space support on this CPU: +// 0 == 32 bits, 1 == 36 bits, etc etc +// 6 and 7 are reserved +// +.LPARanges:

• .byte 32, 36, 40, 42, 44, 48, -1, -1

Drop this last bit: it is not referenced anywhere.

+ASM_FUNCTION_REMOVE_IF_UNREFERENCED

2.14.1