On 8 June 2015 at 19:44, Ian Campbell ian.campbell@citrix.com wrote:
On Mon, 2015-06-08 at 12:40 +0100, Ian Campbell wrote:
On Mon, 2015-06-08 at 19:28 +0800, fu.wei@linaro.org wrote:
according to Vladimir's suggestion, change the command manes and relevant code: multiboot-->xen_hypervisor module-->xen_moduleI must have missed this suggestion being made, but if the command names have changed then the 20_linux_xen script (used by update-grub and/or grub-mkconfig) will need updating to also use those names in the generated configuration on arm64 too.
The whole point of using the multiboot (v1) names was to avoid having to do the above.
I see grub-devel isn't cc-d here. I'll see if I can track down the relevant thread and reply there too.
I can't find one which I can reply to, but from the archives Vladimir said:
multiboot2 isn't. But what you implement here is not multiboot. It's xen-specific protocol. So it should be called xen_hypervisor and xen_module. It's ok to add xen_hypervisor as an alias to multiboot on x86I think he probably meant !x86 in the final sentence, or even "on arm64". Assuming that's what he meant then if that was done then 20_linux_xen could be left alone.
OK, I will post a new patchset including the fix of 20_linux_xen
Ian.