Re: [Linaro-uefi] The GRUB multiboot support patch for aarch64(V3.1)

On Wed, 2014-05-07 at 19:58 +0800, Fu Wei wrote:

+static grub_err_t +set_xen_module_type(multiboot_module_t module, int *argc, char **argv[]) +{ [...]

• } else {

•    node_info->type = module_type++;
  

•  if (module_type > XEN_MODULE_OTHER)
  

•    module_type = XEN_MODULE_OTHER;
  
  

This will, I think, cause the third and subsequent non-explicitly typed modules to automatically get assigned XEN_MODULE_XSM etc, which I think is not intended/expected by http://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions/Multiboot. The only things which should be automatically assigned are the kernel and initrd, anything else should just get the fallback compatibility string unless one is explicitly requested.

Ian.