On 2 November 2016 at 16:55, Leif Lindholm leif.lindholm@linaro.org wrote:
On Tue, Nov 01, 2016 at 07:27:14PM +0000, Ard Biesheuvel wrote:
On 1 November 2016 at 17:25, Ard Biesheuvel ard.biesheuvel@linaro.org wrote:
Enable the second AHCI ACPI node when any ports are enabled on the second SATA controller.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org
With the following hunk folded in, both SATA controllers are detected correctly under Linux using ACPI as well as DT.
diff --git a/Platforms/AMD/Styx/AcpiTables/Dsdt.asl b/Platforms/AMD/Styx/AcpiTables/Dsdt.asl index 4e80e4e59547..7edec3d1ec28 100644 --- a/Platforms/AMD/Styx/AcpiTables/Dsdt.asl +++ b/Platforms/AMD/Styx/AcpiTables/Dsdt.asl @@ -130,7 +130,7 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "AMDINC", "SEATTLE ", 3) 0xE000007C, // Address Base (SGPIO) 0x00000001, // Address Length )
Interrupt (ResourceConsumer, Level, ActiveHigh,Exclusive, ,, ) {0x00000189, }
Interrupt (ResourceConsumer, Level, ActiveHigh,Exclusive, ,, ) {0x00000182, } }) }
Do you want to fold this into 6/8 or submit separately? It looks like a bugfix on current tables that is independent of the changes in the Pci/Ahci sets.
It makes sense to keep it separate, although it currently requires the preprocessor symbol DO_SATA1 to be defined, which we never do, so it does not matter much in practice.