ok, I will delete PciPerfTuning() function and related Pcds.
-----邮件原件----- 发件人: Leif Lindholm [mailto:leif.lindholm@linaro.org] 发送时间: 2017年9月21日 21:08 收件人: Heyi Guo heyi.guo@linaro.org 抄送: linaro-uefi@lists.linaro.org; edk2-devel@lists.01.org; graeme.gregory@linaro.org; ard.biesheuvel@linaro.org; Guoheyi guoheyi@huawei.com; wanghuiqiang wanghuiqiang@huawei.com; Huangming (Mark) huangming23@huawei.com; zhangjinsong (A) zhangjinsong2@huawei.com; waip23@126.com; Chenhui Sun chenhui.sun@linaro.org 主题: Re: [PATCH edk2-platforms v3 08/11] Hisilicon/D03: Disable the function of PerfTuning
On Thu, Sep 21, 2017 at 06:59:54PM +0800, Heyi Guo wrote:
From: Chenhui Sun chenhui.sun@linaro.org
The PerTuning function is not stable, it will cause the 3008/3108 crash, disable this function first.
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chenhui Sun chenhui.sun@linaro.org
I do not see any of my comments from previous revision addressed, and I received no reply. Feedback was: --- Should this not also delete the PciPerfTuning() function from PcieInitLib.c, and the declaration of gHisiTokenSpaceGuid.PcdIsPciPerfTuningEnable from HisiPkg.dec? ---
/ Leif
Platform/Hisilicon/D03/D03.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc index fca6781..ac880d9 100644 --- a/Platform/Hisilicon/D03/D03.dsc +++ b/Platform/Hisilicon/D03/D03.dsc @@ -112,7 +112,7 @@ # It could be set FALSE to save size. gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE gHisiTokenSpaceGuid.PcdIsItsSupported|TRUE
- gHisiTokenSpaceGuid.PcdIsPciPerfTuningEnable|TRUE
- gHisiTokenSpaceGuid.PcdIsPciPerfTuningEnable|FALSE
[PcdsFixedAtBuild.common] gEmbeddedTokenSpaceGuid.PcdEmbeddedPrompt|"D03" -- 1.9.1