On Wed, Feb 03, 2016 at 05:29:58PM +0000, Carsey, Jaben wrote:
-----Original Message----- From: Ryan Harkin [mailto:ryan.harkin@linaro.org] Sent: Wednesday, February 03, 2016 9:25 AM To: Carsey, Jaben jaben.carsey@intel.com Cc: edk2-devel@ml01.01.org; linaro-uefi@lists.linaro.org; Leif Lindholm leif.lindholm@linaro.org; Justen, Jordan L jordan.l.justen@intel.com; Ard Biesheuvel ard.biesheuvel@linaro.org Subject: Re: [edk2] [PATCH v2 6/6] Revert "ArmPlatformPkg: Create an ARM Platform DSC / FDF / ArmPlatformLib template" Importance: High
On 3 February 2016 at 17:20, Carsey, Jaben jaben.carsey@intel.com wrote:
Change looks good.
Question - Is there a way to optimize the patch/email for this type of change
so that we do not see the "diff" for a file that is deleted? It seems redundant to show a whole file of "-" lines...
That's a good question. I remember Ard discussing this previously. I'll see if I can find the discussion...
Thanks! That would be good.
The worst example is the patch with a delete and then some code change (probably should be a series).
You can tell this from the start of the diff for each file:
--- a/ArmPlatformPkg/ArmPlatformPkg-2ndstage.dsc +++ /dev/null ,
And also from the diffstat (if all '-' signs next to a file, nothing was added, if anything was added, you'll see '+' also).
ArmPlatformPkg/ArmPlatformPkg-2ndstage.dsc | 382 ------------------ ArmPlatformPkg/ArmPlatformPkg-2ndstage.fdf | 263 ------------ ArmPlatformPkg/ArmPlatformPkg.dsc | 445 --------------------- ArmPlatformPkg/ArmPlatformPkg.fdf | 320 --------------- .../ArmPlatformLibNull/ArmPlatformLibNull.c | 162 -------- .../ArmPlatformLibNull/ArmPlatformLibNull.inf | 51 --- .../ArmPlatformLibNull/ArmPlatformLibNullMem.c | 34 -- .../ArmPlatformLibNull/ArmPlatformLibNullSec.inf | 47 ---
And, yes, it should :)
/ Leif
-----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ryan Harkin Sent: Wednesday, February 03, 2016 9:10 AM To: edk2-devel@ml01.01.org; linaro-uefi@lists.linaro.org; Leif Lindholm leif.lindholm@linaro.org Cc: Ryan Harkin ryan.harkin@linaro.org; Ard Biesheuvel ard.biesheuvel@linaro.org Subject: [edk2] [PATCH v2 6/6] Revert "ArmPlatformPkg: Create an ARM Platform DSC / FDF / ArmPlatformLib template" Importance: High
This reverts commit 12fcdcb83d8e91cb730db9252189269467b9ed73
The files added by the commit have never been used. In the intervening years since they've been added, ~30 patches have been submitted to update them.
Remove them as part of a general cleanup of ArmPlatformPkg.
Signed-off-by: Ryan Harkin ryan.harkin@linaro.org
ArmPlatformPkg/ArmPlatformPkg-2ndstage.dsc | 382 ------------------ ArmPlatformPkg/ArmPlatformPkg-2ndstage.fdf | 263 ------------ ArmPlatformPkg/ArmPlatformPkg.dsc | 445 --------------------- ArmPlatformPkg/ArmPlatformPkg.fdf | 320 --------------- .../ArmPlatformLibNull/ArmPlatformLibNull.c | 162 -------- .../ArmPlatformLibNull/ArmPlatformLibNull.inf | 51 --- .../ArmPlatformLibNull/ArmPlatformLibNullMem.c | 34 -- .../ArmPlatformLibNull/ArmPlatformLibNullSec.inf | 47 --- 8 files changed, 1704 deletions(-)