Re: [Linaro-uefi] [PATCH edk2-platforms v2 35/43] Silicon/Hisilicon/D06: Add some Lpc macro to LpcLib.h

On Thu, Aug 23, 2018 at 03:39:57PM +0800, Ming wrote:

On 8/22/2018 11:33 PM, Leif Lindholm wrote:

...

On Tue, Aug 14, 2018 at 04:08:55PM +0800, Ming Huang wrote:

...

Add some Lpc macro to LpcLib.h for D06.

Unaddressed feedback from v1:

I have no issue with this patch, but can you explain when these macros are intended to be used? And if in this set, move this patch immediately before the patch than needs it?

These macros are not used in edk2-platforms, used in HwPkg/LpcLib.

Then why are they not in HwPkg?

/ Leif