Hi Leif,
Thanks, I have already found and fixed "maybe-uninitialized" issues. I want to send those and other fixes in v2.
Regards, Jan
2016-04-05 14:34 GMT+02:00 Leif Lindholm leif.lindholm@linaro.org:
Hi Jan,
On Fri, Apr 01, 2016 at 05:13:20PM +0200, Jan Dąbroś wrote:
Hi Leif,
I came back to our upstream process.
Splendid, I came back from holiday :)
- I get several build breakages due to "may be used uninitalized" type situations - both with GCC and CLANG.
- Could you manually enable -Wno-maybe-uninitialized (GCC) or -Wsometimes-uninitialized (CLANG) and clean up these instances? (Add to end of DEFINE GCC_AARCH64_CC_FLAGS line in EDK2 BaseTools/Conf/tools_def.template, then do a git clean -fx in edk2/Conf before rebuilding.)
- Needs to be resolved for MvI2cDxe.c and MvEeprom.c.
- Drivers/Spi/SpiDxe.inf is lacking an explicit dependency on IoLib, causing a build failure.
I upgraded toolchain to gcc-linaro-5.3-2016.02-x86_64_aarch64-linux-gnu/bin/aarch64-linux-gnu-. Then added "-Wmaybe-uninitialized" flag to tools_def.template (and did git clean) just in case. Unfortunately I still didn't have any errors, and cannot fix those issues. Following commands were done:
- source edksetup.sh
- export GCC49_AARCH64_PREFIX=/opt/gcc-linaro-5.3-2016.02-x86_64_aarch64-linux-gnu/bin/aarch64-linux-gnu-
- build -a AARCH64 -t GCC49 -b DEBUG -p
OpenPlatformPkg/Platforms/Marvell/Armada/Armada7040_rz.dsc
Can you tell me, what is your toolchain and if you perform any extra steps, which I didn't mention above?
The DEBUG build works for me as well, but the RELEASE build fails also with the toolchain you have now upgraded to.
-Wmaybe-uninitialized no longer needs to be added for this with a more up to date toolchain.
The build command line generated by my uefi-build.sh for this is:
GCC49_AARCH64_PREFIX=aarch64-linux-gnu- build -n 9 -a AARCH64 -t GCC49 -p OpenPlatformPkg/Platforms/Marvell/Armada/Armada7040_rz.dsc -b RELEASE
Regards,
Leif