Re: [Linaro-uefi] [PATCH v6 1/4] i386, xen: Add xen_hypervisor and xen_module aliases for i386

On Tue, Jul 26, 2016 at 05:13:40PM +0800, fu.wei@linaro.org wrote:

From: Fu Wei fu.wei@linaro.org

Signed-off-by: Fu Wei fu.wei@linaro.org

grub-core/loader/i386/xen.c | 7 +++++++ 1 file changed, 7 insertions(+)

diff --git a/grub-core/loader/i386/xen.c b/grub-core/loader/i386/xen.c index c4d9689..15b0727 100644 --- a/grub-core/loader/i386/xen.c +++ b/grub-core/loader/i386/xen.c @@ -689,6 +689,7 @@ fail: }

static grub_command_t cmd_xen, cmd_initrd, cmd_module, cmd_multiboot; +static grub_command_t cmd_xen_hypervisor, cmd_xen_module;

GRUB_MOD_INIT (xen) { @@ -696,10 +697,14 @@ GRUB_MOD_INIT (xen) 0, N_("Load Linux.")); cmd_multiboot = grub_register_command ("multiboot", grub_cmd_xen, 0, N_("Load Linux."));

• cmd_xen_hypervisor = grub_register_command ("xen_hypervisor", grub_cmd_xen,

• 			      0, N_("Load Linux."));
  

  cmd_initrd = grub_register_command ("initrd", grub_cmd_initrd, 0, N_("Load initrd.")); cmd_module = grub_register_command ("module", grub_cmd_module, 0, N_("Load module."));
• cmd_xen_module = grub_register_command ("xen_module", grub_cmd_module,

• 		      0, N_("Load module."));
  

  my_mod = mod;

}

@@ -709,4 +714,6 @@ GRUB_MOD_FINI (xen) grub_unregister_command (cmd_initrd); grub_unregister_command (cmd_multiboot); grub_unregister_command (cmd_module);

• grub_unregister_command (cmd_xen_module);
• grub_unregister_command (cmd_xen_hypervisor);

Hmmm... This whole patch does not make sense for me. Why are you adding aliases for ARM Xen hypervisor et consortes load commands (AIUI) in i386 PV guest loader?

Daniel