Hi,
I submit a second version of a patchset with the ComPhy library upgrade. v1 was thoruoghly cleaned-up, so that every remark could be answered - it occurred to be quite huge amount of work:) Anyway, now the code looks more like a proper edk2 one, without redundancies, etc. The details can be found in a changelog below.
The commits are also available in the github: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/opp-... Under the tag one can also find an initial version of 10G link support in Pp2Dxe driver, which allowed to validate SFI ComPhy. It will be submitted soon, along with other network changes.
Any remarks or comments will be very welcome.
Best regards, Marcin
Changelog: v1 -> v2 * Improve commit message in first patch * Split first patch to three new: - Fix lane assignment - Rename to KR to SFI - Update .dsc to the newest changes around serdes * Add 'Reviewed-by' in patch 4 * Remove redundancy in Gx_SETy registers description - use common offsets and masks, improve naming * Improve comments * Use Mmio... functions instead of custom ones * Make setting parameters more readable * Last patch - rename PCD, clean-up whitespaces, fix comment.
Marcin Wojtas (8): Platforms/Marvell: ComPhyLib: Cleanup and fix SerDes lanes assignment Platforms/Marvell: ComPhyLib: Rename KR to SFI Platforms/Marvell: Update SerDes types on A70x0 development board Platforms/Marvell: ComPhyLib: Mark failing lane as unconnected Platforms/Marvell: ComPhyLib: Configure analog parameters for SATA Platforms/Marvell: ComPhyLib: Configure analog parameters for PCIE Platforms/Marvell: ComPhyLib: Add missing SFI and RXAUI configuration Platforms/Marvell: ComPhyLib: Move devices description to MvHwDescLib
Documentation/Marvell/PortingGuide/ComPhy.txt | 64 +- Platforms/Marvell/Armada/Armada70x0.dsc | 13 +- Platforms/Marvell/Include/Library/MvComPhyLib.h | 5 + Platforms/Marvell/Include/Library/MvHwDescLib.h | 38 + Platforms/Marvell/Library/ComPhyLib/ComPhyCp110.c | 851 +++++++++++++++++++++- Platforms/Marvell/Library/ComPhyLib/ComPhyLib.c | 97 ++- Platforms/Marvell/Library/ComPhyLib/ComPhyLib.h | 273 +++++-- Platforms/Marvell/Library/ComPhyLib/ComPhyLib.inf | 26 +- Platforms/Marvell/Marvell.dec | 28 +- 9 files changed, 1174 insertions(+), 221 deletions(-)