Question about the platform rather than the patch: Does it have fixed RAM configuration, or DIMM sockets? (Code suggests fixed.)
Yes, this platform has fixed RAM configuration.
diff --git a/Platforms/Marvell/Armada/Library/Armada7040Lib/AArch64/ArmPlatformHelper.S b/Platforms/Marvell/Armada/Library/Armada7040Lib/AArch64/ArmPlatformHelper.S new file mode 100644 index 0000000..8c099b4 --- /dev/null +++ b/Platforms/Marvell/Armada/Library/Armada7040Lib/AArch64/ArmPlatformHelper.S @@ -0,0 +1,65 @@ +// +// Copyright (c) 2012-2013, ARM Limited. All rights reserved.
I presume this is based off of ArmPlatformLibNull? If so, when including the copyright statement, would you mind mentioning the original source file? I would be even happier if the license message wrapped at 80 characters. Also, there should probably be a Marvell copyright added.
(Consider this a global comment rather than me repeating it for every copyright/license header in the set :)
It is based on ArmPlatformLibNull - proper entry about file used for reference will be added.
+// Needs to be declared in the file. Otherwise gArmMpCoreInfoPpiGuid is undefined in the contect of PrePeiCore
Should this not be resolved by adding
[Ppis] gArmMpCoreInfoPpiGuid
to the .inf instead?
Indeed.