On Wed, May 24, 2017 at 01:51:46PM +0100, achin.gupta@arm.com wrote:
From: Achin Gupta achin.gupta@arm.com
This patch ensures that the SCP_BL2 flag is exported only if the platform is not the FVP. This flag is always set for ARM TF versions greater than 1. If included in the FVP build, it cause the FIP generation to fail since SCP_BL2 points to a directory (no BL30) instead of a file.
Signed-off-by: Achin Gupta achin.gupta@arm.com
atf-build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/atf-build.sh b/atf-build.sh index 4d6afa0..15168c0 100755 --- a/atf-build.sh +++ b/atf-build.sh @@ -145,7 +145,7 @@ function build_platform export BL30 BL31 BL32 BL33 echo "BL30=$BL30"
- if [ $ATF_BUILDVER -gt 1 ]; then
- if [ $ATF_BUILDVER -gt 1 ] && [ X"$ATF_PLATFORM" != X"fvp" ]; then
Hmm, I'm not a fan of hardcoding platform names into the scripts. Everything else is configuration file driven. If the problem is BL30 being empty (and this is valid), would not a better fix be to check for this?
Like:
if [ $ATF_BUILDVER -gt 1 -a X"$BL30" != X"" ]; then
?
export SCP_BL2 echo "SCP_BL2=$BL30"fi
1.9.1