Re: [Linaro-uefi] [Xen-devel] [PATCH v3] xen/arm64: check XSM Magic and Signature from the second unknown module.

Hi Jan

On 29 March 2016 at 17:56, Jan Beulich JBeulich@suse.com wrote:

...

...

...

On 29.03.16 at 05:26, fu.wei@linaro.org wrote:

+static bool __init check_xsm_signature(const void *fdt, int node,

•                                   const char *name,
  

•                                   u32 address_cells, u32 size_cells)
  

+{ +#ifdef CONFIG_FLASK

• u32 xen_magic = XSM_MAGIC, target_len = 8;
• const struct fdt_property *prop;
• unsigned char buff[16];
• paddr_t start, size;
• const __be32 *cell;
• int len;
• prop = fdt_get_property(fdt, node, "reg", &len);
• if ( !prop || len < dt_cells_to_size(address_cells + size_cells))

At the very least you'll need to adjust style: There's a missing blank before the closing parenthesis here, and more of this kind of issue follow later.

Ah, sorry, will fix it. Thanks ! ;-)

Jan