On Thu, Jan 18, 2018 at 11:02:42PM +0800, Heyi Guo wrote:
Code can also be found in github: https://github.com/hisilicon/OpenPlatformPkg.git branch: rp-1802-osi-v1
*** BLURB HERE ***
I'm happy with the layout this set, but I would have preferred if this cover-letter instead of "*** BLURB HERE ***" pointed out explicitly the ordering requirements with regards to the edk2-platforms set.
However, since we don't have any source code to help guide us in what changes have been implemented, the individual commit messages for each patch need to be more detailed - I will comment on those separately.
/ Leif
Heyi Guo (2): Hisilicon D0x: Fix network interface order issue Hisilicon D0x: Move SnpPlatform to edk2-platforms.
Jason Zhang (1): Hisilicon D03/D05: Move SasPlatform to edk2-platforms
Platform/Hisilicon/D03/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 26688 -> 26592 bytes Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3040 -> 0 bytes Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf | 24 -------------------- Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi | Bin 3040 -> 0 bytes Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf | 24 -------------------- Platform/Hisilicon/D05/Drivers/Net/SnpPV600Dxe/SnpPV600Dxe.efi | Bin 28544 -> 28448 bytes Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi | Bin 3392 -> 0 bytes Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf | 24 -------------------- Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi | Bin 3424 -> 0 bytes Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf | 24 -------------------- 10 files changed, 96 deletions(-) delete mode 100644 Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.efi delete mode 100644 Platform/Hisilicon/D03/Drivers/Net/SnpPlatform/SnpPlatform.inf delete mode 100644 Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.efi delete mode 100644 Platform/Hisilicon/D03/Drivers/SasPlatform/SasPlatform.inf delete mode 100644 Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.efi delete mode 100644 Platform/Hisilicon/D05/Drivers/Net/SnpPlatform/SnpPlatform.inf delete mode 100644 Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.efi delete mode 100644 Platform/Hisilicon/D05/Drivers/SasPlatform/SasPlatform.inf
-- 1.9.1