On 06/06/2014 06:55 PM, Ian Campbell wrote:
On Fri, 2014-06-06 at 17:12 +0800, Fu Wei wrote:
if (retval <(int) sizeof("module@")) return (grub_error(GRUB_ERR_BAD_OS, N_("failed to set node name for module")));
module_node = grub_fdt_find_subnode (multiboot_fdt, chosen_node, module_name); if (module_node < 0) module_node = grub_fdt_add_subnode (multiboot_fdt, chosen_node, module_name);
These "XEN_MODULE_*_NAME"s is just for the named list I used in multiboot.c/multiboot.h. It's easy to get a module node in the named list by "name".
My mistake. So it's just for debug output then I think? Seems reasonable.
it's not just for debug. this is a element of the named list data structure. this make multiboot.c can easily get a module/kernel node in the list.
I see now that it is used as part of the uniqueness check of the kernel module. As mentioned elsewhere I don't think this should be enforced by grub, in which case I think these names are no longer needed either.
Also be used here : finalize_params_multiboot (void), not just for the uniqueness check
Ian.