On Fri, Jun 5, 2015 at 2:31 AM, Ard Biesheuvel ard.biesheuvel@linaro.org wrote:
On 5 June 2015 at 06:03, Roy Franz roy.franz@linaro.org wrote:
On Thu, May 14, 2015 at 1:57 PM, Kinney, Michael D michael.d.kinney@intel.com wrote:
Roy,
- New GUID should be defined in MdeModulePkg/MdeModulePkg.dec
- New include file for new GUID in MdeModulePkg/Include/Guid
- Update TerminalDxe to use this new GUID.
I do not recommend creating a new terminal driver. Please continue as you have which is adding support for this one new terminal type to MdeModulePkg/Universal/Console/TerminalDxe.
Best regards,
Mike
OK, I have made the above changes, and have it working with one hack I'm not sure how to properly resolve.
I now have gEfiTtyTermGuid declared (extern) in MdeModulePkg/Include/Guid/TtyTerm.h, and defined in MdeModulePkg/Universal/Console/TerminalDxe/Tty.c.
I use gEfiTtyTermGuid in DevicePathFromText.c in MdePkg to convert between a text path to a device path, but I don't see how to include TtyTerm.h in DevicePathFromText.c. Right now I just have added the extern to DevicePathFromText.c to verify functionality. This works, but is obviously not the right solution. How should I go about properly getting gEfiTtyTermGuid declared in DevicePathFromText.c?
You should not define the GUID yourself, you should add it to the appropriate .dec file, If you then depend on that package and guid in a module's .inf, the definition will be emitted implicitly by the build tools.
Thanks Ard.
OK, got rid of the bogus Tty.c. I already had the GUID (also) defined in the MdeModulePkg.dec, and the gEfiTtyTermGuid in the [Guid] section of the UefiDevicePathLib.inf. What I am missing is the declaring the dependency of UefiDevicePathLib on the MdeModulePackage, and I don't know how to add that. TerminalDxe isn't under the Library directory, and doesn't have a "LIBRARY_CLASS" in its .inf file, and all the examples of dependencies that I have found seem to rely on that. My somewhat vague understanding of the ED2 build system has hit its limit.
Thanks, Roy
-- Ard.