On 18 January 2016 at 15:11, Ard Biesheuvel ard.biesheuvel@linaro.org wrote:
On 18 January 2016 at 16:08, Ryan Harkin ryan.harkin@linaro.org wrote:
On 18 January 2016 at 14:39, Ard Biesheuvel ard.biesheuvel@linaro.org wrote:
On 18 January 2016 at 15:29, Ryan Harkin ryan.harkin@linaro.org wrote:
ARM Ltd Platform support is migrating to use OpenPlatformPkg [1].
Currently, Juno and FVP exist both in EDK2's ArmPlatformPkg and in OpenPlatformPkg. And they are starting to diverge, with OpenPlatformPkg being the most up-to-date with current developments. To prevent this divergence, remove the .dsc and .fdf files from ArmPlatformPkg and leave OpenPlatformPkg as the master.
We can't remove ArmJuno.dec yet because ACPI still uses it to set the include path to ArmPlatform.h.
[PATCH 1/2] ArmPlatformPkg: remove ArmVExpress-FVP-AArch64 [PATCH 2/2] ArmPlatformPkg: remove ArmJuno.dsc/fdf
ArmPlatformPkg/ArmJunoPkg/ArmJuno.dsc | 291 ----------------------------------------------------------------------- ArmPlatformPkg/ArmJunoPkg/ArmJuno.fdf | 365 ----------------------------------------------------------------------------------------- ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-FVP-AArch64.dsc | 317 ----------------------------------------------------------------------------- ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-FVP-AArch64.fdf | 401 --------------------------------------------------------------------------------------------------
Shouldn't we sync OpenPlatformPkg with the latest EDK2 versions first?
Ooops.
I wasn't aware of any changes in the EDK2 versions that we need to carry over. From what I can see, there are changes in OpenPlatformPkg that are not in EDK2, but not the other way round, except this change:
660aaec 2015-12-15 ArmVExpressPkg/ArmVExpress-FVP-AArch64: run GICv3 in v3 mode [Ard Biesheuvel]
The ARM Landing Team (that'll be me!) ships GICv2 .dts files for the FVP models and we don't have a plan to change to running with GICv3, except in legacy mode. So I'd revert that change anyway until I was ready to support GICv3 properly.
In that case, could we please leave FVP in? Unlike OpenPlatformPkg, EDK2 is a reference implementation, i.e., someone looking to implement something for his own platform containing a GICv3 should have a reference that makes sense,
I don't think that's a good approach either. I could make GICv2/3 a build option in OpenPlatformPkg. I'd even concede to making GICv3 the default and change my own build scripts & CI jobs to use legacy mode, despite...
and not some bodge that happens to work because you guys are only interested in GICv2 mode anyway.
Well, that's not a very nice way to put it :-P We supported FVP before GICv3 was working, so we had to use GICv2. We don't had the capacity to make and test the changes needed to support GICv3.