On Mon, Jan 22, 2018 at 01:53:18PM +0000, Leif Lindholm wrote:
diff --git a/Silicon/Hisilicon/Hi1616/Pptt/Pptt.inf b/Silicon/Hisilicon/Hi1616/Pptt/Pptt.inf new file mode 100644 index 0000000..ce26b97 --- /dev/null +++ b/Silicon/Hisilicon/Hi1616/Pptt/Pptt.inf @@ -0,0 +1,55 @@ +/** @file +* +* Copyright (c) 2017, Hisilicon Limited. All rights reserved. +* Copyright (c) 2017, Linaro Limited. All rights reserved.
2018?
+* +* This program and the accompanying materials +* are licensed and made available under the terms and conditions of the BSD License +* which accompanies this distribution. The full text of the license may be found at +* http://opensource.org/licenses/bsd-license.php +* +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. +* +* Based on the files under ArmPlatformPkg/ArmJunoPkg/AcpiTables/
Platform/ARM/JunoPkg/AcpiTables.
+* +**/
+[Defines]
- INF_VERSION = 0x00010005
A new .inf should probably claim 0x00010020.
WARNING: extended periods of non-work may adversely affect your hexadecimal arithmetic skills.
Clearly this should say 0x0001001a for 1.26. (Thanks, Ard.)
/ Leif
- BASE_NAME = AcpiPptt
- FILE_GUID = AAB14F90-DC2E-4f33-A594-C7894A5B412D
- MODULE_TYPE = DXE_DRIVER
- VERSION_STRING = 1.0
- ENTRY_POINT = PpttEntryPoint
+[Sources.common]
- Pptt.c
- Pptt.h
+[Packages]
- MdePkg/MdePkg.dec
- edk2-platforms/Silicon/Hisilicon/HisiPkg.dec
This is incorrect - path resolution should be using PACKAGES_PATH and refer only to Silicon/Hisilicon/HisiPkg.dec.
- ArmPkg/ArmPkg.dec
Please sort these alphabetically.
+[LibraryClasses]
- ArmLib
- HobLib
- UefiRuntimeServicesTableLib
- UefiDriverEntryPoint
- BaseMemoryLib
- DebugLib
Please sort these alphabetically.
+[Guids]
+[Protocols]
- gEfiAcpiTableProtocolGuid # PROTOCOL ALWAYS_CONSUMED
- gEfiAcpiSdtProtocolGuid
Please sort these alphabetically (where there is not a more logical grouping available).
/ Leif
+[Pcd]
+[Depex]
- gEfiAcpiTableProtocolGuid AND gEfiAcpiSdtProtocolGuid
-- 1.9.1