On 30 March 2016 at 23:16, Laszlo Ersek lersek@redhat.com wrote:
On 03/30/16 16:23, Ard Biesheuvel wrote:
On 30 March 2016 at 16:18, Ryan Harkin ryan.harkin@linaro.org wrote:
The upstream code uses a PCD to set the FIFO depth:
f423d76 2016-03-17 MdeModulePkg/SerialDxe: Set FIFO depth with PCD
Add a sensible default for the PCD before the code becomes more widely used.
The PL011UartInitializePort function in the PL011 driver expects the receive FIFO depth to be set to a sane value or zero to use the appropriate default for the version of PL011 present on the device.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ryan Harkin ryan.harkin@linaro.org
Reviewed-by: Ard Biesheuvel ard.biesheuvel@linaro.org
So, do you guys have good test results with this patch in Platforms/... and Ray's patch http://thread.gmane.org/gmane.comp.bios.edk2.devel/9880 in edk2? If so, please state it in the edk2-devel thread, so I can ACK Ray's patch.
Yes, after applying Ryan's patch to FVP and reverting 31ae446b1a039a55d0336f2201d77d1032533413, my cursor keys still work
Copy/paste is another matter though, but that requires Heyi's changes as well.
Thanks, Ard.