Re: [Linaro-uefi] [PATCH v2 1/2] Platforms/AMD: correct legacy PCI interrupt routing in DSDT

On Sat, Apr 08, 2017 at 06:14:52PM +0100, Ard Biesheuvel wrote:

The _PRT method in the PCI0 object describes something that resembles the legacy interrupt routing of the first slot only, but applies it to all PCI-PCI bridges, which means the wrong interrupt is reported for devices in slots 2 and 3. Since most devices support MSI, this is not actually a big deal, but it would be nice to fix this nonetheless.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ard.biesheuvel@linaro.org

Ok, fully caught up on discussion now, this looks correct as per termination of discussion until we get any form of definitive answer from AMD or other ACPI PCI expert.

Reviewed-by: Graeme Gregory graeme.gregory@linaro.org

---

Platforms/AMD/Styx/AcpiTables/Dsdt.asl | 63 +++++++++++--------- 1 file changed, 34 insertions(+), 29 deletions(-)

diff --git a/Platforms/AMD/Styx/AcpiTables/Dsdt.asl b/Platforms/AMD/Styx/AcpiTables/Dsdt.asl index 3bfa26acea07..4741bb487cc7 100644 --- a/Platforms/AMD/Styx/AcpiTables/Dsdt.asl +++ b/Platforms/AMD/Styx/AcpiTables/Dsdt.asl @@ -508,40 +508,45 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "AMDINC", "SEATTLE ", 3) Name (_SEG, 0x00) // _SEG: PCI Segment Name (_BBN, 0x00) // _BBN: BIOS Bus Number Name (_CCA, 0x01) // _CCA: Cache Coherency Attribute

•        Name (_PRT, Package (0x04)  // _PRT: PCI Routing Table
  

•        Name (_PRT, Package ()  // _PRT: PCI Routing Table
         {
  

•            Package (0x04)
  

•            {
  

•                0xFFFF,
  

•                0x00,
  

•                0x00,
  

•                0x0140
  

•            },
  

•            // INTA of the bridge device itself
  

•            Package () { 0x2FFFF, 0x0, 0x0, 0x140 }
  

•        })
  

•            Package (0x04)
  

•        Device (EXP1)
  

•        {
  

•            Name (_ADR, 0x20001)  // _ADR: Address
  

•            Name (_PRT, Package ()  // _PRT: PCI Routing Table
             {
  

•                0xFFFF,
  

•                0x01,
  

•                0x00,
  

•                0x0141
  

•            },
  

•            Package (0x04)
  

•                Package () { 0xFFFF, 0x0, 0x0, 0x140 },
  

•                Package () { 0xFFFF, 0x1, 0x0, 0x141 },
  

•                Package () { 0xFFFF, 0x2, 0x0, 0x142 },
  

•                Package () { 0xFFFF, 0x3, 0x0, 0x143 }
  

•            }) // _PRT
  

•        }
  

•        Device (EXP2)
  

•        {
  

•            Name (_ADR, 0x20002)  // _ADR: Address
  

•            Name (_PRT, Package ()  // _PRT: PCI Routing Table
             {
  

•                0xFFFF,
  

•                0x02,
  

•                0x00,
  

•                0x0142
  

•            },
  

•            Package (0x04)
  

•                Package () { 0xFFFF, 0x0, 0x0, 0x144 },
  

•                Package () { 0xFFFF, 0x1, 0x0, 0x145 },
  

•                Package () { 0xFFFF, 0x2, 0x0, 0x146 },
  

•                Package () { 0xFFFF, 0x3, 0x0, 0x147 }
  

•            }) // _PRT
  

•        }
  

•        Device (EXP3)
  

•        {
  

•            Name (_ADR, 0x20003)  // _ADR: Address
  

•            Name (_PRT, Package ()  // _PRT: PCI Routing Table
             {
  

•                0xFFFF,
  

•                0x03,
  

•                0x00,
  

•                0x0143
  

•            }
  

•        }) // _PRT
  

•                Package () { 0xFFFF, 0x0, 0x0, 0x148 },
  

•                Package () { 0xFFFF, 0x1, 0x0, 0x149 },
  

•                Package () { 0xFFFF, 0x2, 0x0, 0x14A },
  

•                Package () { 0xFFFF, 0x3, 0x0, 0x14B }
  

•            }) // _PRT
  

•        }
  

Method (_CRS, 0, Serialized) // _CRS: Current Resource Settings { -- 2.9.3