OK, I will modify the subject line and drop the change about PlatformIntelBdsLib. Also other comments will be handled.
On 2018/1/23 18:28, Leif Lindholm wrote:
I don't agree with this subject line - there is no optimization going on here.
"Break BMC SetBoot option out into separate library" would be a more accurate subject line.
For the record, I think this is good cleanup even without the dual-BDS support.
On Thu, Jan 18, 2018 at 11:01:32PM +0800, Ming Huang wrote:
diff --git a/Silicon/Hisilicon/Library/BmcConfigBootLib/BmcConfigBootLib.inf b/Silicon/Hisilicon/Library/BmcConfigBootLib/BmcConfigBootLib.inf new file mode 100644 index 0000000..7e407b4 --- /dev/null +++ b/Silicon/Hisilicon/Library/BmcConfigBootLib/BmcConfigBootLib.inf @@ -0,0 +1,51 @@ +#/** @file +# +# Copyright (c) 2015, Hisilicon Limited. All rights reserved. +# Copyright (c) 2015, Linaro Limited. All rights reserved. +# +# This program and the accompanying materials +# are licensed and made available under the terms and conditions of the BSD License +# which accompanies this distribution. The full text of the license may be found at +# http://opensource.org/licenses/bsd-license.php +# +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. +# +#**/
+[Defines]
- INF_VERSION = 0x00010005
0x0001001a
- BASE_NAME = BmcConfigBootLib
- FILE_GUID = f174d192-7208-46c1-b9d1-65b2db06ad3b
- MODULE_TYPE = BASE
- VERSION_STRING = 1.0
- LIBRARY_CLASS = BmcConfigBootLib
+[Sources.common]
- BmcConfigBootLib.c
+[Packages]
- MdePkg/MdePkg.dec
- MdeModulePkg/MdeModulePkg.dec
MdeM before MdeP
/ Leif
- Silicon/Hisilicon/HisiPkg.dec
+[LibraryClasses]
- BaseLib
- BaseMemoryLib
- DebugLib
- DevicePathLib
- IpmiCmdLib
- PcdLib
- PrintLib
- UefiBootManagerLib
+[BuildOptions]
+[Pcd]
+[Guids]
- gEfiEventReadyToBootGuid
+[Protocols]
- gEfiDevicePathToTextProtocolGuid ## CONSUMES
- gEfiSimpleFileSystemProtocolGuid ## CONSUMES
.