On 6 June 2016 at 15:27, Ryan Harkin ryan.harkin@linaro.org wrote:
Hi Alexei,
On 6 June 2016 at 15:04, Alexei Fedorov Alexei.Fedorov@arm.com wrote:
Hello,
The following compilation condition in OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\Fadt.aslc
#if ARM_JUNO_ACPI_5_0
causes the GCC error listed below
k:\edk2\OpenPlatformPkg\Platforms\ARM\Juno\AcpiTables\Fadt.aslc:76:22: error: #if with no expression
#if ARM_JUNO_ACPI_5_0
^when ARM_JUNO_ACPI_5_0 macro is defined in edk2\ArmPlatformPkg\ArmJunoPkg\Include\ArmPltaform.h:
#define ARM_JUNO_ACPI_5_0
To fix the bug
#if ARM_JUNO_ACPI_5_0
should be replaced with
#ifdef ARM_JUNO_ACPI_5_0
(also see the previous usage on line #20 in the same file)
I guess this is GCC version specific. Either way, it looks like the correct fix.
I think you just need to turn it into a patch and submit it via this list and the EDK2 list, with Leif in the To: field.
My mistake, there's no need to CC the EDK2 list as this is OpenPlatformPkg code.
Cheers, Ryan.
Alexei.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
Linaro-uefi mailing list Linaro-uefi@lists.linaro.org https://lists.linaro.org/mailman/listinfo/linaro-uefi