On Fri, Oct 14, 2016 at 06:46:47PM +0200, Marcin Wojtas wrote:
Hi Leif,
Thanks for review. Regarding 'Reviewed-by' - it was conditional and the patch later changed, so it was sent without. Would it be fine to resend only patch 4/5?
Well, it wasn't really conditional - it was more a request for an explanation about 4/5, which I didn't notice until looking at 5/5.
Yeah, I'm happy for it to stay and only 4/5 being resent.
Thanks,
Leif
Best regards, Marcin
2016-10-14 18:43 GMT+02:00 Leif Lindholm leif.lindholm@linaro.org:
On Fri, Oct 14, 2016 at 12:44:20PM +0200, Marcin Wojtas wrote:
From: Bartosz Szczepanek bsz@semihalf.com
MvResetSystemLib implements EfiResetSystemLib required by ResetSystem runtime service driver.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jan Dabros jsd@semihalf.com Signed-off-by: Marcin Wojtas mw@semihalf.com
(I did give this one a Reviewed-by: Leif Lindholm leif.lindholm@linaro.org last time around.)
Platforms/Marvell/Armada/Armada.dsc.inc | 2 +- Platforms/Marvell/Armada/Armada70x0.dsc | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/Platforms/Marvell/Armada/Armada.dsc.inc b/Platforms/Marvell/Armada/Armada.dsc.inc index 490799b..7b47920 100644 --- a/Platforms/Marvell/Armada/Armada.dsc.inc +++ b/Platforms/Marvell/Armada/Armada.dsc.inc @@ -89,8 +89,8 @@ PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePlatformHookLibNull.inf
# Reset and Time libraries
- EfiResetSystemLib|EmbeddedPkg/Library/TemplateResetSystemLib/TemplateResetSystemLib.inf RealTimeClockLib|EmbeddedPkg/Library/TemplateRealTimeClockLib/TemplateRealTimeClockLib.inf
EfiResetSystemLib|OpenPlatformPkg/Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.inf
# Network support NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
diff --git a/Platforms/Marvell/Armada/Armada70x0.dsc b/Platforms/Marvell/Armada/Armada70x0.dsc index 4f08e88..de314b9 100644 --- a/Platforms/Marvell/Armada/Armada70x0.dsc +++ b/Platforms/Marvell/Armada/Armada70x0.dsc @@ -122,3 +122,7 @@ gMarvellTokenSpaceGuid.PcdPhyConnectionTypes|{ 0x0, 0x0 } gMarvellTokenSpaceGuid.PcdPhyDeviceIds|{ 0x0, 0x0 } gMarvellTokenSpaceGuid.PcdPhyStartupAutoneg|FALSE
- #ResetLib
- gMarvellTokenSpaceGuid.PcdResetRegAddress|0xf06f0084
- gMarvellTokenSpaceGuid.PcdResetRegMask|0x1
-- 1.8.3.1