On 18 April 2017 at 15:26, Ard Biesheuvel ard.biesheuvel@linaro.org wrote:
On 18 April 2017 at 15:21, Leif Lindholm leif.lindholm@linaro.org wrote:
Hi all,
I have started the prototyping of moving the existing OpenPlatformPkg ports into edk2-platforms (and edk2-non-osi).
Doing some due dilligence, I've spotted that the "Contributed-under: " tag has been left out from some commits. Clearly, most of those were mine (oops), so let me just formally state that:
b9ac9979d4ddc4da77fa41a99dbbf68d26520a22 1c90ac121061b221a83bc052a7e22371d0da3c01 2146aa238a2b687a4a8ed408ca784f5b70321444 979db78c884e538626a3d026996eb348a84c6787
were indeed Contributed-under: TianoCore Contribution Agreement 1.0
Ard, could you confirm the same for: 084445120e94910025e02fe66ac528a3f4cc303a
Contributed-under: TianoCore Contribution Agreement 1.0
df47cec139b01f9491d7e9608d832dd0c34fa363
Contributed-under: TianoCore Contribution Agreement 1.0
but only if we can't retroactively wipe it from the history.
and Ryan for: 50babddd0cb440742bf4d0341f319239317eba5d
Ooops! Sorry about that, yes, I confirm that it is:
Contributed-under: TianoCore Contribution Agreement 1.0
given that we are both employed by Linaro.
Thanks Ard! :-)
?
Ard, there are also some missing Reviewed-by - do you agree with me that this is not an issue (they are all implicitly reviewed by either you or me), just something to be more careful of in future?
Yes, I agree that all contributions must have a reviewed-by tag, although my committing of a patch from someone else may be taken as one as well.