On Tue, Jul 14, 2015 at 10:41:28AM +0100, Ian Campbell wrote:
On Tue, 2015-07-14 at 06:53 +0300, Andrei Borzenkov wrote:
+if [ "x$machine" != xaarch64 ]; then
- multiboot_cmd="multiboot"
- module_cmd="module"
And we should use the grub-file --is-multiboot2 to figure out if the Xen binary can also do that - and use multiboot2 protocol.
But that patch I can cobble after this one is done.
+else
- multiboot_cmd="xen_hypervisor"
- module_cmd="xen_module"
+fi
Strictly speaking, this is boot-time decision. As mentioned by Vladimir, better would be to provide alias xen_hypervisor and xen_module in multiboot for platforms supporting Xen (is MIPS really supported?) and use it consistently.
I had been thinking of this the other way around, e.g. on platforms which support Xen but not multiboot1 "multiboot" would be added as an alias for xen_hypervisor.
However so long as grub-mkconfig (via 20_linux_xen) work for everyone and that peoples existing hand-crafted x86/multiboot/Xen grub.cfg's continue to work then I think having the alias go either way would be fine.
BTW I had been going to suggest a function at the grub.cfg level which dispatched to the correct command, but I suppose an actual alias is better.
Ian.
Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel