Re: [Linaro-uefi] [PATCH 04/28] D02/D03/Dsdt: add media-type property for hns

Thanks.

Heyi - can you add these Reviewed-by:s when sending out the next version?

Regards,

Leif

On Thu, Nov 17, 2016 at 11:48:52AM +0000, graeme.gregory@linaro.org wrote:

Sorry I thought I had, it looks fine to me

Reviewed-by: Graeme Gregory graeme.gregory@linaro.org

On Thu, Nov 17, 2016 at 05:06:16PM +0800, Heyi Guo wrote:

...

hi Graeme/Hanjun,

Could you help to review it?

Thanks and Regards. heyi.

在 11/15/2016 10:28 PM, Leif Lindholm 写道:

...

On Mon, Nov 14, 2016 at 07:29:31PM +0800, Heyi Guo wrote:

...

It is PORT_TP type if the service port is GE mode. It is wrong to judge the port type by using if it is service port. Adding the media type to know port type.

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Kejian Yan yankejian@huawei.com

Looks sane to me - Graeme/Hanjun?

...

---

Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/D03Hns.asl | 4 ++++ Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Hns.asl | 4 ++++ 2 files changed, 8 insertions(+)

diff --git a/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/D03Hns.asl b/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/D03Hns.asl index aa83489..b62ee45 100644 --- a/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/D03Hns.asl +++ b/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/D03Hns.asl @@ -466,6 +466,7 @@ Scope(_SB) ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () { Package () {"reg", 0},

•            Package () {"media-type", "fiber"},
                      }
              })
  }
  

@@ -476,6 +477,7 @@ Scope(_SB) ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () { Package () {"reg", 1},

•            Package () {"media-type", "fiber"},
                      }
              })
  }
  

@@ -489,6 +491,7 @@ Scope(_SB) Package () {"phy-mode", "sgmii"}, Package () {"phy-addr", 0}, Package () {"mdio-node", Package (){_SB.MDIO}},

•            Package () {"media-type", "copper"},
                      }
              })
  }
  

@@ -502,6 +505,7 @@ Scope(_SB) Package () {"phy-mode", "sgmii"}, Package () {"phy-addr", 1}, Package () {"mdio-node", Package (){_SB.MDIO}},

•            Package () {"media-type", "copper"},
                      }
              })
  }
  

diff --git a/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Hns.asl b/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Hns.asl index 5945fc3..2b08a1f 100644 --- a/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Hns.asl +++ b/Chips/Hisilicon/Pv660/Pv660AcpiTables/Dsdt/Hns.asl @@ -439,6 +439,7 @@ Scope(_SB) ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () { Package () {"reg", 0},

•      Package () {"media-type", "fiber"},
                      }
              })
  }
  

@@ -449,6 +450,7 @@ Scope(_SB) ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () { Package () {"reg", 1},

•      Package () {"media-type", "fiber"},
                      }
              })
  }
  

@@ -462,6 +464,7 @@ Scope(_SB) Package () {"phy-mode", "sgmii"}, Package () {"phy-addr", 0}, Package () {"mdio-node", Package (){_SB.MDIO}},

•      Package () {"media-type", "copper"},
                      }
              })
  }
  

@@ -475,6 +478,7 @@ Scope(_SB) Package () {"phy-mode", "sgmii"}, Package () {"phy-addr", 1}, Package () {"mdio-node", Package (){_SB.MDIO}},

•      Package () {"media-type", "copper"},
                      }
              })
  }
  

-- 1.9.1