On 12 February 2016 at 11:01, Ard Biesheuvel ard.biesheuvel@linaro.org wrote:
On 12 February 2016 at 11:59, Ryan Harkin ryan.harkin@linaro.org wrote:
I've realised the error of my ways
Does that include your position in the DT discussion we had yesterday? :-)
Oh, I'm still right about that :-)
and decided to drop this patch.
But seriously, care to explain what made you change your mind?
Two reasons really: I can pass the flag in to uefi-build.sh using the -D param, so I don't think we need the clutter on the config file.
I think having a "full" and "normal" config is fine, because most people probably don't want the performance hit of the PL111 CLCD output.
Another reason is that I'm not using EDK2 to support my kernel releases any more, so it doesn't matter that we're still clinging on to a gicv2 DTB over there.
On 11 February 2016 at 17:57, Ryan Harkin ryan.harkin@linaro.org wrote:
Add a new config to build with the ARM_FVP_GICV3_WITH_V2_LEGACY flag.
Signed-off-by: Ryan Harkin ryan.harkin@linaro.org
platforms.config | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/platforms.config b/platforms.config index 48ccc05..93368f1 100644 --- a/platforms.config +++ b/platforms.config @@ -100,6 +100,16 @@ ATF_PLATFORM=fvp UEFI_BIN=FVP_AARCH64_EFI.fd UEFI_IMAGE_DIR=ArmVExpress-FVP-AArch64-Minimal
+[fvp_gicv2_legacy] +LONGNAME=aarch64 FVP RTSM/Foundation with Ethernet and GICv3 in GICv2 legacy mode +DSC=OpenPlatformPkg/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc +BUILDFLAGS=-D EDK2_ENABLE_SMSC_91X=1 -D EDK2_OUT_DIR=Build/ArmVExpress-FVP-AArch64-gicv2legacy -D ARM_FVP_GICV3_WITH_V2_LEGACY=1 +ARCH=AARCH64 +BUILD_ATF=yes +ATF_PLATFORM=fvp +UEFI_BIN=FVP_AARCH64_EFI.fd +UEFI_IMAGE_DIR=ArmVExpress-FVP-AArch64-Minimal
[fvp_no_eth] LONGNAME=aarch64 FVP RTSM without Ethernet DSC=OpenPlatformPkg/Platforms/ARM/VExpress/ArmVExpress-FVP-AArch64.dsc -- 2.1.4