On Thu, Aug 17, 2017 at 11:42:23PM +0800, Jun Nie wrote:
On 2017年08月10日 21:04, Leif Lindholm wrote:
diff --git a/Silicon/Sanchip/Zx296718/Include/Zx296718.h b/Silicon/Sanchip/Zx296718/Include/Zx296718.h new file mode 100644 index 0000000..3ace9ab --- /dev/null +++ b/Silicon/Sanchip/Zx296718/Include/Zx296718.h @@ -0,0 +1,30 @@ +/** @file +* +* Copyright (c) 2016, Linaro Limited. All rights reserved.
Guess 2016-2017 by now?
+* +* This program and the accompanying materials +* are licensed and made available under the terms and conditions of the BSD License +* which accompanies this distribution. The full text of the license may be found at +* http://opensource.org/licenses/bsd-license.php +* +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. +* +**/
+#ifndef __ZX296718_H__ +#define __ZX296718_H__
Coding style specifies: "Every header file must have a ‘#ifndef FILE_NAME_H_’ and ‘#endif’ guard" so you could drop 3 of those underscores.
Will change it. Is there any coding style readme file? Because I find most of header file use __FILE_NAME_H__ sytle macro.
Ah, yes - it helps knowing it exists :)
It is the C Coding Standards document on https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Specifications You will potentially find other documents there useful as well.
/ Leif