23 Mar
2017
23 Mar
'17
6:40 p.m.
On 23 March 2017 at 01:30, Marcin Wojtas mw@semihalf.com wrote:
Hi,
Quick resend of the RTC support - one file remained unstaged and had to be added. I'm sorry for noise. All details can be found in the changelog below.
The patches are also available in the github. https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/opp-...
Any comments or remarks would be very welcome.
Best regards, Marcin
Changelog: v2 -> v3:
- Add missing local header
- Slightly reword patch 2/2 commit log
Reviewed-by: Ard Biesheuvel ard.biesheuvel@linaro.org
Pushed, thanks.
--
Ard.
> v1 -> v2:
> * Include <Library/UefiBootServicesTableLib.h> instead of extern *gBS
> * Remove RtcReset function entirely
> * Add RtcDelayedWrite helper function for modification of time and alarm
> registers - cleaner code, with common valid comment.
> * Use MmioAndThenOr32 instead of RtcUpdateMbusTimingParams function, remove
> magic
> * Add proper error path instead of assertions
> * Move defines to local header
> * Create new RTC description template in MvHwDescLib.h and use it for
> obtaining controller data.
> * Sort packages in inf file
>
> Marcin Wojtas (2):
> Platforms/Marvell: Introduce RTC support
> Platforms/Marvell: Enable RTC library on Armada70x0 platforms
>
> Platforms/Marvell/Armada/Armada.dsc.inc | 3 +-
> Platforms/Marvell/Armada/Armada70x0.dsc | 3 +
> .../Library/RealTimeClockLib/RealTimeClockLib.c | 335 +++++++++++++++++++++
> .../Library/RealTimeClockLib/RealTimeClockLib.h | 50 +++
> .../Library/RealTimeClockLib/RealTimeClockLib.inf | 53 ++++
> Platforms/Marvell/Include/Library/MvHwDescLib.h | 25 ++
> Platforms/Marvell/Marvell.dec | 3 +
> 7 files changed, 471 insertions(+), 1 deletion(-)
> create mode 100644 Platforms/Marvell/Armada/Library/RealTimeClockLib/RealTimeClockLib.c
> create mode 100644 Platforms/Marvell/Armada/Library/RealTimeClockLib/RealTimeClockLib.h
> create mode 100644 Platforms/Marvell/Armada/Library/RealTimeClockLib/RealTimeClockLib.inf
>
> --
> 1.8.3.1
>