On 17 June 2016 at 01:33, Daniil Egranov daniil.egranov@arm.com wrote:
Changes since v1: Added declaration of PcdYukonMacAddress to MarvellYukonDxe.dec The patch has been split due to its size.
Changes since v2: Added device configuration protocol to support MAC address update.
Changes since v3: Corrected debug error levels for console messages. Corrected prefixes for console messages. Fixed controllers/protocols startup and shutdown procedure. Fixed TPLs for critical sections. General code clean up.
NOTE: The Marvell Yukon patch has been split up into three parts due to its size and has to be applied as a single patch.
I think it's worth noting that this series depends on your other series for EDK2 that you've posted, but that isn't upstream yet:
[PATCH 0/2] Marvell Yukon MAC address configuration on Juno platform
One can find both of those on top of my EDK2 fork [1] and these 4 driver patches, squashed down in my OpenPlatformPkg fork [2].
I've tested this on Juno R1 and R2 and made sure that Juno R0 isn't broken by the introduction of the new driver.
So, for the whole series:
Tested-by: Ryan Harkin ryan.harkin@linaro.org
I provided some review feedback for the driver, but I haven't reviewed the code in detail enough to give a Reviewed-by, sorry.
[1] https://git.linaro.org/landing-teams/working/arm/edk2.git/shortlog/refs/tags... https://git.linaro.org/landing-teams/working/arm/OpenPlatformPkg.git/shortlo...
Daniil Egranov (4): OpenPlatformPkg/MarvellYukonDxe: Marvell Yukon NIC driver 1/3 OpenPlatformPkg/MarvellYukonDxe: Marvell Yukon NIC driver 2/3 OpenPlatformPkg/MarvellYukonDxe: Marvell Yukon NIC driver 3/3 OpenPlatformPkg/Juno: Enable Marvell Yukon NIC driver on Juno platform
Drivers/Net/MarvellYukonDxe/ComponentName.c | 313 +++ Drivers/Net/MarvellYukonDxe/DeviceConfig.c | 330 +++ Drivers/Net/MarvellYukonDxe/DeviceConfig.h | 98 + Drivers/Net/MarvellYukonDxe/DriverBinding.c | 510 ++++ Drivers/Net/MarvellYukonDxe/MarvellYukon.h | 712 ++++++ Drivers/Net/MarvellYukonDxe/MarvellYukonDxe.dec | 29 + Drivers/Net/MarvellYukonDxe/MarvellYukonDxe.inf | 77 + Drivers/Net/MarvellYukonDxe/Snp.c | 1417 +++++++++++ Drivers/Net/MarvellYukonDxe/e1000phy.c | 659 +++++ Drivers/Net/MarvellYukonDxe/e1000phyreg.h | 398 +++ Drivers/Net/MarvellYukonDxe/if_media.h | 273 +++ Drivers/Net/MarvellYukonDxe/if_msk.c | 3001 +++++++++++++++++++++++ Drivers/Net/MarvellYukonDxe/if_msk.h | 52 + Drivers/Net/MarvellYukonDxe/if_mskreg.h | 2491 +++++++++++++++++++ Drivers/Net/MarvellYukonDxe/miivar.h | 198 ++ Platforms/ARM/Juno/ArmJuno.dsc | 4 + Platforms/ARM/Juno/ArmJuno.fdf | 1 + 17 files changed, 10563 insertions(+) create mode 100644 Drivers/Net/MarvellYukonDxe/ComponentName.c create mode 100644 Drivers/Net/MarvellYukonDxe/DeviceConfig.c create mode 100644 Drivers/Net/MarvellYukonDxe/DeviceConfig.h create mode 100644 Drivers/Net/MarvellYukonDxe/DriverBinding.c create mode 100644 Drivers/Net/MarvellYukonDxe/MarvellYukon.h create mode 100644 Drivers/Net/MarvellYukonDxe/MarvellYukonDxe.dec create mode 100644 Drivers/Net/MarvellYukonDxe/MarvellYukonDxe.inf create mode 100644 Drivers/Net/MarvellYukonDxe/Snp.c create mode 100644 Drivers/Net/MarvellYukonDxe/e1000phy.c create mode 100644 Drivers/Net/MarvellYukonDxe/e1000phyreg.h create mode 100644 Drivers/Net/MarvellYukonDxe/if_media.h create mode 100644 Drivers/Net/MarvellYukonDxe/if_msk.c create mode 100644 Drivers/Net/MarvellYukonDxe/if_msk.h create mode 100644 Drivers/Net/MarvellYukonDxe/if_mskreg.h create mode 100644 Drivers/Net/MarvellYukonDxe/miivar.h
-- 2.7.4
Linaro-uefi mailing list Linaro-uefi@lists.linaro.org https://lists.linaro.org/mailman/listinfo/linaro-uefi