On Wed, 2015-07-15 at 18:18 +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
On 13.07.2015 10:53, fu.wei@linaro.org wrote:
From: Fu Wei fu.wei@linaro.org
This patch adds Xen boot support file: grub-core/loader/arm64/xen_boot.c include/grub/arm64/xen_boot.h
This patch also adds commands register code and hearder file into grub-core/loader/arm64/linux.c
- This adds support for the Xen boot on ARM specification for arm64.
- The implementation for Xen is following <Multiboot on ARM Specification>: http://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions/Multiboot
Please don't refer to this protocol as multiboot anywhere in grub or around because it's NOT multiboot and we don't want to confuse those 2 protocols.
That's fair enough, my hope was that the docs and communal knowledge about how to write a grub.cfg for Xen x86/multiboot could remain unchanged for Xen on arm (e.g. by using the same multiboot1 command names, which surely won't be reused on arm), but I can see why you would object to that and updating 20_linux_xen to DTRT on both arches solves the majority of that concern.
WRT to what to call it instead: I did try and design it[0] to not be Xen specific, so it would be nice to avoid making it so in the command names if possible. I suspect this may lead to a certain amount of bikeshedding, if so we should just call it something Xen specific and move on I think.
For a non-Xen specific name how about "fbm -- fdt boot module" protocol and associated commands fbm_kernel + fbm_module?
Ian.
[0] http://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions/Multiboot